From: Daniel Arndt <daniel.arndt@iwr.uni-heidelberg.de>
Date: Fri, 11 Jan 2019 12:33:06 +0000 (+0100)
Subject: Improve HDF5 files
X-Git-Tag: v9.1.0-rc1~408^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=dcb675a7ec9b1f1ace8f314aed638ed0757c1510;p=dealii.git

Improve HDF5 files
---

diff --git a/include/deal.II/base/hdf5.h b/include/deal.II/base/hdf5.h
index a036daa425..5a6c19a927 100644
--- a/include/deal.II/base/hdf5.h
+++ b/include/deal.II/base/hdf5.h
@@ -318,7 +318,7 @@ namespace HDF5
      * Constructor. @p string_name is the name of the HDF5 Object. If @p mpi is
      * True then MPI I/O is used.
      */
-    HDF5Object(const std::string name, const bool mpi);
+    HDF5Object(const std::string &name, const bool mpi);
 
   public:
     /**
@@ -404,11 +404,11 @@ namespace HDF5
      * Create dataset. This is an internal constructor. The function
      * Group::create_dataset() should be used to create a dataset.
      */
-    DataSet(const std::string &         name,
-            const hid_t &               parent_group_id,
-            const std::vector<hsize_t> &dimensions,
-            std::shared_ptr<hid_t>      t_type,
-            const bool                  mpi);
+    DataSet(const std::string &           name,
+            const hid_t &                 parent_group_id,
+            const std::vector<hsize_t> &  dimensions,
+            const std::shared_ptr<hid_t> &t_type,
+            const bool                    mpi);
 
   public:
     /**
diff --git a/source/base/hdf5.cc b/source/base/hdf5.cc
index b5ff668b92..86732e5b0c 100644
--- a/source/base/hdf5.cc
+++ b/source/base/hdf5.cc
@@ -196,7 +196,7 @@ namespace HDF5
       std::is_same<Container,
                    std::vector<typename Container::value_type>>::value,
       Container>::type
-    initialize_container(const std::vector<hsize_t> dimensions)
+    initialize_container(const std::vector<hsize_t> &dimensions)
     {
       return Container(std::accumulate(
         dimensions.begin(), dimensions.end(), 1, std::multiplies<int>()));
@@ -208,7 +208,7 @@ namespace HDF5
     typename std::enable_if<
       std::is_same<Container, Vector<typename Container::value_type>>::value,
       Container>::type
-    initialize_container(const std::vector<hsize_t> dimensions)
+    initialize_container(const std::vector<hsize_t> &dimensions)
     {
       return Container(std::accumulate(
         dimensions.begin(), dimensions.end(), 1, std::multiplies<int>()));
@@ -371,7 +371,7 @@ namespace HDF5
 
 
 
-  HDF5Object::HDF5Object(const std::string name, const bool mpi)
+  HDF5Object::HDF5Object(const std::string &name, const bool mpi)
     : name(name)
     , mpi(mpi)
   {}
@@ -387,16 +387,15 @@ namespace HDF5
     hid_t                        attr;
     herr_t                       ret;
 
-
     attr = H5Aopen(*hdf5_reference, attr_name.data(), H5P_DEFAULT);
     Assert(attr >= 0, ExcMessage("Error at H5Aopen"));
+    (void)ret;
     ret = H5Aread(attr, *t_type, &value);
     Assert(ret >= 0, ExcMessage("Error at H5Aread"));
+    (void)ret;
     ret = H5Aclose(attr);
     Assert(ret >= 0, ExcMessage("Error at H5Aclose"));
 
-    // This avoids the unused warning
-    (void)ret;
     return value;
   }
 
@@ -414,14 +413,13 @@ namespace HDF5
     attr = H5Aopen(*hdf5_reference, attr_name.data(), H5P_DEFAULT);
     Assert(attr >= 0, ExcMessage("Error at H5Aopen"));
     ret = H5Aread(attr, H5T_NATIVE_INT, &int_value);
+    (void)ret;
     Assert(ret >= 0, ExcMessage("Error at H5Aread"));
     ret = H5Aclose(attr);
+    (void)ret;
     Assert(ret >= 0, ExcMessage("Error at H5Aclose"));
-    // The int can be casted to a bool
-    bool bool_value = (bool)int_value;
 
-    (void)ret;
-    return bool_value;
+    return (int_value != 0);
   }
 
 
@@ -536,10 +534,6 @@ namespace HDF5
     hid_t  t_type;
     herr_t ret;
 
-    // Reserve space for the string and the null terminator
-    char *c_string_value = (char *)malloc(sizeof(char) * (value.size() + 1));
-    strcpy(c_string_value, value.data());
-
     /* Create a datatype to refer to. */
     t_type = H5Tcopy(H5T_C_S1);
     Assert(t_type >= 0, ExcInternalError());
@@ -562,11 +556,14 @@ namespace HDF5
 
     /*
      * Write scalar attribute.
+     * In most of the cases H5Awrite and H5Dwrite take a pointer to the data.
+     * But in the particular case of a variable length string, H5Awrite takes
+     * the address of the pointer of the string.
      */
-    ret = H5Awrite(attr, t_type, &c_string_value);
+    const char *c_string_value = value.c_str();
+    ret                        = H5Awrite(attr, t_type, &c_string_value);
     Assert(ret >= 0, ExcInternalError());
 
-    free(c_string_value);
     ret = H5Sclose(aid);
     Assert(ret >= 0, ExcMessage("Error at H5Sclose"));
     ret = H5Aclose(attr);
@@ -631,11 +628,11 @@ namespace HDF5
 
 
 
-  DataSet::DataSet(const std::string &         name,
-                   const hid_t &               parent_group_id,
-                   const std::vector<hsize_t> &dimensions,
-                   std::shared_ptr<hid_t>      t_type,
-                   const bool                  mpi)
+  DataSet::DataSet(const std::string &           name,
+                   const hid_t &                 parent_group_id,
+                   const std::vector<hsize_t> &  dimensions,
+                   const std::shared_ptr<hid_t> &t_type,
+                   const bool                    mpi)
     : HDF5Object(name, mpi)
     , rank(dimensions.size())
     , dimensions(dimensions)
@@ -1002,7 +999,7 @@ namespace HDF5
       internal::get_hdf5_datatype<typename Container::value_type>();
     // In this particular overload of write_hyperslab the data_dimensions are
     // the same as count
-    const std::vector<hsize_t> data_dimensions = count;
+    const std::vector<hsize_t> &data_dimensions = count;
 
     hid_t  memory_dataspace;
     hid_t  plist;