From: Timo Heister <timo.heister@gmail.com>
Date: Tue, 17 Mar 2020 15:06:02 +0000 (-0400)
Subject: clang 4 constexpr detection
X-Git-Tag: v9.2.0-rc1~409^2~1
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e2b184644267667503b8befb2752df4e644e2c1d;p=dealii.git

clang 4 constexpr detection

At least clang 4.0.1 complains about the use of non-const constexpr
functions. Fix this by setting
DEAL_II_HAVE_CXX14_CONSTEXPR_CAN_CALL_NONCONSTEXPR only if we actually
have CXX14 support.
---

diff --git a/cmake/checks/check_01_cxx_features.cmake b/cmake/checks/check_01_cxx_features.cmake
index a80d781c10..a723c66d37 100644
--- a/cmake/checks/check_01_cxx_features.cmake
+++ b/cmake/checks/check_01_cxx_features.cmake
@@ -729,13 +729,17 @@ CHECK_CXX_SOURCE_COMPILES(
 # As long as there exists an argument value such that an invocation of the
 # function or constructor could be an evaluated subexpression of a core constant
 # expression, C++14 allows to call non-constexpr functions from constexpr
-# functions. Unfortunately, not all compilers obey the standard in this regard.
+# functions.
 #
-# In some cases, MSVC 2019 crashes with an internal compiler error when we
+# Only run this check if we have CXX14 support, otherwise the use of constexpr
+# is limited (non-const constexp functions for example).
+#
+# Unfortunately, not all compilers obey the standard in this regard. In some
+# cases, MSVC 2019 crashes with an internal compiler error when we
 # declare the respective functions as 'constexpr' even though the test below
 # passes, see #9080.
 #
-IF(NOT CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
+IF(DEAL_II_WITH_CXX14 AND NOT CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
   CHECK_CXX_SOURCE_COMPILES(
     "
     #define Assert(x,y) if (!(x)) throw y;