From: Daniel Arndt <daniel.arndt@iwr.uni-heidelberg.de>
Date: Wed, 12 Dec 2018 23:29:00 +0000 (+0100)
Subject: Avoid C-style casts in some tests
X-Git-Tag: v9.1.0-rc1~493^2~1
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e5233d55b52668f9a523870b5cb02f27f5ccbda8;p=dealii.git

Avoid C-style casts in some tests
---

diff --git a/tests/quick_tests/affinity.cc b/tests/quick_tests/affinity.cc
index db80e93c98..edde64a356 100644
--- a/tests/quick_tests/affinity.cc
+++ b/tests/quick_tests/affinity.cc
@@ -50,7 +50,7 @@ getaffinity(unsigned int &bits_set, unsigned int &mask)
   for (int i = 0; i < CPU_SETSIZE; ++i)
     bits_set += CPU_ISSET(i, &my_set);
 
-  mask = *(int *)(&my_set);
+  mask = *reinterpret_cast<int *>(&my_set);
 #else
   // sadly we don't have an implementation
   // for mac/windows
diff --git a/tests/quick_tests/lapack.cc b/tests/quick_tests/lapack.cc
index 2be5515cc5..fbfcc15f91 100644
--- a/tests/quick_tests/lapack.cc
+++ b/tests/quick_tests/lapack.cc
@@ -112,7 +112,7 @@ main()
   for (unsigned int i = 0; i < A.m(); ++i)
     {
       std::complex<double> lambda = LA.eigenvalue(i);
-      deallog << "Eigenvalues " << (int)(lambda.real() + .0001) << '\t'
-              << (int)(lambda.imag() + .0001) << std::endl;
+      deallog << "Eigenvalues " << static_cast<int>(lambda.real() + .0001)
+              << '\t' << static_cast<int>(lambda.imag() + .0001) << std::endl;
     }
 }
diff --git a/tests/tests.h b/tests/tests.h
index 2337c0bea5..f585da1fc7 100644
--- a/tests/tests.h
+++ b/tests/tests.h
@@ -222,7 +222,7 @@ namespace Testing
     r[k % 32] = nonoverflow_add(r[(k + 32 - 31) % 32], r[(k + 32 - 3) % 32]);
     int ret   = r[k % 32];
     k         = (k + 1) % 32;
-    return (unsigned int)ret >> 1;
+    return static_cast<unsigned int>(ret) >> 1;
   }
 
   // reseed our random number generator
@@ -315,7 +315,7 @@ checksum(const IT &begin, const IT &end)
 
   while (it != end)
     {
-      a = (a + (unsigned char)*it) % 65521;
+      a = (a + static_cast<unsigned char>(*it)) % 65521;
       b = (a + b) % 65521;
       ++it;
     }