From: wolf Date: Fri, 14 Nov 2003 14:08:52 +0000 (+0000) Subject: Add a TODO. X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e6e05597a11cd4e6cf99919c0011c4a9088e8a8d;p=dealii-svn.git Add a TODO. git-svn-id: https://svn.dealii.org/trunk@8183 0785d39b-7218-0410-832d-ea1e28bc413d --- diff --git a/deal.II/deal.II/source/fe/fe.cc b/deal.II/deal.II/source/fe/fe.cc index 117c8d32d7..eabd70b3bd 100644 --- a/deal.II/deal.II/source/fe/fe.cc +++ b/deal.II/deal.II/source/fe/fe.cc @@ -468,6 +468,7 @@ compute_2nd (const Mapping &mapping, InternalDataBase &fe_internal, FEValuesData &data) const { +//TODO[GK]: This function presently has a flaw: it ignores the offset parameter. This means that if it is called for faces or subfaces, it computes the data for _all_ faces or subfaces, even though we only need to have this for one of them. given that computing second derivatives is expensive, this is significant. What should be done is to honor the offset parameter and of course only compute what we actually need Assert ((fe_internal.update_each | fe_internal.update_once) & update_second_derivatives, ExcInternalError());