From: Matthias Maier <tamiko@43-1.org>
Date: Mon, 22 May 2023 19:00:54 +0000 (-0500)
Subject: Bugfix: Do not populate DEAL_II_LIBRARIES* variables
X-Git-Tag: v9.5.0-rc1~202^2~1
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eff1dd86acdb892a28a593b776691e2214fe6503;p=dealii.git

Bugfix: Do not populate DEAL_II_LIBRARIES* variables

We now record dependencies with interface targets. Thus, populating
these variables with redundant libraries is incorrect.
---

diff --git a/cmake/macros/macro_define_interface_target.cmake b/cmake/macros/macro_define_interface_target.cmake
index 9569c79447..85ff8da600 100644
--- a/cmake/macros/macro_define_interface_target.cmake
+++ b/cmake/macros/macro_define_interface_target.cmake
@@ -142,16 +142,12 @@ function(define_interface_target _feature)
 
     if(${_feature}_SPLIT_CONFIGURATION)
       # Future FIXME: change to block(PARENT_SCOPE)/endblock() (CMake 3.25)
-      list(APPEND DEAL_II_TARGETS_${_build} "${_interface_target}")
+      list(APPEND DEAL_II_TARGETS_${_build} ${_interface_target})
       set(DEAL_II_TARGETS_${_build} ${DEAL_II_TARGETS_${_build}} PARENT_SCOPE)
-      list(APPEND DEAL_II_LIBRARIES_${_build} "${_libraries}")
-      set(DEAL_II_LIBRARIES_${build} ${DEAL_II_LIBRARIES_${build}} PARENT_SCOPE)
     else()
       # Future FIXME: change to block(PARENT_SCOPE)/endblock() (CMake 3.25)
-      list(APPEND DEAL_II_TARGETS "${_interface_target}")
+      list(APPEND DEAL_II_TARGETS ${_interface_target})
       set(DEAL_II_TARGETS ${DEAL_II_TARGETS} PARENT_SCOPE)
-      list(APPEND DEAL_II_LIBRARIES "${_libraries}")
-      set(DEAL_II_LIBRARIES ${DEAL_II_LIBRARIES} PARENT_SCOPE)
     endif()
 
   endforeach()