From: David Wells Date: Sat, 12 Nov 2016 03:08:32 +0000 (-0500) Subject: Remove an unnecessary copy constructor. X-Git-Tag: v8.5.0-rc1~409^2~1 X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f4bfe08af8354b92a0f09617227dbf146b2e05aa;p=dealii.git Remove an unnecessary copy constructor. PVS studio rightfully complains that we should define operator= whenever we explicitly define a copy constructor. However, since our copy constructor does nothing special it is in fact equivalent to the default copy constructor, so we can just get get rid of it and let the compiler generate the correct copying code. --- diff --git a/include/deal.II/lac/petsc_matrix_base.h b/include/deal.II/lac/petsc_matrix_base.h index 4d8ca76219..0dd365bfff 100644 --- a/include/deal.II/lac/petsc_matrix_base.h +++ b/include/deal.II/lac/petsc_matrix_base.h @@ -82,11 +82,6 @@ namespace PETScWrappers const size_type row, const size_type index); - /** - * Copy constructor. - */ - Accessor (const Accessor &a); - /** * Row number of the element represented by this object. */ @@ -1000,17 +995,6 @@ namespace PETScWrappers } - inline - const_iterator::Accessor:: - Accessor (const Accessor &a) - : - matrix(a.matrix), - a_row(a.a_row), - a_index(a.a_index), - colnum_cache (a.colnum_cache), - value_cache (a.value_cache) - {} - inline const_iterator::Accessor::size_type