From: David Wells <drwells@email.unc.edu>
Date: Thu, 26 Oct 2023 21:07:36 +0000 (-0400)
Subject: Clean up get_combined_orientation() in 1D.
X-Git-Tag: relicensing~340^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f64557c627e77b48b7cf6231106e290553a1f80f;p=dealii.git

Clean up get_combined_orientation() in 1D.
---

diff --git a/include/deal.II/grid/reference_cell.h b/include/deal.II/grid/reference_cell.h
index 8167ab01b1..f7ab3ec133 100644
--- a/include/deal.II/grid/reference_cell.h
+++ b/include/deal.II/grid/reference_cell.h
@@ -2775,14 +2775,20 @@ ReferenceCell::get_combined_orientation(
 
   switch (this->kind)
     {
+      case ReferenceCells::Vertex:
+        // Things are always default-oriented in 1D
+        if (v0_equals({vertices_1[0]}))
+          return default_combined_face_orientation();
+        break;
+
       case ReferenceCells::Line:
         // line_orientation=true
         if (v0_equals({vertices_1[0], vertices_1[1]}))
-          return 1;
+          return default_combined_face_orientation();
 
         // line_orientation=false
         if (v0_equals({vertices_1[1], vertices_1[0]}))
-          return 0;
+          return reversed_combined_line_orientation();
         break;
       case ReferenceCells::Triangle:
         // face_orientation=true, face_rotation=false, face_flip=false