From: Alistair Bentley Date: Thu, 15 Jan 2015 18:22:48 +0000 (-0500) Subject: BDM Documentation X-Git-Tag: v8.3.0-rc1~490^2~1 X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f9aeccf1f0f420dd4869dcc7c3989893b37b81ff;p=dealii.git BDM Documentation Fixed sign of 2D BDM basis functions and added some documentation to BDM polynomial description. --- diff --git a/include/deal.II/base/polynomials_bdm.h b/include/deal.II/base/polynomials_bdm.h index f1ef7130f2..5845574543 100644 --- a/include/deal.II/base/polynomials_bdm.h +++ b/include/deal.II/base/polynomials_bdm.h @@ -46,6 +46,8 @@ DEAL_II_NAMESPACE_OPEN * (xk-iyzi+1,0,0) and * (0,xi+1yk-iz,0) * + * Note the curl of a scalar function is given by + * $\text{curl}(f(x,y)) = \begin{pmatrix} f_{y}(x,y) \\ -f_{x}(x,y) \end{pmatrix}$. * @todo Second derivatives in 3D are missing. * * @ingroup Polynomials diff --git a/include/deal.II/fe/fe_bdm.h b/include/deal.II/fe/fe_bdm.h index 0de57b4c26..f8001d8ede 100644 --- a/include/deal.II/fe/fe_bdm.h +++ b/include/deal.II/fe/fe_bdm.h @@ -39,7 +39,7 @@ DEAL_II_NAMESPACE_OPEN * @todo Restriction matrices are missing. * * The matching pressure space for FE_BDM of order k is the element - * FE_DGP of order k. + * FE_DGP of order k-1. * * The BDM element of order @p p has p+1 degrees of freedom on each * face. These are implemented as the function values in the p+1 Gauss diff --git a/source/base/polynomials_bdm.cc b/source/base/polynomials_bdm.cc index 17639ae404..1700b16dcb 100644 --- a/source/base/polynomials_bdm.cc +++ b/source/base/polynomials_bdm.cc @@ -117,8 +117,8 @@ PolynomialsBDM::compute (const Point &unit_point, { values[start][0] = monovali[0][0]; values[start][1] = -unit_point(1) * monovali[0][1]; - values[start+1][0] = -unit_point(0) * monovali[1][1]; - values[start+1][1] = monovali[1][0]; + values[start+1][0] = unit_point(0) * monovali[1][1]; + values[start+1][1] = -monovali[1][0]; } if (grads.size() != 0) {