From: Wolfgang Bangerth <bangerth@math.tamu.edu>
Date: Wed, 20 Aug 2014 18:54:05 +0000 (-0500)
Subject: Fix a warning about undefined behavior.
X-Git-Tag: v8.2.0-rc1~192^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F101%2Fhead;p=dealii.git

Fix a warning about undefined behavior.

I get an error of the form
  /u/bangerth/p/deal.II/1/dealii/include/deal.II/meshworker/dof_info.h:69:9: runtime error: load of value 216, which is not a valid value for type 'bool'
when running the testsuite with the ASAN framework. This is caused by the DoFInfo
class having a member variable that is left uninitialized in the constructor.
Fix this.
---

diff --git a/include/deal.II/meshworker/dof_info.h b/include/deal.II/meshworker/dof_info.h
index 7d0f7f62f8..e0323f7931 100644
--- a/include/deal.II/meshworker/dof_info.h
+++ b/include/deal.II/meshworker/dof_info.h
@@ -1,7 +1,7 @@
 // ---------------------------------------------------------------------
 // $Id$
 //
-// Copyright (C) 2006 - 2013 by the deal.II authors
+// Copyright (C) 2006 - 2014 by the deal.II authors
 //
 // This file is part of the deal.II library.
 //
@@ -31,6 +31,8 @@ DEAL_II_NAMESPACE_OPEN
 namespace MeshWorker
 {
   template <int dim, class DOFINFO> class DoFInfoBox;
+
+
   /**
    * A class containing information on geometry and degrees of freedom
    * of a mesh object.
@@ -84,8 +86,8 @@ namespace MeshWorker
      * if the info object was
      * initialized with a cell.
      */
-
     unsigned int face_number;
+    
     /**
      * The number of the current
      * subface on the current
@@ -177,6 +179,7 @@ namespace MeshWorker
      * active data.
      */
     bool level_cell;
+    
   private:
     /**
      * Standard constructor, not setting any block indices. Use of
@@ -187,6 +190,7 @@ namespace MeshWorker
 
     /// Set up local block indices
     void set_block_indices ();
+    
     /// Fill index vector with active indices
     template <class DHCellIterator>
     void get_indices(const DHCellIterator &c);
@@ -278,6 +282,7 @@ namespace MeshWorker
      * face is available.
      */
     bool interior_face_available[GeometryInfo<dim>::faces_per_cell];
+
     /**
      * A set of flags, indicating
      * whether data on an exterior
@@ -296,6 +301,8 @@ namespace MeshWorker
 
   template <int dim, int spacedim, typename number>
   DoFInfo<dim,spacedim,number>::DoFInfo(const DoFHandler<dim,spacedim> &dof_handler)
+  :
+  level_cell (false)
   {
     std::vector<types::global_dof_index> aux(1);
     aux[0] = dof_handler.get_fe().dofs_per_cell;
diff --git a/include/deal.II/meshworker/dof_info.templates.h b/include/deal.II/meshworker/dof_info.templates.h
index 91c25acbc5..606cb9b861 100644
--- a/include/deal.II/meshworker/dof_info.templates.h
+++ b/include/deal.II/meshworker/dof_info.templates.h
@@ -1,7 +1,7 @@
 // ---------------------------------------------------------------------
 // $Id$
 //
-// Copyright (C) 2009 - 2013 by the deal.II authors
+// Copyright (C) 2009 - 2014 by the deal.II authors
 //
 // This file is part of the deal.II library.
 //
@@ -24,7 +24,9 @@ namespace MeshWorker
 {
   template <int dim, int spacedim, typename number>
   DoFInfo<dim,spacedim,number>::DoFInfo(const BlockInfo &info)
-    : block_info(&info, typeid(*this).name())
+    :
+    block_info(&info, typeid(*this).name()),
+    level_cell (false)    
   {
     indices_by_block.resize(info.local().size());
     for (unsigned int i=0; i<indices_by_block.size(); ++i)