From: Martin Kronbichler Date: Tue, 19 Mar 2024 14:41:15 +0000 (+0100) Subject: Review comments X-Git-Tag: v9.6.0-rc1~473^2 X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F16749%2Fhead;p=dealii.git Review comments --- diff --git a/include/deal.II/lac/orthogonalization.h b/include/deal.II/lac/orthogonalization.h index 1466f7315d..d69ccb7f14 100644 --- a/include/deal.II/lac/orthogonalization.h +++ b/include/deal.II/lac/orthogonalization.h @@ -44,8 +44,8 @@ namespace LinearAlgebra * Use classical Gram-Schmidt algorithm with two orthogonalization * iterations and delayed orthogonalization using the algorithm described * in @cite Bielich2022. This approach works on multi-vectors with a - * single global reduction (of multiple elements) and more efficient than - * the modified Gram-Schmidt algorithm. At the same time, it + * single global reduction (of multiple elements) and is more efficient + * than the modified Gram-Schmidt algorithm. At the same time, it * unconditionally performs the second orthogonalization step, making it * more stable than the classical Gram-Schmidt variant. For deal.II's own * vectors, there is no additional cost compared to the classical diff --git a/include/deal.II/lac/solver_gmres.h b/include/deal.II/lac/solver_gmres.h index 66a2b49c80..667bb99a03 100644 --- a/include/deal.II/lac/solver_gmres.h +++ b/include/deal.II/lac/solver_gmres.h @@ -591,7 +591,7 @@ protected: /** * Estimates the eigenvalues from the Hessenberg matrix, H_orig, generated * during the inner iterations for @p n vectors in total. Uses these - * estimate to compute the condition number. Calls the signals + * estimates to compute the condition number. Calls the signals * eigenvalues_signal and cond_signal with these estimates as arguments. */ static void @@ -1645,7 +1645,7 @@ namespace internal // one where the orthogonalization has finished (i.e., end of inner // iteration in GMRES) and we can safely overwrite the content of the // tridiagonal matrix and right hand side, and the case during the inner - // iterations where need to create copies of the matrices in the QR + // iterations where we need to create copies of the matrices in the QR // decomposition as well as the right hand side. if (orthogonalization_strategy == LinearAlgebra::OrthogonalizationStrategy::