From: Wolfgang Bangerth <bangerth@math.tamu.edu>
Date: Wed, 23 Jul 2014 15:44:43 +0000 (-0500)
Subject: Add some description of when the last two IFs can happen in version
X-Git-Tag: v8.2.0-rc1~259^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F17%2Fhead;p=dealii.git

Add some description of when the last two IFs can happen in version
number recognition.
---

diff --git a/cmake/modules/FindP4EST.cmake b/cmake/modules/FindP4EST.cmake
index 44846c7930..ae6f5fd2f4 100644
--- a/cmake/modules/FindP4EST.cmake
+++ b/cmake/modules/FindP4EST.cmake
@@ -141,7 +141,12 @@ IF(EXISTS ${P4EST_INCLUDE_DIR}/p4est_config.h)
   #
   # We cannot rely on the fact that SUBMINOR or PATCH are defined.
   # Nevertheless, we need a full version number for our preprocessor macros
-  # to work. Therefore, set those numbers to 0 if necessary.
+  # to work. If the p4est version number is only of the form x.y instead of
+  # a.b.c.d, then the last two REGEX_REPLACE calls above will have failed
+  # because the regular expression didn't match the version string,
+  # and P4EST_VERSION_SUBMINOR and P4EST_VERSION_PATCH will either be
+  # empty or be the full version string. In those cases, set those numbers
+  # to 0 if necessary.
   #
   IF("${P4EST_VERSION_SUBMINOR}" MATCHES "^(|${P4EST_VERSION})$")
     SET(P4EST_VERSION_SUBMINOR "0")