From: Timo Heister <timo.heister@gmail.com>
Date: Tue, 17 Nov 2015 21:33:14 +0000 (-0500)
Subject: fix expand_instantiation split logic
X-Git-Tag: v8.4.0-rc2~218^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1880%2Fhead;p=dealii.git

fix expand_instantiation split logic

We optionally split instantiations in the generated .inst files based on
two macros SPLIT_INSTANTIATIONS_COUNT and SPLIT_INSTANTIATIONS_INDEX.
Intel 14 generates an error with an invalid % 0 in the old solution,
which happens if _COUNT is undefined. Fix this by defining a macro at
the beginning of the .inst file.
---

diff --git a/cmake/scripts/expand_instantiations.cc b/cmake/scripts/expand_instantiations.cc
index bb099183bf..2e224bb298 100644
--- a/cmake/scripts/expand_instantiations.cc
+++ b/cmake/scripts/expand_instantiations.cc
@@ -386,9 +386,9 @@ void substitute (const std::string &text,
           // between 0 and SPLIT_INSTANTIATIONS_COUNT-1 to get the instantiations of that
           // particular chunk.
           static unsigned int counter = 0;
-          std::cout << "#if !defined(SPLIT_INSTANTIATIONS_COUNT) || ("
+          std::cout << "#if (SPLIT_INSTANTIATIONS_CHECK("
                     << counter++
-                    << " % SPLIT_INSTANTIATIONS_COUNT == SPLIT_INSTANTIATIONS_INDEX)" << std::endl;
+                    << "))" << std::endl;
           std::cout << substitute_tokens (text, name, *expansion)
                     << std::endl;
           std::cout << "#endif" << std::endl;
@@ -506,5 +506,27 @@ int main (int argc, char **argv)
   for (int i=1; i<argc; ++i)
     read_expansion_lists (argv[i]);
 
+  // write header:
+  std::cout << "// This file is automatically generated from corresponding .inst.in, do not edit."
+            << std::endl << std::endl;
+
+  // Make sure SPLIT_INSTANTIATIONS_* is working correctly if the user doesn't
+  // use it. The defaults will not split the instantiations. This logic is
+  // somewhat tricky to get right for two reasons: 1. icc 14 will not allow an
+  // expressition like "#if !defined(B) || (A % B == C)" 2. we have .cc files
+  // where more than one .inst is included and splitting is only required in
+  // one of them. So we need to handle the case where _COUNT is undefined but
+  // _INDEX is defined, which might be needed later.
+  std::cout << "#ifdef SPLIT_INSTANTIATIONS_COUNT" << std::endl
+            << "  #define SPLIT_INSTANTIATIONS_CHECK(C) (((C) % SPLIT_INSTANTIATIONS_COUNT) == SPLIT_INSTANTIATIONS_INDEX)" << std::endl
+            << "#else" << std::endl
+            << "  #define SPLIT_INSTANTIATIONS_CHECK(C) (1)" << std::endl
+            << "#endif" << std::endl << std::endl;
+
   process_instantiations ();
+
+  // undefine the macro to avoid issues when more than one .inst file is
+  // included in a single .cc
+  std::cout << std::endl
+            << "#undef SPLIT_INSTANTIATIONS_CHECK" << std::endl;
 }