From: Daniel Arndt <daniel.arndt@iwr.uni-heidelberg.de>
Date: Wed, 22 Mar 2017 17:17:06 +0000 (+0100)
Subject: Refactor and fix IndexSet::is_ascending_ad_one_to_one
X-Git-Tag: v8.5.0-rc1~18^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F4094%2Fhead;p=dealii.git

Refactor and fix IndexSet::is_ascending_ad_one_to_one
---

diff --git a/source/base/index_set.cc b/source/base/index_set.cc
index 8066b9ec04..7e74c4964f 100644
--- a/source/base/index_set.cc
+++ b/source/base/index_set.cc
@@ -636,20 +636,23 @@ IndexSet::is_ascending_and_one_to_one (const MPI_Comm &communicator) const
   if (my_rank == 0)
     {
       // find out if the received std::vector is ascending
-      types::global_dof_index old_dof = global_dofs[0], new_dof = 0;
+      types::global_dof_index old_dof = global_dofs[0];
       types::global_dof_index index = 0;
       while (global_dofs[index] == numbers::invalid_dof_index)
         ++index;
       old_dof = global_dofs[index++];
       for (; index<global_dofs.size(); ++index)
         {
-          new_dof = global_dofs[index];
-          if (new_dof == numbers::invalid_dof_index)
-            new_dof = old_dof;
-          else if (new_dof<=old_dof)
+          const types::global_dof_index new_dof = global_dofs[index];
+          if (new_dof !=  numbers::invalid_dof_index)
             {
-              is_globally_ascending = false;
-              break;
+              if  (new_dof <= old_dof)
+                {
+                  is_globally_ascending = false;
+                  break;
+                }
+              else
+                old_dof = new_dof;
             }
         }
     }