From: Timo Heister Date: Wed, 25 Oct 2017 14:07:22 +0000 (-0400) Subject: Avoid numdiff check race condition in test X-Git-Tag: v9.0.0-rc1~882^2 X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F5323%2Fhead;p=dealii.git Avoid numdiff check race condition in test Do not remove the test files to avoid a race condition if cmake decides to rerun in a concurrent situation. Otherwise this would trigger the following error: "The detected numdiff executable was not able to pass a simple relative tolerance test." --- diff --git a/cmake/macros/macro_deal_ii_pickup_tests.cmake b/cmake/macros/macro_deal_ii_pickup_tests.cmake index 1ce3748519..3284f6dc21 100644 --- a/cmake/macros/macro_deal_ii_pickup_tests.cmake +++ b/cmake/macros/macro_deal_ii_pickup_tests.cmake @@ -164,11 +164,10 @@ MACRO(DEAL_II_PICKUP_TESTS) RESULT_VARIABLE _numdiff_tolerance_test_status ) - # - # Tidy up: - # - FILE(REMOVE ${_first_test_file_name}) - FILE(REMOVE ${_second_test_file_name}) + # Note: We do not remove the test files to avoid a race condition if + # cmake decides to rerun in a concurrent situation: + # FILE(REMOVE ${_first_test_file_name}) + # FILE(REMOVE ${_second_test_file_name}) IF(NOT "${_numdiff_tolerance_test_status}" STREQUAL "0") MESSAGE(FATAL_ERROR