From: Wolfgang Bangerth <bangerth@colostate.edu>
Date: Tue, 13 Feb 2018 21:57:31 +0000 (-0700)
Subject: Explicitly list signed/unsigned char.
X-Git-Tag: v9.0.0-rc1~434^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F5895%2Fhead;p=dealii.git

Explicitly list signed/unsigned char.

Platforms may choose whether they want 'char' to be 'signed'
or 'unsigned', so differentiating between 'unsigned char' and 'char'
is not useful. We need to differentiate between 'unsigned char' and
'signed char'.
---

diff --git a/include/deal.II/base/patterns.h b/include/deal.II/base/patterns.h
index 03d1d1a357..f8fea8f4fe 100644
--- a/include/deal.II/base/patterns.h
+++ b/include/deal.II/base/patterns.h
@@ -1390,7 +1390,7 @@ namespace Patterns
                                    &p = Convert<T>::to_pattern())
       {
         std::string str;
-        if (std::is_same<T, unsigned char>() || std::is_same<T, char>())
+        if (std::is_same<T, unsigned char>() || std::is_same<T, signed char>())
           str = std::to_string((int)value);
         else  if (std::is_same<T,bool>::value)
           str = value ? "true" : "false";
@@ -1411,7 +1411,7 @@ namespace Patterns
         else
           {
             std::istringstream is(s);
-            if (std::is_same<T, unsigned char>::value || std::is_same<T, char>::value)
+            if (std::is_same<T, unsigned char>::value || std::is_same<T, signed char>::value)
               {
                 int i;
                 is >> i;