From: David Wells Date: Tue, 14 May 2019 14:23:24 +0000 (-0400) Subject: Unify the log entry for Subscriptor. X-Git-Tag: v9.1.0-rc2~16^2 X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F8169%2Fhead;p=dealii.git Unify the log entry for Subscriptor. The remark about rvalue references is no longer correct since we switched, after the ban on rvalue references, to storing a std::string (which permits rvalues once more). --- diff --git a/doc/news/9.0.1-vs-9.1.0.h b/doc/news/9.0.1-vs-9.1.0.h index 9d4eb85ee8..48e417fde7 100644 --- a/doc/news/9.0.1-vs-9.1.0.h +++ b/doc/news/9.0.1-vs-9.1.0.h @@ -89,17 +89,6 @@ inconvenience this causes. (David Wells, 2018/11/30) -
  • - Changed: Subscriptor::subscribe cannot be called with rvalue references anymore. - In particular, temporary string literals cannot be used as argument. Storing - string literals with the same content at the same memory location is - implementation defined and cannot be relied upon. On the other hand, the - subscriber strings are not compared by their memory address anymore but by their - actual content. -
    - (Daniel Arndt, 2018/11/12) -
  • -
  • Changed: The constructor for Subscriptor requires providing a pointer to a boolean that can be used to signal validity of the object pointed to by the subscribing @@ -684,8 +673,10 @@ inconvenience this causes.
  • - Changed: SmartPointer and Subscriptor use a std::string - instead of a const char * as identifier. + Changed: SmartPointer and Subscriptor use a `std::string` + instead of a `const char *` for subscriber identification. As a result, + subscriber strings are no longer compared by their memory address but instead + by their content.
    (Daniel Arndt, 2019/04/08)