From: Wolfgang Bangerth <bangerth@colostate.edu>
Date: Tue, 10 Sep 2019 21:06:05 +0000 (-0600)
Subject: Move the call to update_number_cache() after all other calls.
X-Git-Tag: v9.2.0-rc1~1121^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F8732%2Fhead;p=dealii.git

Move the call to update_number_cache() after all other calls.

Conceptually, this function (as its name suggests) just updates a cache. We should
call it after all other functions that change things in the triangulation have
been called, even if the order does not matter in a particular context. This just
makes reading the code simpler.
---

diff --git a/source/distributed/tria.cc b/source/distributed/tria.cc
index b12a32101b..aef7015732 100644
--- a/source/distributed/tria.cc
+++ b/source/distributed/tria.cc
@@ -2209,8 +2209,8 @@ namespace parallel
           Assert(false, ExcInternalError());
         }
 
-      this->update_number_cache();
       this->update_periodic_face_map();
+      this->update_number_cache();
     }
 
 
@@ -2853,12 +2853,11 @@ namespace parallel
             }
         }
 
+      this->update_periodic_face_map();
       this->update_number_cache();
 
       // signal that de-serialization is finished
       this->signals.post_distributed_load();
-
-      this->update_periodic_face_map();
     }
 
 
@@ -4056,9 +4055,8 @@ namespace parallel
         }
 #  endif
 
-      this->update_number_cache();
-
       this->update_periodic_face_map();
+      this->update_number_cache();
 
       // signal that refinement is finished
       this->signals.post_distributed_refinement();
@@ -4158,11 +4156,11 @@ namespace parallel
                                          previous_global_first_quadrant.data());
         }
 
+      this->update_periodic_face_map();
+
       // update how many cells, edges, etc, we store locally
       this->update_number_cache();
 
-      this->update_periodic_face_map();
-
       // signal that repartitioning is finished
       this->signals.post_distributed_repartition();
     }
@@ -4843,8 +4841,8 @@ namespace parallel
           Assert(false, ExcInternalError());
         }
 
-      this->update_number_cache();
       this->update_periodic_face_map();
+      this->update_number_cache();
     }