From: Wolfgang Bangerth <bangerth@math.tamu.edu>
Date: Thu, 7 May 2015 22:57:04 +0000 (-0500)
Subject: Extend the error message for ExcIndexRange.
X-Git-Tag: v8.3.0-rc1~188^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F914%2Fhead;p=dealii.git

Extend the error message for ExcIndexRange.

I must have had half a dozen students this semester who were unable to
decipher what this error message really means:

An error occurred in line <1183> of file
<../include/deal.II/lac/vector.h> in function
    Number &dealii::Vector<double>::operator()(const size_type) [number
= double]
The violated condition was:
    i<vec_size
The name and call sequence of the exception was:
    ExcIndexRangeType<size_type>(i,0,vec_size)
Additional Information:
Index 0 is not in [0,0[


This commit simply provides them with some more information.
---

diff --git a/include/deal.II/base/exceptions.h b/include/deal.II/base/exceptions.h
index 2719661d64..4989bfc938 100644
--- a/include/deal.II/base/exceptions.h
+++ b/include/deal.II/base/exceptions.h
@@ -887,17 +887,42 @@ namespace StandardExceptions
   DeclException3 (ExcIndexRange,
                   int, int, int,
                   << "Index " << arg1 << " is not in the half-open range [" << arg2 << ","
-                  << arg3 << "[.");
+                  << arg3 << ")."
+                  << (arg2==arg3 ?
+                      " In the current case, this half-open range is in fact empty, "
+                      "suggesting that you are accessing an element of an empty "
+                      "collection such as a vector that has not been set to the "
+                      "correct size."
+                      :
+                      ""));
 
   /**
-   * This generic exception will allow(enforce) the user to specify the type
-   * of indices which adds type safety to the program.
+   * This exception indicates that an index is not within the
+   * expected range. For example, it may be that you are trying to
+   * access an element of a vector which does not exist.
+   *
+   * The constructor takes three <tt>int</tt> arguments, namely
+   * <ol>
+   * <li> the violating index
+   * <li> the lower bound
+   * <li> the upper bound plus one
+   * </ol>
+   *
+   * This generic exception differs from ExcIndexRange by allowing to specify
+   * the type of indices.
    */
   template <typename T>
   DeclException3 (ExcIndexRangeType,
                   T,T,T,
                   << "Index " << arg1 << " is not in the half-open range [" << arg2 << ","
-                  << arg3 << "[.");
+                  << arg3 << ")."
+                  << (arg2==arg3 ?
+                      " In the current case, this half-open range is in fact empty, "
+                      "suggesting that you are accessing an element of an empty "
+                      "collection such as a vector that has not been set to the "
+                      "correct size."
+                      :
+                      ""));
 
   /**
    * A number is too small.
@@ -905,7 +930,7 @@ namespace StandardExceptions
   DeclException2 (ExcLowerRange,
                   int, int,
                   << "Number " << arg1 << " must be larger than or equal "
-                  << arg2 << ".");
+                  << arg2 << ").");
 
   /**
    * A generic exception definition for the ExcLowerRange above.