Move a bunch of internal functions into anonymous namespaces.
Like the MappingQ1 class, MappingFEField had a bunch of internal functions
that might as well live inside the .cc file only in an anonymous namespace.
Do so.
Move a bunch of internal functions into anonymous namespaces.
The MappingQ1 class had a bunch of internal functions that were part of the class
declaration but are in fact only ever used internally and do not need a whole
lot of information from the class itself. Move these functions into an anonymous
namespace in the .cc file so as to keep the external interface of the class
as small as possible.
Make the Mapping and FE output objects members of FEValues.
Historically, the fields in the internal::FEValues::MappingRelatedData and
internal::FEValues::FiniteElementRelatedData classes were part of the (now
removed) base class FEValuesData. These two classes neatly split the fields of
this base class into separate categories, but they continued to enter the
FEValuesBase class via protected inheritance. This is not only slightly awkward,
but also not the easiest approach to understand if you start looking at stuff.
This patch is in essence incredibly boring: instead of having two protected
base classes, it introduces two protected member variables. The remainder
of the patch is then simply an exercise in making sure every use of the
henceforth member variables now accessese the members of the two new
class-type member variables. The only interesting aspect (and that's where
everything becomes much clearer with this design) is that when we call
Mapping::fill_fe_values() or the same function in FiniteElement, we no
longer need to implicitly cast down '*this' to the base class reference,
but can instead just use the new member variable.
Other than that the only noteworthy part of the patch is the introduction
of memory_consumption() functions for the two classes previously split out
from FEValuesData.
This commit removes the first_vector_components parameter from
GridTools::collect_periodic_faces(), as well as, the
first_vector_components data field from the struct
GridTools::PeriodicFacePair. The parameter is no added to all varianst of
DoFTools::make_periodicity_constraints instead.
This is an incompatible change made for consistency: A PeriodicFacePair
should not store first_vector_components and with that information about
the underlying finite element space.
Bug fix in GridIn::read_abaqus(): Stride size is sometimes not
explicitly defined for ELSETS. Choose a default value if this is the
case. Fixes issue #1409
As discussed in #496, normal vectors are currently returned by FEValues
as Point<spacedim> objects, but since they are differential vectors, the
correct data type should be Tensor<1,dim>. This patch implements the solution
discussed in #496 by
* changing the return type of FEValues::normal_vector()
* deprecating FEValues::get_normal_vectors()
* introducing FEValues::get_all_normal_vectors() that returns a vector
of tensors.
The old get_normal_vectors() function was deprecated. In order to
make it work, I also had to change the return type from a reference
to a straight array. This array may be bound to a reference in
many places in user codes, but the style we have used everywhere
is to make these reference variables very localized in scope and
so I don't foresee any problems.
David Wells [Thu, 13 Aug 2015 03:05:30 +0000 (23:05 -0400)]
Remove apple gcc-3.3 compatability.
The last release of the 3.3 branch was in 2005, and this bug was fixed
in gcc4.0 (released in 2007).
A historical note: the mentioned bug was reported by deal.II developers
in 2005. See
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=24331
for further discussion (from Kayser-Herold and Bangerth).
In particular, document the restriction_is_additive flags for which
there was basically nothing there so far. Also provide better documentation
about the constructor arguments.
We only need the #include if we actually use the functions the file
provides. Disable it otherwise to ensure that the tests continue to
run on platforms that don't provide <cfenv>.
The mesh_converter program is now considered obsolete and has been
removed from the contrib folder.
Direct support for Abaqus mesh files has been added to the GridIn
class through the function GridIn::read_abaqus(). An internal class
Abaqus_to_UCD captures all of the functionality of the original
mesh_converter program and feeds its output directly to the
already implemented GridIn::read_ucd() function. This is suboptimal
but works sufficiently well to act as an interim solution until the
internal renumbering scheme necessary to convert the Abaqus format
directly to deal.II's internal number can be determined.
On top of the already existing functionality to read in Abaqus meshes
created using Cubit, patches provided by Krzysztof Bzowski that allow
for the input of mesh files exported directly from Abaqus have also
been included.
Test cases have been added to the testsuite, with the original
mesh files from the mesh_converter program used for this purpose.
projects / dealii.git / log