]> https://gitweb.dealii.org/ - dealii.git/log
dealii.git
6 years agoPrefer v.get() to &v[0] with smart pointers.
David Wells [Sun, 8 Oct 2017 19:16:15 +0000 (15:16 -0400)]
Prefer v.get() to &v[0] with smart pointers.

6 years agoGet rid of some intermediate variables.
David Wells [Sun, 8 Oct 2017 18:58:15 +0000 (14:58 -0400)]
Get rid of some intermediate variables.

6 years agoRealign some function arguments.
David Wells [Sat, 7 Oct 2017 00:43:27 +0000 (20:43 -0400)]
Realign some function arguments.

6 years agoDirectly use raw pointers instead of &v[0].
David Wells [Sat, 7 Oct 2017 00:43:13 +0000 (20:43 -0400)]
Directly use raw pointers instead of &v[0].

6 years agoPrefer v.data() to &v[0].
David Wells [Sat, 7 Oct 2017 00:42:55 +0000 (20:42 -0400)]
Prefer v.data() to &v[0].

6 years agoMerge pull request #5232 from davydden/user_project_source_dir
Timo Heister [Thu, 12 Oct 2017 17:23:52 +0000 (13:23 -0400)]
Merge pull request #5232 from davydden/user_project_source_dir

doc: explain how to use SOURCE_DIR from user tests

6 years agodoc: explain how to use SOURCE_DIR from user tests 5232/head
Denis Davydov [Thu, 12 Oct 2017 12:58:15 +0000 (14:58 +0200)]
doc: explain how to use SOURCE_DIR from user tests

6 years agoMerge pull request #5131 from davydden/metis_yet_again
Wolfgang Bangerth [Thu, 12 Oct 2017 14:43:39 +0000 (08:43 -0600)]
Merge pull request #5131 from davydden/metis_yet_again

add yet another pair of outputs for Metis on macOS with Clang 9.0.0

6 years agoMerge pull request #5228 from tjhei/msvc_enable_w4661
David Wells [Wed, 11 Oct 2017 22:05:13 +0000 (18:05 -0400)]
Merge pull request #5228 from tjhei/msvc_enable_w4661

enable MSVC warning w4661

6 years agoMerge pull request #5231 from masterleinad/intel-warnings
Daniel Arndt [Wed, 11 Oct 2017 21:44:42 +0000 (23:44 +0200)]
Merge pull request #5231 from masterleinad/intel-warnings

Remove unused constructors in unnamed namespace

6 years agoMerge pull request #5229 from masterleinad/intel-warnings_3
Timo Heister [Wed, 11 Oct 2017 21:39:27 +0000 (17:39 -0400)]
Merge pull request #5229 from masterleinad/intel-warnings_3

Disable spuriuos intel warning

6 years agoBe more descriptive for the disabled remarks 5229/head
Daniel Arndt [Wed, 11 Oct 2017 20:29:01 +0000 (22:29 +0200)]
Be more descriptive for the disabled remarks

6 years agoMerge pull request #5230 from masterleinad/intel-warnings_2
Wolfgang Bangerth [Wed, 11 Oct 2017 19:52:43 +0000 (13:52 -0600)]
Merge pull request #5230 from masterleinad/intel-warnings_2

Remove meaningless type qualifier in pointer cast

6 years agoRemove meaningless type qualifier in pointer cast 5230/head
Daniel Arndt [Wed, 11 Oct 2017 18:45:11 +0000 (20:45 +0200)]
Remove meaningless type qualifier in pointer cast

6 years agoDisable spuriuos intel warning
Daniel Arndt [Wed, 11 Oct 2017 18:52:24 +0000 (20:52 +0200)]
Disable spuriuos intel warning

6 years agoRemove unused constructors in unnamed namespace 5231/head
Daniel Arndt [Wed, 11 Oct 2017 18:43:51 +0000 (20:43 +0200)]
Remove unused constructors in unnamed namespace

6 years agoenable MSVC warning w4661 5228/head
Timo Heister [Wed, 11 Oct 2017 17:29:54 +0000 (13:29 -0400)]
enable MSVC warning w4661

As discovered in #5225, these warnings are useful.

6 years agoMerge pull request #5226 from kronbichler/relax_shape_info_test
Wolfgang Bangerth [Wed, 11 Oct 2017 15:02:21 +0000 (09:02 -0600)]
Merge pull request #5226 from kronbichler/relax_shape_info_test

Relax polynomial degree in ShapeInfo test

6 years agoRelax polynomial degree in ShapeInfo test. 5226/head
Martin Kronbichler [Wed, 11 Oct 2017 09:08:39 +0000 (11:08 +0200)]
Relax polynomial degree in ShapeInfo test.

6 years agoMerge pull request #5223 from bangerth/typo
David Wells [Wed, 11 Oct 2017 01:24:22 +0000 (21:24 -0400)]
Merge pull request #5223 from bangerth/typo

Fix a typo.

6 years agoMerge pull request #5224 from bangerth/doc
David Wells [Wed, 11 Oct 2017 01:23:59 +0000 (21:23 -0400)]
Merge pull request #5224 from bangerth/doc

Update documentation of LogStream::push().

6 years agoUpdate documentation of LogStream::push(). 5224/head
Wolfgang Bangerth [Tue, 10 Oct 2017 23:01:51 +0000 (17:01 -0600)]
Update documentation of LogStream::push().

6 years agoFix a typo. 5223/head
Wolfgang Bangerth [Tue, 10 Oct 2017 22:58:53 +0000 (16:58 -0600)]
Fix a typo.

6 years agoMerge pull request #5114 from tcclevenger/sharedtria_mg_dofs
Wolfgang Bangerth [Tue, 10 Oct 2017 22:56:55 +0000 (16:56 -0600)]
Merge pull request #5114 from tcclevenger/sharedtria_mg_dofs

Add distribute_mg_dof functionality for a parallel::shared::Triangulation

6 years agoMerge pull request #5222 from drwells/deprecate-boundary-classes
Wolfgang Bangerth [Tue, 10 Oct 2017 18:55:07 +0000 (12:55 -0600)]
Merge pull request #5222 from drwells/deprecate-boundary-classes

Formally deprecate the Boundary classes.

6 years agoadd distribute_mg_dofs for shared::Triangulation 5114/head
tcclevenger [Tue, 19 Sep 2017 23:19:14 +0000 (19:19 -0400)]
add distribute_mg_dofs for shared::Triangulation

6 years agoFormally deprecate the Boundary classes. 5222/head
David Wells [Tue, 10 Oct 2017 17:46:59 +0000 (13:46 -0400)]
Formally deprecate the Boundary classes.

6 years agoMerge pull request #5220 from masterleinad/fix_intel_tests_1
Wolfgang Bangerth [Tue, 10 Oct 2017 15:11:34 +0000 (09:11 -0600)]
Merge pull request #5220 from masterleinad/fix_intel_tests_1

Fix tests by increasing the precision

6 years agoMerge pull request #5221 from masterleinad/fix_intel_tests_2
Wolfgang Bangerth [Tue, 10 Oct 2017 15:10:43 +0000 (09:10 -0600)]
Merge pull request #5221 from masterleinad/fix_intel_tests_2

Use std::initializer_list instead of variadic constructor in tests

6 years agoFix tests by increasing precision 5220/head
Daniel Arndt [Tue, 10 Oct 2017 14:49:36 +0000 (16:49 +0200)]
Fix tests by increasing precision

6 years agoUse std::initializer_list instead of variadic constructor in tests 5221/head
Daniel Arndt [Tue, 10 Oct 2017 14:54:17 +0000 (16:54 +0200)]
Use std::initializer_list instead of variadic constructor in tests

6 years agoMerge pull request #5212 from kronbichler/feeval_vector_access_assert
Martin Kronbichler [Tue, 10 Oct 2017 07:42:59 +0000 (09:42 +0200)]
Merge pull request #5212 from kronbichler/feeval_vector_access_assert

Add assertion regarding vector access in FEEvaluation.

6 years agoMerge pull request #5201 from bangerth/logstream
Daniel Arndt [Tue, 10 Oct 2017 00:32:33 +0000 (02:32 +0200)]
Merge pull request #5201 from bangerth/logstream

Replace logstream.push/pop by Logstream::Prefix.

6 years agoMerge pull request #4798 from drwells/remove-boundary-usage
Wolfgang Bangerth [Tue, 10 Oct 2017 00:23:43 +0000 (18:23 -0600)]
Merge pull request #4798 from drwells/remove-boundary-usage

Remove boundary usage

6 years agoMerge pull request #5203 from tjhei/simplify_test_intergrid_constraints
Wolfgang Bangerth [Mon, 9 Oct 2017 23:32:05 +0000 (17:32 -0600)]
Merge pull request #5203 from tjhei/simplify_test_intergrid_constraints

simplify tests/grid/intergrid_constraints

6 years agoMerge pull request #5213 from masterleinad/intel18_4
David Wells [Mon, 9 Oct 2017 21:33:42 +0000 (17:33 -0400)]
Merge pull request #5213 from masterleinad/intel18_4

Move default pure virtual destructor of Function

6 years agoMerge pull request #5214 from masterleinad/intel18_3
Daniel Arndt [Mon, 9 Oct 2017 16:58:53 +0000 (18:58 +0200)]
Merge pull request #5214 from masterleinad/intel18_3

Add missing (unused) return value in Convert::to_pattern

6 years agoMerge pull request #5216 from masterleinad/intel18_1
Daniel Arndt [Mon, 9 Oct 2017 16:49:41 +0000 (18:49 +0200)]
Merge pull request #5216 from masterleinad/intel18_1

Pass a function pointer by adress instead of by value

6 years agoAdd missing (unused) return value in Convert::to_pattern 5214/head
Daniel Arndt [Mon, 9 Oct 2017 12:51:30 +0000 (14:51 +0200)]
Add missing (unused) return value in Convert::to_pattern

6 years agoMerge pull request #5215 from masterleinad/intel18_2
Wolfgang Bangerth [Mon, 9 Oct 2017 14:38:45 +0000 (08:38 -0600)]
Merge pull request #5215 from masterleinad/intel18_2

Rename loop variable to differ from enclosing one

6 years agoMerge pull request #5211 from davydden/lapack_trace
Wolfgang Bangerth [Mon, 9 Oct 2017 14:32:00 +0000 (08:32 -0600)]
Merge pull request #5211 from davydden/lapack_trace

add LAPACKFullMatrix::trace()

6 years agoMerge pull request #5209 from davydden/oversubscribe_quick_tests
Timo Heister [Mon, 9 Oct 2017 13:53:20 +0000 (09:53 -0400)]
Merge pull request #5209 from davydden/oversubscribe_quick_tests

explicitly oversubscribe with MPI for quick tests

6 years agoPass a function pointer by adress instead of by value 5216/head
Daniel Arndt [Mon, 9 Oct 2017 12:55:16 +0000 (14:55 +0200)]
Pass a function pointer by adress instead of by value

6 years agoRename loop variable to differ from enclosing one 5215/head
Daniel Arndt [Mon, 9 Oct 2017 12:52:26 +0000 (14:52 +0200)]
Rename loop variable to differ from enclosing one

6 years agoMove default pure virtual destructor of Function 5213/head
Daniel Arndt [Mon, 9 Oct 2017 12:49:13 +0000 (14:49 +0200)]
Move default pure virtual destructor of Function

6 years agoAlso assert in read_dof_values_plain. 5212/head
Martin Kronbichler [Mon, 9 Oct 2017 10:40:20 +0000 (12:40 +0200)]
Also assert in read_dof_values_plain.

6 years agoAdd assertion regarding vector access in FEEvaluation.
Martin Kronbichler [Mon, 9 Oct 2017 09:53:47 +0000 (11:53 +0200)]
Add assertion regarding vector access in FEEvaluation.

6 years agoadd LAPACKFullMatrix::trace() 5211/head
Denis Davydov [Mon, 9 Oct 2017 09:06:34 +0000 (11:06 +0200)]
add LAPACKFullMatrix::trace()

6 years agoMerge pull request #5210 from masterleinad/remove_petsc_options
Wolfgang Bangerth [Mon, 9 Oct 2017 02:24:39 +0000 (20:24 -0600)]
Merge pull request #5210 from masterleinad/remove_petsc_options

Remove unused PETSc options

6 years agoFix an include guard name. 4798/head
David Wells [Sun, 24 Sep 2017 04:01:12 +0000 (00:01 -0400)]
Fix an include guard name.

6 years agoAllow for slightly different numbers in a Manifold test.
David Wells [Mon, 4 Sep 2017 01:42:31 +0000 (21:42 -0400)]
Allow for slightly different numbers in a Manifold test.

This is due to a previous commit where GridGenerator::hyper_ball was redone to
use SphericalManifold instead of HyperBallBoundary.

6 years agoSpecify different projected points in a test.
David Wells [Mon, 4 Sep 2017 00:09:25 +0000 (20:09 -0400)]
Specify different projected points in a test.

In these two cases multiple minima exist: the new algorithm picks points on the
edges.

6 years agoForce projected points to be on the objects.
David Wells [Sun, 3 Sep 2017 23:00:49 +0000 (19:00 -0400)]
Force projected points to be on the objects.

6 years agoAdd changelog entries.
David Wells [Sat, 12 Aug 2017 22:29:39 +0000 (18:29 -0400)]
Add changelog entries.

6 years agoUpdate a Triangulation::straight_boundary test.
David Wells [Sat, 12 Aug 2017 22:23:03 +0000 (18:23 -0400)]
Update a Triangulation::straight_boundary test.

This member value will soon be deprecated and Triangulation returns a
FlatManifold reference in the relevant function now.

6 years agoUpdate some comments referring to Boundary.
David Wells [Sat, 12 Aug 2017 17:29:04 +0000 (13:29 -0400)]
Update some comments referring to Boundary.

6 years agoTest project_to_surface without boundary objects.
David Wells [Sat, 12 Aug 2017 15:50:37 +0000 (11:50 -0400)]
Test project_to_surface without boundary objects.

Since GridTools::project_to_object now calls our implementation of
project_to_surface directly we can fix up these tests to just call the relevant
function.

6 years agoRemove tests for overridden project_to_surface.
David Wells [Sat, 12 Aug 2017 15:46:36 +0000 (11:46 -0400)]
Remove tests for overridden project_to_surface.

Since a previous commit removed the call inside
GridTools::fix_up_distorted_child_cells to Boundary::project_to_surface,
testing overriden implementations of this function no longer makes
sense.

6 years agoFix a wrong comment.
David Wells [Thu, 10 Aug 2017 18:10:35 +0000 (14:10 -0400)]
Fix a wrong comment.

we can still do things if we are on the boundary.

6 years agoOverhaul GridTools::internal::fix_up_object.
David Wells [Sat, 12 Aug 2017 00:13:32 +0000 (20:13 -0400)]
Overhaul GridTools::internal::fix_up_object.

The primary issue with excising Boundary from the library is the lack of
an equivalent project_to_surface function in the Manifold code (since
Manifolds don't know anything about faces or lines, just points and
geodesics). Fortunately, this function is only called in one place, and
the default implementation in StraightManifold is the only
implementation in the library: hence, we get around this issue by
copying and pasting StraightManifold::project_to_surface into the new
internal project_to_object function and marking this change as
incompatible.

To the best of the author's knowledge, no users have implemented their
own custom project_to_surface nor are they using the one function that
calls this (GridTools::fix_up_distorted_child_cells) so this small
incompatibility is acceptable.

6 years agoAdd a clarifying assertion.
David Wells [Sat, 12 Aug 2017 00:07:52 +0000 (20:07 -0400)]
Add a clarifying assertion.

6 years agoUse Manifold, not boundary, functionality.
Luca Heltai [Wed, 23 Mar 2016 15:26:07 +0000 (16:26 +0100)]
Use Manifold, not boundary, functionality.

6 years agoMerge pull request #5199 from drwells/extra-assimp-hint
Daniel Arndt [Sun, 8 Oct 2017 20:45:19 +0000 (22:45 +0200)]
Merge pull request #5199 from drwells/extra-assimp-hint

Add an extra hint for assimp.

6 years agoRemove unused PETSc options 5210/head
Daniel Arndt [Sun, 8 Oct 2017 20:26:42 +0000 (22:26 +0200)]
Remove unused PETSc options

6 years agoMerge pull request #5204 from davydden/mg_interface_size_type
David Wells [Sun, 8 Oct 2017 17:38:53 +0000 (13:38 -0400)]
Merge pull request #5204 from davydden/mg_interface_size_type

add size_type to MGInterfaceOperator

6 years agoMerge pull request #5206 from bangerth/simplify
Daniel Arndt [Sun, 8 Oct 2017 10:39:10 +0000 (12:39 +0200)]
Merge pull request #5206 from bangerth/simplify

Use std::unique_ptr instead of std::shared_ptr.

6 years agoexplicitly oversubscribe with MPI for quick tests 5209/head
Denis Davydov [Sat, 7 Oct 2017 19:10:58 +0000 (21:10 +0200)]
explicitly oversubscribe with MPI for quick tests

6 years agoUse std::unique_ptr instead of std::shared_ptr. 5206/head
Wolfgang Bangerth [Sat, 7 Oct 2017 03:33:31 +0000 (21:33 -0600)]
Use std::unique_ptr instead of std::shared_ptr.

6 years agoMerge pull request #5160 from danshapero/bbox
Wolfgang Bangerth [Sat, 7 Oct 2017 03:30:34 +0000 (21:30 -0600)]
Merge pull request #5160 from danshapero/bbox

bounding box for triangulation and cell iterators [WIP]

6 years agoAdded functions to compute bounding box for triangulation, accessors 5160/head
danshapero [Tue, 26 Sep 2017 21:49:06 +0000 (14:49 -0700)]
Added functions to compute bounding box for triangulation, accessors

6 years agoadd size_type to MGInterfaceOperator 5204/head
Denis Davydov [Fri, 6 Oct 2017 16:55:45 +0000 (18:55 +0200)]
add size_type to MGInterfaceOperator

This might be needed when one uses a single wrapper class
to define level block operators based on non-block versions.

6 years agoMerge pull request #5189 from bangerth/aligned-vector
Martin Kronbichler [Fri, 6 Oct 2017 15:35:59 +0000 (17:35 +0200)]
Merge pull request #5189 from bangerth/aligned-vector

Allow using objects in Table and AlignedVector that are not copyable.

6 years agoSimplify code. 5189/head
Wolfgang Bangerth [Fri, 6 Oct 2017 13:56:04 +0000 (07:56 -0600)]
Simplify code.

6 years agosimplify tests/grid/intergrid_constraints 5203/head
Timo Heister [Fri, 6 Oct 2017 13:00:16 +0000 (09:00 -0400)]
simplify tests/grid/intergrid_constraints

reduce 500k+ bytes of output to something that doesn't cause the tester
to timeout

6 years agoMerge pull request #5196 from asartori86/fix_sundials
Luca Heltai [Fri, 6 Oct 2017 12:59:25 +0000 (14:59 +0200)]
Merge pull request #5196 from asartori86/fix_sundials

fix sundials interface for NON-MPI installations

6 years agoMerge pull request #5202 from tcclevenger/mesh_loop
Daniel Arndt [Fri, 6 Oct 2017 08:26:34 +0000 (10:26 +0200)]
Merge pull request #5202 from tcclevenger/mesh_loop

Removing an unused variable in mesh_loop.h

6 years agoMerge pull request #5200 from drwells/constraintmatrix-improvements
Martin Kronbichler [Fri, 6 Oct 2017 07:17:29 +0000 (09:17 +0200)]
Merge pull request #5200 from drwells/constraintmatrix-improvements

ConstraintMatrix improvements

6 years agoAdd an extra hint for assimp. 5199/head
David Wells [Thu, 5 Oct 2017 19:54:30 +0000 (15:54 -0400)]
Add an extra hint for assimp.

If assimp has its own directory, e.g., ASSIMP_DIR=/opt/assimp/, then
this hint is needed.

6 years agoAdd a finite-ness assertion. 5200/head
David Wells [Thu, 5 Oct 2017 20:32:48 +0000 (16:32 -0400)]
Add a finite-ness assertion.

6 years agoRealign some arguments.
David Wells [Thu, 5 Oct 2017 20:32:30 +0000 (16:32 -0400)]
Realign some arguments.

6 years agoPrefer VectorType to VEC.
David Wells [Thu, 5 Oct 2017 20:32:09 +0000 (16:32 -0400)]
Prefer VectorType to VEC.

6 years agoUpdate some comments for ConstraintMatrixData.
David Wells [Thu, 5 Oct 2017 20:26:00 +0000 (16:26 -0400)]
Update some comments for ConstraintMatrixData.

We no longer use shared pointers here.

6 years agoAdjust tests.
Wolfgang Bangerth [Fri, 6 Oct 2017 03:44:59 +0000 (21:44 -0600)]
Adjust tests.

6 years agoremove unused variable 5202/head
tcclevenger [Fri, 6 Oct 2017 01:36:11 +0000 (21:36 -0400)]
remove unused variable

6 years agoMerge pull request #5169 from tamiko/generalized_interpolation_3
Matthias Maier [Fri, 6 Oct 2017 01:14:05 +0000 (20:14 -0500)]
Merge pull request #5169 from tamiko/generalized_interpolation_3

Reimplement VectorTools::interpolate_based_on_material_id

6 years agoAlso avoid using deallog.push/pop in other places. 5201/head
Wolfgang Bangerth [Thu, 5 Oct 2017 23:41:56 +0000 (17:41 -0600)]
Also avoid using deallog.push/pop in other places.

6 years agoReplace logstream.push/pop by Logstream::Prefix.
Wolfgang Bangerth [Thu, 5 Oct 2017 22:57:41 +0000 (16:57 -0600)]
Replace logstream.push/pop by Logstream::Prefix.

6 years agosimplify code 5169/head
Matthias Maier [Thu, 5 Oct 2017 19:54:37 +0000 (14:54 -0500)]
simplify code

6 years agoMerge pull request #5167 from luca-heltai/kinsol
Wolfgang Bangerth [Thu, 5 Oct 2017 20:34:31 +0000 (14:34 -0600)]
Merge pull request #5167 from luca-heltai/kinsol

KINSOL support.

6 years agoReimplement VectorTools::interpolate_based_on_material_id
Matthias Maier [Wed, 27 Sep 2017 21:00:01 +0000 (16:00 -0500)]
Reimplement VectorTools::interpolate_based_on_material_id

6 years agoMerge pull request #5198 from bangerth/update
Matthias Maier [Thu, 5 Oct 2017 19:35:42 +0000 (14:35 -0500)]
Merge pull request #5198 from bangerth/update

Update to VectorTools::interpolate

6 years agoEntirely avoid memory allocation in two places. 5198/head
Wolfgang Bangerth [Thu, 5 Oct 2017 19:17:11 +0000 (13:17 -0600)]
Entirely avoid memory allocation in two places.

6 years agoUse only one FEValues object.
Wolfgang Bangerth [Wed, 4 Oct 2017 14:41:32 +0000 (08:41 -0600)]
Use only one FEValues object.
>
> Currently, there is one FEValues object that is reinit'd in the innermost
> function, but that function may be called multiple times for the same
> cell for different base elements. That is wasteful, so avoid it.
>
The solution is to reinit it at the outermost place.

6 years agoAvoid passing around ints by reference.
Wolfgang Bangerth [Tue, 3 Oct 2017 21:42:02 +0000 (15:42 -0600)]
Avoid passing around ints by reference.

6 years agoMinor optimization of some memory allocation.
Wolfgang Bangerth [Tue, 3 Oct 2017 21:39:39 +0000 (15:39 -0600)]
Minor optimization of some memory allocation.

6 years agoFixed AS comments. 5167/head
Luca Heltai [Thu, 5 Oct 2017 10:25:44 +0000 (12:25 +0200)]
Fixed AS comments.

6 years agoSimplify code by omitting members that are now always either trueor false.
Wolfgang Bangerth [Thu, 5 Oct 2017 03:48:35 +0000 (21:48 -0600)]
Simplify code by omitting members that are now always either trueor false.

6 years agoMerge pull request #5195 from masterleinad/reduce_all_reduce
Daniel Arndt [Wed, 4 Oct 2017 23:02:35 +0000 (01:02 +0200)]
Merge pull request #5195 from masterleinad/reduce_all_reduce

Reduce number of internal::all_reduce versions

6 years agoReduce number of versions of internal::all_reduce 5195/head
Daniel Arndt [Tue, 3 Oct 2017 22:53:21 +0000 (00:53 +0200)]
Reduce number of versions of internal::all_reduce

6 years agoAdd test for operator== and operator!= for ArrayView
Daniel Arndt [Wed, 4 Oct 2017 08:29:09 +0000 (10:29 +0200)]
Add test for operator== and operator!= for ArrayView


In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.