]>
https://gitweb.dealii.org/ - dealii.git/log
Matthias Maier [Mon, 3 Jul 2023 23:04:02 +0000 (23:04 +0000)]
Merge pull request #15602 from tamiko/pr_15600
[9.5] lac/scalapack.cc: fix an out-of-bounds write that leads to a double free
Matthias Maier [Mon, 3 Jul 2023 21:09:09 +0000 (21:09 +0000)]
Merge pull request #15606 from bangerth/disable-requires
[9.5] Disable parsing 'requires' clauses on the 9.5 branch.
Matthias Maier [Mon, 3 Jul 2023 16:54:55 +0000 (11:54 -0500)]
add a news/changes entry
Matthias Maier [Mon, 3 Jul 2023 01:40:44 +0000 (20:40 -0500)]
lac/scalapack.cc: fix an out-of-bounds write that leads to a double free
```
==
1080297 ==ERROR: AddressSanitizer: attempting free on address which was not malloc()-ed: 0x60200003da70 in thread T0
#0 0x55bcdd907b7d in operator delete(void*) (/srv/temp/testsuite-IQZ1b8kK/build/tests/scalapack/scalapack_06b.debug/scalapack_06b.debug+0x17cb7d)
#1 0x7fc52a4d2047 in void std::__1::__libcpp_operator_delete[abi:v160006]<void*>(void*) /usr/include/c++/v1/new:276:3
#2 0x7fc52a4d2047 in void std::__1::__do_deallocate_handle_size[abi:v160006]<>(void*, unsigned long) /usr/include/c++/v1/new:300:10
#3 0x7fc52a4d2047 in std::__1::__libcpp_deallocate[abi:v160006](void*, unsigned long, unsigned long) /usr/include/c++/v1/new:316:14
#4 0x7fc52a4d2047 in std::__1::allocator<int>::deallocate[abi:v160006](int*, unsigned long) /usr/include/c++/v1/__memory/allocator.h:131:13
#5 0x7fc52a4d2047 in std::__1::allocator_traits<std::__1::allocator<int>>::deallocate[abi:v160006](std::__1::allocator<int>&, int*, unsigned long) /usr/include/c++/v1/__memory/allocator_traits.h:288:13
#6 0x7fc52a4d2047 in std::__1::__split_buffer<int, std::__1::allocator<int>&>::~__split_buffer() /usr/include/c++/v1/__split_buffer:362:9
#7 0x7fc52a4d2047 in std::__1::vector<int, std::__1::allocator<int>>::__append(unsigned long) /usr/include/c++/v1/vector:1049:5
#8 0x7fc52a8282d2 in std::__1::vector<int, std::__1::allocator<int>>::resize(unsigned long) /usr/include/c++/v1/vector:1910:15
#9 0x7fc52a8282d2 in dealii::ScaLAPACKMatrix<double>::eigenpairs_symmetric(bool, std::__1::pair<unsigned int, unsigned int> const&, std::__1::pair<double, double> const&) /srv/temp/testsuite-IQZ1b8kK/dealii/source/lac/scalapack.cc:1684:17
#10 0x7fc52a826813 in dealii::ScaLAPACKMatrix<double>::eigenpairs_symmetric_by_index(std::__1::pair<unsigned int, unsigned int> const&, bool) /srv/temp/testsuite-IQZ1b8kK/dealii/source/lac/scalapack.cc:1446:12
#11 0x55bcdd911907 in void test<double>(unsigned int, unsigned int, double) /srv/temp/testsuite-IQZ1b8kK/dealii/tests/scalapack/scalapack_06b.cc:134:21
#12 0x55bcdd90ebc8 in main /srv/temp/testsuite-IQZ1b8kK/dealii/tests/scalapack/scalapack_06b.cc:207:9
#13 0x7fc4f5250989 (/usr/lib64/libc.so.6+0x23989)
#14 0x7fc4f5250a44 in __libc_start_main (/usr/lib64/libc.so.6+0x23a44)
#15 0x55bcdd7f73f0 in _start (/srv/temp/testsuite-IQZ1b8kK/build/tests/scalapack/scalapack_06b.debug/scalapack_06b.debug+0x6c3f0)
```
Matthias Maier [Mon, 3 Jul 2023 03:40:00 +0000 (03:40 +0000)]
Merge pull request #15595 from masterleinad/cherry_pick_15591
[9.5] Allow running step-64 without CUDA
Wolfgang Bangerth [Mon, 3 Jul 2023 03:02:33 +0000 (21:02 -0600)]
Disable parsing 'requires' clauses on the 9.5 branch.
Daniel Arndt [Sun, 2 Jul 2023 16:08:37 +0000 (12:08 -0400)]
Allow running step-64 without CUDA
Matthias Maier [Fri, 30 Jun 2023 12:12:37 +0000 (07:12 -0500)]
update VERSION for release
Martin Kronbichler [Fri, 30 Jun 2023 05:41:46 +0000 (07:41 +0200)]
Merge pull request #15533 from tamiko/pr_15532
[9.5] Only enable -ffp-exception-behavior=strict for some platforms.
David Wells [Thu, 29 Jun 2023 21:12:08 +0000 (17:12 -0400)]
Only enable -ffp-exception-behavior=strict for some platforms.
This doesn't work with AppleClang 14.0, even though the enable_with_supported()
flag works.
Matthias Maier [Fri, 30 Jun 2023 00:18:26 +0000 (00:18 +0000)]
Merge pull request #15523 from tamiko/fix_a_test_30-9.5
[9.5] Test: mpi/locally_owned_dofs_per_subdomain_02: do not compare output
Luca Heltai [Thu, 29 Jun 2023 20:06:07 +0000 (22:06 +0200)]
Merge pull request #15515 from tamiko/remove_vtk
[9.5] CMake: remove VTK configure option
Martin Kronbichler [Thu, 29 Jun 2023 19:30:12 +0000 (21:30 +0200)]
Merge pull request #15518 from tamiko/remove_taskflow_2
[9.5] CMake: remove taskflow macros from config.h.in
Matthias Maier [Thu, 29 Jun 2023 16:03:39 +0000 (11:03 -0500)]
github/action: remove "setup_tests_vtk" from "linux debug parallel simplex" test
Matthias Maier [Thu, 29 Jun 2023 13:43:04 +0000 (08:43 -0500)]
Test: mpi/locally_owned_dofs_per_subdomain_02: do not compare output
The parallel partition that we compared in this test depends on metis,
and thus shows different (but valid) output depending on machine,
and chosen optimization level. Let us restrict this test to run only and
not compare the output.
Matthias Maier [Wed, 28 Jun 2023 22:53:27 +0000 (17:53 -0500)]
doc: remove vtk feature configuration examples
Matthias Maier [Wed, 28 Jun 2023 22:52:06 +0000 (17:52 -0500)]
tests: remove vtk tests
Matthias Maier [Wed, 28 Jun 2023 22:51:12 +0000 (17:51 -0500)]
includes: remove VTK header files
Matthias Maier [Wed, 28 Jun 2023 16:05:46 +0000 (11:05 -0500)]
CMake: remove VTK configure option
Our CMake configure for VTK isn't quite prime-time ready. Given the fact
that we currently only support a very minimal infrastructure, let's just
remove the configure option for the release.
Acked-by: Luca Heltai <luca.heltai@sissa.it>
Matthias Maier [Wed, 28 Jun 2023 20:05:06 +0000 (15:05 -0500)]
CMake: remove taskflow macros from config.h.in
Matthias Maier [Wed, 28 Jun 2023 19:22:36 +0000 (19:22 +0000)]
Merge pull request #15514 from tamiko/pr_15513
[9.5] Fix output for matrix_free/matrix_free_device_initialize_vector with CUDA support
Daniel Arndt [Wed, 28 Jun 2023 15:48:47 +0000 (15:48 +0000)]
Fix output for matrix_free/matrix_free_device_initialize_vector with CUDA support
Matthias Maier [Tue, 27 Jun 2023 23:38:51 +0000 (18:38 -0500)]
update VERSION for release
Martin Kronbichler [Tue, 27 Jun 2023 22:29:44 +0000 (00:29 +0200)]
Merge pull request #15511 from tamiko/disable_taskflow
[9.5] Remove taskflow configuration option and bundled library
Martin Kronbichler [Tue, 27 Jun 2023 22:29:22 +0000 (00:29 +0200)]
Merge pull request #15510 from tamiko/fp_exception_behavior_strict_95
[9.5] CMake: enable -ffp-exceptions-behavior=strict when compiling with clang
Matthias Maier [Tue, 27 Jun 2023 21:20:26 +0000 (16:20 -0500)]
Bundled: remove bundled taskflow
Matthias Maier [Tue, 27 Jun 2023 21:17:19 +0000 (16:17 -0500)]
CMake: disable DEAL_II_WITH_TASKFLOW
Matthias Maier [Tue, 27 Jun 2023 21:03:10 +0000 (21:03 +0000)]
Merge pull request #15506 from tamiko/update_authors_license
[9.5] update AUTHORS.md and LICENSE.md
Matthias Maier [Tue, 27 Jun 2023 20:46:20 +0000 (15:46 -0500)]
CMake: enable -ffp-exceptions-behavior=strict when compiling with clang
We have to ensure that we emit floating-point instructions in debug mode
that preserve the occurence of floating-point exceptions and don't
introduce new ones. gcc plays nicely in this regard by enabling
`-ftrapping-math` per default, at least for the level of optimization we
have in debug mode. clang however is more aggressive and assumes that it
can optimize code disregarding precise floating-point exception
semantics.
We thus set `-ffp-exceptions-behavior=strict` in debug mode to ensure
that our testsuite doesn't run into false positive floating-point
exceptions. See https://github.com/dealii/dealii/issues/15496
Matthias Maier [Tue, 27 Jun 2023 17:03:45 +0000 (12:03 -0500)]
update LICENSE.md
Matthias Maier [Tue, 27 Jun 2023 17:02:03 +0000 (12:02 -0500)]
add AUTHORS.md
Matthias Maier [Tue, 27 Jun 2023 16:40:52 +0000 (11:40 -0500)]
update VERSION
Matthias Maier [Tue, 27 Jun 2023 16:39:22 +0000 (16:39 +0000)]
Merge pull request #15503 from tamiko/update-changes-file
Update the changelog file for the release.
Matthias Maier [Tue, 27 Jun 2023 16:12:23 +0000 (11:12 -0500)]
fix whitespace
Matthias Maier [Tue, 27 Jun 2023 15:57:50 +0000 (10:57 -0500)]
doc: fix typos and use <code> annotation in two places
Matthias Maier [Tue, 27 Jun 2023 15:50:02 +0000 (10:50 -0500)]
doc: use https:// instead of http://
Matthias Maier [Tue, 27 Jun 2023 15:49:51 +0000 (10:49 -0500)]
doc: update tag file list
Matthias Maier [Tue, 27 Jun 2023 15:47:58 +0000 (10:47 -0500)]
Add dummy files.
Matthias Maier [Tue, 27 Jun 2023 15:45:55 +0000 (10:45 -0500)]
Remove now obsolete files.
Matthias Maier [Tue, 27 Jun 2023 15:45:01 +0000 (10:45 -0500)]
Add a misplaced entry
Matthias Maier [Tue, 27 Jun 2023 15:42:35 +0000 (10:42 -0500)]
Update the changelog file for the release.
Matthias Maier [Tue, 27 Jun 2023 14:43:25 +0000 (14:43 +0000)]
Merge pull request #15499 from tamiko/bind_to_none
CMake: run_test.sh: ensure to never bind to cores/processors for mpi tests
Matthias Maier [Tue, 27 Jun 2023 14:42:32 +0000 (14:42 +0000)]
Merge pull request #15502 from masterleinad/fix_compiling_clang_16_new
Fix compiling with clang-16 and C++20
Matthias Maier [Tue, 27 Jun 2023 14:22:08 +0000 (09:22 -0500)]
CMake: run_test.sh: also try to suppress kokkos warnings
Matthias Maier [Tue, 27 Jun 2023 01:41:33 +0000 (20:41 -0500)]
CMake: run_test.sh: ensure to never bind to cores/processors for mpi tests
Daniel Arndt [Tue, 27 Jun 2023 12:43:05 +0000 (08:43 -0400)]
Fix compiling with clang-16
Martin Kronbichler [Tue, 27 Jun 2023 12:03:02 +0000 (14:03 +0200)]
Merge pull request #15500 from tamiko/redemption
Tests: exonerate two debug test variants and run them again
Matthias Maier [Tue, 27 Jun 2023 02:38:35 +0000 (21:38 -0500)]
Revert "Test distributed_grids/checkpointing_03: do not run debug variant"
This reverts commit
6b92cdabc142c6b1fc82c16cf7a2cfbe996cd644 .
Matthias Maier [Tue, 27 Jun 2023 02:34:01 +0000 (21:34 -0500)]
Revert "Test fe/fe_enriched_color_07: do not run debug variant"
This reverts commit
56dd9b490b4e15468969ff4856758ccedb107120 .
Matthias Maier [Tue, 27 Jun 2023 02:04:55 +0000 (02:04 +0000)]
Merge pull request #15498 from tamiko/update_mailmap
Update .mailmap: a quick update to fix some spelling e-mail setting mistakes
Matthias Maier [Tue, 27 Jun 2023 00:01:59 +0000 (19:01 -0500)]
Update .mailmap: a quick update to fix some spelling e-mail setting mistakes
Marc Fehling [Mon, 26 Jun 2023 21:42:30 +0000 (15:42 -0600)]
Merge pull request #15493 from tamiko/fix_test_20
Test non_matching/step-70: add an output variant
Matthias Maier [Mon, 26 Jun 2023 21:35:12 +0000 (21:35 +0000)]
Merge pull request #15494 from masterleinad/require_arborx_1_3
Require ArborX 1.3 or later
Matthias Maier [Mon, 26 Jun 2023 21:34:53 +0000 (21:34 +0000)]
Merge pull request #15492 from bangerth/task
Ensure we set a flag correctly even if a task ends in an exception.
Matthias Maier [Mon, 26 Jun 2023 20:24:25 +0000 (20:24 +0000)]
Merge pull request #15497 from tamiko/bob/fix_test_21
Test simplex/compute_point_locations_01: add output variant
Matthias Maier [Mon, 26 Jun 2023 20:23:25 +0000 (20:23 +0000)]
Merge pull request #15491 from tamiko/fix_test_18
Test numerics/nonlinear_solver_selector_03: add ouput variant
Matthias Maier [Mon, 26 Jun 2023 19:46:28 +0000 (14:46 -0500)]
Test simplex/compute_point_locations_01: add output variant
With clang-16 libc++ we get a different order of quadrature points.
Verified manually that - apart from the order - all output quadrature
points match.
Daniel Arndt [Mon, 26 Jun 2023 19:04:24 +0000 (15:04 -0400)]
Require ArborX 1.3 or later
Matthias Maier [Mon, 26 Jun 2023 19:07:17 +0000 (14:07 -0500)]
Test non_matching/step-70: add an output variant
Add an output variant for the case when deal.II is configured with PETSc
support but without Trilinos support.
Wolfgang Bangerth [Mon, 26 Jun 2023 19:06:34 +0000 (13:06 -0600)]
Add a changelog entry.
Wolfgang Bangerth [Mon, 26 Jun 2023 19:03:10 +0000 (13:03 -0600)]
Ensure we set a flag correctly even if a task ends in an exception.
Matthias Maier [Mon, 26 Jun 2023 18:54:03 +0000 (13:54 -0500)]
Test numerics/nonlinear_solver_selector_03: add ouput variant
Add an output variant for the case when deal.II is configured with PETSc
support but without Trilinos support.
Matthias Maier [Mon, 26 Jun 2023 17:56:45 +0000 (17:56 +0000)]
Merge pull request #15488 from tamiko/fix_test_17
Test: cgal/cgal_intersect_simplices_2d_3d: restrict to CGAL >= 5.5.0
Wolfgang Bangerth [Mon, 26 Jun 2023 17:54:08 +0000 (11:54 -0600)]
Merge pull request #15487 from tamiko/fix_test_16
Test mpi/p4est_bug_01: remove test
Matthias Maier [Mon, 26 Jun 2023 15:09:53 +0000 (10:09 -0500)]
Test: cgal/cgal_intersect_simplices_2d_3d: restrict to CGAL >= 5.5.0
Matthias Maier [Mon, 26 Jun 2023 15:00:03 +0000 (10:00 -0500)]
Test mpi/p4est_bug_01: remove test
This test needs an external p4est library built with debug symbols,
otherwise it "fails" because we do not error out while running the test
"expect=run".
Let's remove this test for now.
The long standing bug it documents is reported in
https://github.com/dealii/dealii/issues/7428
See also
https://github.com/dealii/dealii/issues/9047
Matthias Maier [Mon, 26 Jun 2023 14:49:22 +0000 (14:49 +0000)]
Merge pull request #15486 from kronbichler/test_robustness2
MatrixFree inverse mass matrix: Make tests more robust
David Wells [Mon, 26 Jun 2023 14:14:40 +0000 (10:14 -0400)]
Merge pull request #15485 from kronbichler/output_variants
Add two output variants for tests writing p4est vtk output
Martin Kronbichler [Mon, 26 Jun 2023 11:25:42 +0000 (13:25 +0200)]
Make tests more robust
Martin Kronbichler [Mon, 26 Jun 2023 08:26:03 +0000 (10:26 +0200)]
Add two output variants for tests writing p4est vtk output
Matthias Maier [Sun, 25 Jun 2023 21:55:54 +0000 (21:55 +0000)]
Merge pull request #15481 from tjhei/kinsol-warning
fix kinsol unused lambda capture warning
Matthias Maier [Sun, 25 Jun 2023 21:55:42 +0000 (21:55 +0000)]
Merge pull request #15482 from tjhei/unused-var
fix unused variable warning
Timo Heister [Sun, 25 Jun 2023 18:43:43 +0000 (14:43 -0400)]
fix kinsol unused lambda capture warning
Timo Heister [Sun, 25 Jun 2023 18:45:05 +0000 (14:45 -0400)]
fix unused variable warning
Matthias Maier [Sun, 25 Jun 2023 07:07:34 +0000 (07:07 +0000)]
Merge pull request #15474 from luca-heltai/stefanozampini/fp-trap
Fixes for FPE and older versions of PETSc
Matthias Maier [Sun, 25 Jun 2023 07:04:55 +0000 (07:04 +0000)]
Merge pull request #15477 from tamiko/fix_test_15
Test fe/fe_enriched_color_07: do not run debug variant
Matthias Maier [Sun, 25 Jun 2023 05:44:13 +0000 (05:44 +0000)]
Merge pull request #15475 from tamiko/restrict_scalapack_test_variants
Test scalapack/*: restrict all scalapack tests to less than 10 mpi ranks
Matthias Maier [Sun, 25 Jun 2023 04:00:29 +0000 (04:00 +0000)]
Merge pull request #15473 from tamiko/fix_test_14
Test mpi/trilinos_step-27: add output variant
Matthias Maier [Sun, 25 Jun 2023 04:00:14 +0000 (04:00 +0000)]
Merge pull request #15472 from tamiko/fix_test_13
Test distributed_grids/checkpointing_03: do not run debug variant
Matthias Maier [Sun, 25 Jun 2023 03:16:18 +0000 (03:16 +0000)]
Merge pull request #15465 from bangerth/kokkos
Filter out --help from argv when initializing Kokkos
Matthias Maier [Sun, 25 Jun 2023 03:14:49 +0000 (03:14 +0000)]
Merge pull request #15471 from tamiko/fix_la_test_02
Test lac/vector_memory_02: add output variant
Matthias Maier [Sun, 25 Jun 2023 03:10:53 +0000 (03:10 +0000)]
Merge pull request #15470 from tamiko/fix_la_test
Test: lac/linear_operator_10: disable floating point exceptions
Matthias Maier [Sun, 25 Jun 2023 03:10:31 +0000 (03:10 +0000)]
Merge pull request #15469 from tamiko/fix_grid_tools_cache_tests
Test grid/grid_tools_cache_{04,06,08,09}: add output variants
Matthias Maier [Sun, 25 Jun 2023 03:10:00 +0000 (03:10 +0000)]
Merge pull request #15468 from tamiko/fix_test_12
Test grid/grid_generator_pipe_junction: add output variant
Matthias Maier [Sun, 25 Jun 2023 03:09:35 +0000 (03:09 +0000)]
Merge pull request #15467 from tamiko/fix_cgal_test_02
Test cgal/cgal_triangulation_05: add test variant for clang-16, libc++
Matthias Maier [Sun, 25 Jun 2023 03:09:16 +0000 (03:09 +0000)]
Merge pull request #15466 from tamiko/fix_cgal_test
Test cgal/cgal_remesh_surface: disable floating point exceptions
Matthias Maier [Sun, 25 Jun 2023 02:36:31 +0000 (21:36 -0500)]
Test fe/fe_enriched_color_07: do not run debug variant
This test is massive (a whopping 2000 lines of code) and regularly times
out on different regression tester variants. Let's restrict it to run in
release mode only.
Matthias Maier [Sun, 25 Jun 2023 00:54:50 +0000 (19:54 -0500)]
Test scalapack/*: restrict all scalapack tests to less than 10 mpi ranks
Let us restrict the maximal concurrency of scalapack tests to less than
10 MPI ranks:
- The purpose of these tests is to test our interfaces to scalapack and
not whether scalapack functions properly for high(er) MPI
concurrency. As such testing a few variants with a low number of MPI
ranks is enough.
- This cuts down the number of tests in our testsuite that have a
concurrency of 10 or more from around 225 to around 190.
The issue with these tests is the fact that we have to block off
parallel slots in the ctest run equal to the number of MPI ranks.
Meaning the more tests we have that have a high number of MPI ranks
the less optimal the scheduling in ctest.
Matthias Maier [Sun, 25 Jun 2023 00:21:35 +0000 (19:21 -0500)]
Test mpi/trilinos_step-27: add output variant
With clang and libc++ I get a slightly different adaptive refinement.
Thus add an output variant.
Stefano Zampini [Sun, 25 Jun 2023 00:14:15 +0000 (03:14 +0300)]
Disable FPE trapping in some tests with older versions of PETSc
Matthias Maier [Sun, 25 Jun 2023 00:10:55 +0000 (19:10 -0500)]
Test distributed_grids/checkpointing_03: do not run debug variant
With gcc-13 in debug mode this test can takeup to 10 minutes to
complete. Thus, restict it to release mode where it only takes a couple
of seconds.
Matthias Maier [Sun, 25 Jun 2023 00:02:19 +0000 (19:02 -0500)]
Test lac/vector_memory_02: add output variant
Stefano Zampini [Sat, 24 Jun 2023 23:52:22 +0000 (02:52 +0300)]
Fix warning
catching polymorphic type ‘class dealii::StandardExceptions::ExcFunctionNotProvided’ by value [-Wcatch-value=]
Stefano Zampini [Sat, 24 Jun 2023 22:38:12 +0000 (00:38 +0200)]
alternative outputs for MACOSX
Stefano Zampini [Sat, 24 Jun 2023 22:15:26 +0000 (00:15 +0200)]
Some versions of PETSc do not apply Shift if zero!
Matthias Maier [Sat, 24 Jun 2023 23:56:34 +0000 (18:56 -0500)]
Test: lac/linear_operator_10: disable floating point exceptions
Matthias Maier [Sat, 24 Jun 2023 23:44:07 +0000 (18:44 -0500)]
Test grid/grid_tools_cache_09: add output variants
Matthias Maier [Sat, 24 Jun 2023 23:37:08 +0000 (18:37 -0500)]
Test grid/grid_tools_cache_08: add output variant
Matthias Maier [Sat, 24 Jun 2023 23:03:00 +0000 (18:03 -0500)]
Test cgal/cgal_remesh_surface: disable floating point exceptions
Matthias Maier [Sat, 24 Jun 2023 23:33:52 +0000 (18:33 -0500)]
Test grid/grid_tools_cache_06: add output variant
In the beginning the Universe was created. This has made a lot of
people very angry and has been widely regarded as a bad move.
Douglas Adams
Typeset in
Trocchi and Trocchi Bold Sans Serif.