]> https://gitweb.dealii.org/ - dealii.git/log
dealii.git
6 years agoMerge pull request #6861 from kronbichler/fix_evaluation_bug_1d
Martin Kronbichler [Fri, 27 Jul 2018 06:06:51 +0000 (08:06 +0200)]
Merge pull request #6861 from kronbichler/fix_evaluation_bug_1d

Fix bug in FEFaceEvaluation in 1D

6 years agoAdd changelogs. 6861/head
Martin Kronbichler [Wed, 4 Jul 2018 13:36:24 +0000 (15:36 +0200)]
Add changelogs.

6 years agoAdd test cases.
Martin Kronbichler [Wed, 4 Jul 2018 13:36:15 +0000 (15:36 +0200)]
Add test cases.

6 years agoEnable 1D case in inverse mass matrix operator.
Martin Kronbichler [Wed, 4 Jul 2018 13:32:31 +0000 (15:32 +0200)]
Enable 1D case in inverse mass matrix operator.

6 years agoFix bug in FEFaceEvaluation in 1D.
Martin Kronbichler [Fri, 29 Jun 2018 15:48:42 +0000 (17:48 +0200)]
Fix bug in FEFaceEvaluation in 1D.

6 years agoMerge pull request #6967 from luca-heltai/boost-bounding-box
Daniel Arndt [Thu, 26 Jul 2018 14:57:21 +0000 (16:57 +0200)]
Merge pull request #6967 from luca-heltai/boost-bounding-box

Boost bounding box

6 years agoMerge pull request #6989 from tjhei/fix_geod_reference_step_18
Daniel Arndt [Thu, 26 Jul 2018 13:30:38 +0000 (15:30 +0200)]
Merge pull request #6989 from tjhei/fix_geod_reference_step_18

Fix reference to step-18 in documentation

6 years agoFix reference to step-18 in documentation 6989/head
Timo Heister [Thu, 26 Jul 2018 13:15:55 +0000 (15:15 +0200)]
Fix reference to step-18 in documentation

6 years agoMerge pull request #6987 from masterleinad/fix_warning_mpi_attach_data_02
Wolfgang Bangerth [Thu, 26 Jul 2018 13:03:59 +0000 (07:03 -0600)]
Merge pull request #6987 from masterleinad/fix_warning_mpi_attach_data_02

Avoid warning in mpi/attach_data_02

6 years agoMerge pull request #6960 from marcfehling/cleanup-6939
Daniel Arndt [Thu, 26 Jul 2018 12:43:37 +0000 (14:43 +0200)]
Merge pull request #6960 from marcfehling/cleanup-6939

Prevent warnings introduced in #6936.

6 years agoAvoid warning in mpi/attach_data_02 6987/head
Daniel Arndt [Thu, 26 Jul 2018 12:38:41 +0000 (14:38 +0200)]
Avoid warning in mpi/attach_data_02

6 years agoMerge pull request #5499 from jppelteret/ad-drivers
Wolfgang Bangerth [Thu, 26 Jul 2018 09:14:54 +0000 (03:14 -0600)]
Merge pull request #5499 from jppelteret/ad-drivers

Implement driver interface for internally supported AD libraries.

6 years agoOptimise and extend some of the functions in the AD drivers classes. 5499/head
Jean-Paul Pelteret [Thu, 26 Jul 2018 08:02:12 +0000 (10:02 +0200)]
Optimise and extend some of the functions in the AD drivers classes.

6 years agoUpdate configuration to detect new ADOL-C "feature" :-/
Jean-Paul Pelteret [Sat, 21 Jul 2018 21:43:35 +0000 (23:43 +0200)]
Update configuration to detect new ADOL-C "feature" :-/

6 years agoImplement driver classes for internally supported AD libraries.
Jean-Paul Pelteret [Sat, 18 Nov 2017 11:13:50 +0000 (12:13 +0100)]
Implement driver classes for internally supported AD libraries.

6 years agoMerge pull request #6971 from GivAlz/Distr_documentation
Wolfgang Bangerth [Thu, 26 Jul 2018 07:10:04 +0000 (01:10 -0600)]
Merge pull request #6971 from GivAlz/Distr_documentation

Improved description compute point locations

6 years agoMerge pull request #6955 from masterleinad/unused_variable_solution_transfer_unpack_c...
Wolfgang Bangerth [Thu, 26 Jul 2018 07:08:31 +0000 (01:08 -0600)]
Merge pull request #6955 from masterleinad/unused_variable_solution_transfer_unpack_callback

Avoid warning regarding unused variable in SolutionTransfer::unpack_callback

6 years agoMerge pull request #6974 from masterleinad/indent_example-step-15
Denis Davydov [Thu, 26 Jul 2018 05:50:25 +0000 (07:50 +0200)]
Merge pull request #6974 from masterleinad/indent_example-step-15

example/step-15: Update indenting and modernize

6 years agoMerge pull request #6973 from tamiko/fix_cmake
Daniel Arndt [Thu, 26 Jul 2018 05:49:17 +0000 (07:49 +0200)]
Merge pull request #6973 from tamiko/fix_cmake

CMake: Do not check for the geometry component in FindBOOST.cmake

6 years agoexample/step-15: Update indenting and modernize 6974/head
Daniel Arndt [Wed, 25 Jul 2018 12:49:25 +0000 (14:49 +0200)]
example/step-15: Update indenting and modernize

6 years agoCMake: Do not check for the geometry component in FindBOOST.cmake 6973/head
Matthias Maier [Wed, 25 Jul 2018 12:42:25 +0000 (07:42 -0500)]
CMake: Do not check for the geometry component in FindBOOST.cmake

Boost.Geometry is a header-only component of Boost. It is
unconditionally installed.

CMake does not support to configure with the "geometry" component
because it cannot pick up a corresponding library (is true at least for
versions 3.9, 3.10, 3.11, 3.12).

Thus, remove the geometry component from the find(Boost ...) call.

Closes #6969

6 years agoImproved description compute point locations 6971/head
Giovanni Alzetta [Wed, 25 Jul 2018 10:43:22 +0000 (12:43 +0200)]
Improved description compute point locations

6 years agoMerge pull request #6920 from marcfehling/variable-transfer
Wolfgang Bangerth [Wed, 25 Jul 2018 08:31:28 +0000 (02:31 -0600)]
Merge pull request #6920 from marcfehling/variable-transfer

Support for transfer of variable size data.

6 years agoMerge pull request #6944 from luca-heltai/add-constructor-function-parser
Wolfgang Bangerth [Wed, 25 Jul 2018 08:22:25 +0000 (02:22 -0600)]
Merge pull request #6944 from luca-heltai/add-constructor-function-parser

Add new constructor to function parser

6 years agoMerge pull request #6966 from masterleinad/restrict_p4est
Wolfgang Bangerth [Wed, 25 Jul 2018 08:18:25 +0000 (02:18 -0600)]
Merge pull request #6966 from masterleinad/restrict_p4est

Restrict tests requiring p4est

6 years agoSome rtree tests with Points. 6967/head
Luca Heltai [Tue, 24 Jul 2018 21:41:33 +0000 (23:41 +0200)]
Some rtree tests with Points.

6 years agoSupport for transfer of variable size data. 6920/head
Marc Fehling [Fri, 6 Jul 2018 21:11:33 +0000 (15:11 -0600)]
Support for transfer of variable size data.

6 years agoMerge pull request #6962 from marcfehling/indentation-fe_collection_05
Daniel Arndt [Tue, 24 Jul 2018 19:47:43 +0000 (21:47 +0200)]
Merge pull request #6962 from marcfehling/indentation-fe_collection_05

Fix indentation for 'tests/hp/fe_collection_05'.

6 years agoRestrict tests requiring p4est 6966/head
Daniel Arndt [Tue, 24 Jul 2018 16:44:49 +0000 (18:44 +0200)]
Restrict tests requiring p4est

6 years agoChangeLog.
Luca Heltai [Tue, 24 Jul 2018 18:58:24 +0000 (20:58 +0200)]
ChangeLog.

6 years agoAdded adaptor for bounding box.
Luca Heltai [Tue, 24 Jul 2018 18:55:35 +0000 (20:55 +0200)]
Added adaptor for bounding box.

6 years agoMake sure also <deal.II/boost_adaptors/*.h> gets ordered
Luca Heltai [Tue, 24 Jul 2018 18:55:13 +0000 (20:55 +0200)]
Make sure also <deal.II/boost_adaptors/*.h> gets ordered

6 years agoRenamed tests/boost/boost_* to tests/boost/*
Luca Heltai [Tue, 24 Jul 2018 18:54:36 +0000 (20:54 +0200)]
Renamed tests/boost/boost_* to tests/boost/*

6 years agoMerge pull request #6963 from drwells/fix-generate_lapack_templates
Jean-Paul Pelteret [Tue, 24 Jul 2018 15:47:11 +0000 (17:47 +0200)]
Merge pull request #6963 from drwells/fix-generate_lapack_templates

Fix generate lapack templates

6 years agoImprove generate_lapack_templates' documentation. 6963/head
David Wells [Tue, 24 Jul 2018 15:28:00 +0000 (11:28 -0400)]
Improve generate_lapack_templates' documentation.

6 years agoFix execution of generate_lapack_templates.
David Wells [Tue, 24 Jul 2018 15:27:47 +0000 (11:27 -0400)]
Fix execution of generate_lapack_templates.

6 years agoMerge pull request #6950 from luca-heltai/boost-geometry
Daniel Arndt [Tue, 24 Jul 2018 15:18:00 +0000 (17:18 +0200)]
Merge pull request #6950 from luca-heltai/boost-geometry

Added boost::point adaptor

6 years agoAddressed Daniel's comments 6950/head
Luca Heltai [Tue, 24 Jul 2018 09:08:07 +0000 (11:08 +0200)]
Addressed Daniel's comments

6 years agoMerge pull request #6823 from tjhei/cmake_deprecated_using
Timo Heister [Tue, 24 Jul 2018 08:51:07 +0000 (10:51 +0200)]
Merge pull request #6823 from tjhei/cmake_deprecated_using

cmake check for using and DEAL_II_DEPRECATED

6 years agoFix indentation for 'tests/hp/fe_collection_05'. 6962/head
Marc Fehling [Tue, 24 Jul 2018 01:46:18 +0000 (19:46 -0600)]
Fix indentation for 'tests/hp/fe_collection_05'.

6 years agoPrevent warnings introduced in #6936. 6960/head
Marc Fehling [Mon, 23 Jul 2018 21:24:31 +0000 (15:24 -0600)]
Prevent warnings introduced in #6936.

6 years agoMerge pull request #6958 from bangerth/make-virtual
Daniel Arndt [Mon, 23 Jul 2018 20:16:35 +0000 (22:16 +0200)]
Merge pull request #6958 from bangerth/make-virtual

Make it even clearer that a function is 'virtual'.

6 years agoMerge pull request #6949 from masterleinad/avoid_warning
Timo Heister [Mon, 23 Jul 2018 15:37:18 +0000 (17:37 +0200)]
Merge pull request #6949 from masterleinad/avoid_warning

Avoid #warning using MSVC

6 years agoMake it even clearer that a function is 'virtual'. 6958/head
Wolfgang Bangerth [Mon, 23 Jul 2018 15:36:14 +0000 (09:36 -0600)]
Make it even clearer that a function is 'virtual'.

6 years agoMerge pull request #6943 from jppelteret/ad-lac_static_asserts
Wolfgang Bangerth [Mon, 23 Jul 2018 14:17:58 +0000 (08:17 -0600)]
Merge pull request #6943 from jppelteret/ad-lac_static_asserts

Add AD number static asserts for FullMatrix and Vector classes.

6 years agoAvoid warning regarding unused variable in SolutionTransfer::unpack_callback 6955/head
Daniel Arndt [Mon, 23 Jul 2018 09:05:20 +0000 (11:05 +0200)]
Avoid warning regarding unused variable in SolutionTransfer::unpack_callback

6 years agoChangeLog
Luca Heltai [Sun, 22 Jul 2018 15:16:16 +0000 (17:16 +0200)]
ChangeLog

6 years agoAdded boost::geometry point adaptor for deal.II
Luca Heltai [Sun, 22 Jul 2018 14:38:31 +0000 (16:38 +0200)]
Added boost::geometry point adaptor for deal.II

6 years agoCheck if external boost library contains geometry.
Luca Heltai [Sun, 22 Jul 2018 15:16:05 +0000 (17:16 +0200)]
Check if external boost library contains geometry.

6 years agoAdded boost/geometry.
Luca Heltai [Mon, 23 Jul 2018 07:29:20 +0000 (09:29 +0200)]
Added boost/geometry.

6 years agoMerge pull request #6928 from marcfehling/fixes-6880
Daniel Arndt [Mon, 23 Jul 2018 05:24:42 +0000 (07:24 +0200)]
Merge pull request #6928 from marcfehling/fixes-6880

Force same FE object for transferring data.

6 years agoMerge pull request #6951 from bangerth/doc-update
Daniel Arndt [Mon, 23 Jul 2018 05:23:18 +0000 (07:23 +0200)]
Merge pull request #6951 from bangerth/doc-update

Update the documentation of hp::FECollection::find_least_face_dominating_fe().

6 years agoMerge pull request #6952 from bangerth/doc-update-2
Daniel Arndt [Sun, 22 Jul 2018 20:53:05 +0000 (22:53 +0200)]
Merge pull request #6952 from bangerth/doc-update-2

Match doxygen markup in the .cc file to that in the .h file.

6 years agoMerge pull request #6953 from masterleinad/ignore_deleted
Wolfgang Bangerth [Sun, 22 Jul 2018 16:50:51 +0000 (10:50 -0600)]
Merge pull request #6953 from masterleinad/ignore_deleted

Ignore deleted files when formatting

6 years agoIgnore deleted files when formatting 6953/head
Daniel Arndt [Sun, 22 Jul 2018 16:35:17 +0000 (18:35 +0200)]
Ignore deleted files when formatting

6 years agoMerge pull request #6942 from masterleinad/common_ancestor_formatting
Timo Heister [Sun, 22 Jul 2018 16:08:48 +0000 (18:08 +0200)]
Merge pull request #6942 from masterleinad/common_ancestor_formatting

Use common ancestor as base for formatting recent files

6 years agoMatch doxygen markup in the .cc file to that in the .h file. 6952/head
Wolfgang Bangerth [Sun, 22 Jul 2018 15:45:50 +0000 (09:45 -0600)]
Match doxygen markup in the .cc file to that in the .h file.

This is necessary because we run both the .h and the .cc files through doxygen.
If we don't do this, then doxygen will show functions with different markup
twice in the online documentation.

6 years agoUse a better text to describe what we do.
Wolfgang Bangerth [Sun, 22 Jul 2018 15:41:28 +0000 (09:41 -0600)]
Use a better text to describe what we do.

6 years agoUpdate the documentation of hp::FECollection::find_least_face_dominating_fe(). 6951/head
Wolfgang Bangerth [Sun, 22 Jul 2018 15:00:04 +0000 (09:00 -0600)]
Update the documentation of hp::FECollection::find_least_face_dominating_fe().

6 years agoMerge pull request #6939 from marcfehling/hp-distribute-fails
Wolfgang Bangerth [Sun, 22 Jul 2018 15:05:42 +0000 (09:05 -0600)]
Merge pull request #6939 from marcfehling/hp-distribute-fails

hp::DoFHandler::distribute_dofs on p::d::Triangulation fails.

6 years agoPrepend macro names with DEAL_II_ 6949/head
Daniel Arndt [Sun, 22 Jul 2018 14:45:06 +0000 (16:45 +0200)]
Prepend macro names with DEAL_II_

6 years agoAvoid #warning using MSVC
Daniel Arndt [Sun, 22 Jul 2018 13:04:08 +0000 (15:04 +0200)]
Avoid #warning using MSVC

6 years agoMerge pull request #6938 from masterleinad/improve_deprecation_tests
Timo Heister [Sun, 22 Jul 2018 13:45:37 +0000 (15:45 +0200)]
Merge pull request #6938 from masterleinad/improve_deprecation_tests

Improve deprecation check

6 years agoAddressed comments. 6944/head
Luca Heltai [Sun, 22 Jul 2018 13:16:22 +0000 (15:16 +0200)]
Addressed comments.

6 years agoRephrase comment 6938/head
Daniel Arndt [Sun, 22 Jul 2018 09:44:02 +0000 (11:44 +0200)]
Rephrase comment

6 years agoAdd AD number static asserts for FullMatrix and Vector classes. 6943/head
Jean-Paul Pelteret [Sat, 21 Jul 2018 14:41:04 +0000 (16:41 +0200)]
Add AD number static asserts for FullMatrix and Vector classes.

6 years agoChangelog
Luca Heltai [Sat, 21 Jul 2018 15:30:30 +0000 (17:30 +0200)]
Changelog

6 years agoAdd test for new function parser constructor.
Luca Heltai [Sat, 21 Jul 2018 15:25:52 +0000 (17:25 +0200)]
Add test for new function parser constructor.

6 years agoMerge pull request #6929 from gassmoeller/fix_out_of_bound_memory_access
Jean-Paul Pelteret [Sat, 21 Jul 2018 14:44:11 +0000 (16:44 +0200)]
Merge pull request #6929 from gassmoeller/fix_out_of_bound_memory_access

Fix rare out of bound memory access in write_gmv_reorder_data_vectors

6 years agoAdd a new constructor for function parser.
Luca Heltai [Sat, 21 Jul 2018 14:42:26 +0000 (16:42 +0200)]
Add a new constructor for function parser.

6 years agoUse common ancestor as base for formatting recent files 6942/head
Daniel Arndt [Sat, 21 Jul 2018 13:35:31 +0000 (15:35 +0200)]
Use common ancestor as base for formatting recent files

6 years agoDon't actually construct deprecated objects in deprecation tests
Daniel Arndt [Thu, 19 Jul 2018 23:58:09 +0000 (01:58 +0200)]
Don't actually construct deprecated objects in deprecation tests

6 years agoAdd test for hp::distribute_dofs on p::d::Triangulation. 6939/head
Marc Fehling [Fri, 20 Jul 2018 17:21:33 +0000 (11:21 -0600)]
Add test for hp::distribute_dofs on p::d::Triangulation.

6 years agoFIX: hp::DoFHandler::distribute_dofs on p::d::Triangulation.
Marc Fehling [Fri, 20 Jul 2018 18:22:48 +0000 (12:22 -0600)]
FIX: hp::DoFHandler::distribute_dofs on p::d::Triangulation.

6 years agoIgnore spurious w2651 ICC warning
Daniel Arndt [Thu, 19 Jul 2018 23:56:33 +0000 (01:56 +0200)]
Ignore spurious w2651 ICC warning

6 years agoMerge pull request #6935 from masterleinad/fix_compute_point_to_point_communication_p...
David Wells [Thu, 19 Jul 2018 23:43:15 +0000 (19:43 -0400)]
Merge pull request #6935 from masterleinad/fix_compute_point_to_point_communication_pattern

Fix Utilities::MPI::compute_point_to_point_communication_pattern

6 years agoMerge pull request #6934 from masterleinad/alternative_output_data_out_12
David Wells [Thu, 19 Jul 2018 23:42:46 +0000 (19:42 -0400)]
Merge pull request #6934 from masterleinad/alternative_output_data_out_12

Provide alternative test output for data_out_12 without ZLIB support

6 years agoMerge pull request #6936 from masterleinad/fix_warnings_in_tests_new
David Wells [Thu, 19 Jul 2018 23:42:20 +0000 (19:42 -0400)]
Merge pull request #6936 from masterleinad/fix_warnings_in_tests_new

Fix some warnings in tests

6 years agoMerge pull request #6932 from masterleinad/replace_fesystem_constructor_tests
Daniel Arndt [Thu, 19 Jul 2018 17:19:52 +0000 (19:19 +0200)]
Merge pull request #6932 from masterleinad/replace_fesystem_constructor_tests

Use different FESystem constructor in tests

6 years agoFix some warnings in tests 6936/head
Daniel Arndt [Thu, 19 Jul 2018 17:18:19 +0000 (19:18 +0200)]
Fix some warnings in tests

6 years agoFix Utilities::MPI::compute_point_to_point_communication_pattern 6935/head
Daniel Arndt [Thu, 19 Jul 2018 17:00:34 +0000 (19:00 +0200)]
Fix Utilities::MPI::compute_point_to_point_communication_pattern

6 years agoMerge pull request #6933 from masterleinad/boost_header_p_d_tria
Daniel Arndt [Thu, 19 Jul 2018 15:50:09 +0000 (17:50 +0200)]
Merge pull request #6933 from masterleinad/boost_header_p_d_tria

Add missing boost header for p::d::Triangulation

6 years agoProvide alternative test output for data_out_12 without ZLIB support 6934/head
Daniel Arndt [Thu, 19 Jul 2018 15:46:50 +0000 (17:46 +0200)]
Provide alternative test output for data_out_12 without ZLIB support

6 years agoAdd missing boost header for p::d::Triangulation 6933/head
Daniel Arndt [Thu, 19 Jul 2018 12:47:49 +0000 (14:47 +0200)]
Add missing boost header for p::d::Triangulation

6 years agoUse different FESystem constructor in tests 6932/head
Daniel Arndt [Thu, 19 Jul 2018 12:05:09 +0000 (14:05 +0200)]
Use different FESystem constructor in tests

6 years agoIndent 6929/head
Rene Gassmoeller [Thu, 19 Jul 2018 00:51:00 +0000 (17:51 -0700)]
Indent

6 years agoAdd test
Rene Gassmoeller [Thu, 19 Jul 2018 00:48:48 +0000 (17:48 -0700)]
Add test

6 years agoAvoid out of bounds memory access
Rene Gassmoeller [Thu, 19 Jul 2018 00:42:35 +0000 (17:42 -0700)]
Avoid out of bounds memory access

6 years agoForce same FE object for transferring data. 6928/head
Marc Fehling [Wed, 18 Jul 2018 18:43:27 +0000 (12:43 -0600)]
Force same FE object for transferring data.

6 years agoMerge pull request #6927 from masterleinad/address-clang_tidy
Jean-Paul Pelteret [Wed, 18 Jul 2018 19:48:41 +0000 (21:48 +0200)]
Merge pull request #6927 from masterleinad/address-clang_tidy

Address clang-tidy suggestions

6 years agoAddress clang-tidy suggestions 6927/head
Daniel Arndt [Tue, 17 Jul 2018 23:07:01 +0000 (01:07 +0200)]
Address clang-tidy suggestions

6 years agoMerge pull request #6925 from drwells/add-colorization-glossary-entry
Daniel Arndt [Wed, 18 Jul 2018 08:39:01 +0000 (10:39 +0200)]
Merge pull request #6925 from drwells/add-colorization-glossary-entry

Add a glossary entry on colorization.

6 years agoReword the GridGenerator documentation on colorization. 6925/head
David Wells [Tue, 17 Jul 2018 02:36:21 +0000 (22:36 -0400)]
Reword the GridGenerator documentation on colorization.

6 years agoAdd a glossary entry on colorization.
David Wells [Mon, 16 Jul 2018 00:26:08 +0000 (20:26 -0400)]
Add a glossary entry on colorization.

6 years agoMerge pull request #6896 from masterleinad/fix_base_headers
Daniel Arndt [Tue, 17 Jul 2018 21:56:21 +0000 (23:56 +0200)]
Merge pull request #6896 from masterleinad/fix_base_headers

Fix comments in @code blocks in base headers

6 years agoFix comments in @code blocks in base headers 6896/head
Daniel Arndt [Sat, 7 Jul 2018 21:04:59 +0000 (23:04 +0200)]
Fix comments in @code blocks in base headers

6 years agoMerge pull request #6898 from masterleinad/merge_tria_copy_manifold_id
Wolfgang Bangerth [Mon, 16 Jul 2018 10:24:11 +0000 (04:24 -0600)]
Merge pull request #6898 from masterleinad/merge_tria_copy_manifold_id

Allow copying manifold ids in GridGenerator::merge_triangulations

6 years agoMerge pull request #6923 from bangerth/cleanup
David Wells [Sun, 15 Jul 2018 23:43:05 +0000 (19:43 -0400)]
Merge pull request #6923 from bangerth/cleanup

Clean up some code in AffineConstraints::is_consistent_in_parallel.

6 years agoMerge pull request #6921 from jppelteret/ad_updates_01
Jean-Paul Pelteret [Sun, 15 Jul 2018 18:16:04 +0000 (20:16 +0200)]
Merge pull request #6921 from jppelteret/ad_updates_01

Minor AD updates

6 years agoClean up some code in AffineConstraints::is_consistent_in_parallel. 6923/head
Wolfgang Bangerth [Sun, 15 Jul 2018 10:55:27 +0000 (04:55 -0600)]
Clean up some code in AffineConstraints::is_consistent_in_parallel.

The existing code has a lambda function that either returns a reference to
an existing element of a vector, or to a dummy member variable. But to
make things confusing, it *modifies* this dummy variable, which means that
what looks like some 'const' dummy object is not actually.

All of this is done to avoid copies, but in reality a copy is still
made at a later point where we insert the result of this lambda
function into a vector. This patch cleans this up by removing the
non-const dummy variable and instead just returning a copy that is
then moved into the vector. That's the same number of copies as before,
in most cases, and it's clearer to read because there is no more
potential for two parts of the code stepping on each others' toes
modifying the dummy variable.

These things are important to me because modifying the dummy variable
is a sure way to introduce really hard to find errors if anyone ever
wanted to multi-thread this function. It's not likely that anyone
will try this for this function soon, except possibly by using
things like parallel-for loops should they ever become available.
But it's worth not even getting into the habit of using this style.


In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.