]> https://gitweb.dealii.org/ - dealii.git/log
dealii.git
7 years agoIncrease accuracy of output in one test. 3509/head
Wolfgang Bangerth [Wed, 9 Nov 2016 00:26:04 +0000 (17:26 -0700)]
Increase accuracy of output in one test.

This test outputs numbers such as 1/8=0.125 with just two digits after the decimal
point. Consequently, it depends on round-off and optimization flags if we get 0.12
or 0.13. Because the difference is so large, numdiff reports this as a failure.

Fix this by increasing the accuracy to 3 digits.

7 years agoMerge pull request #3506 from drwells/add-missing-instantiation
Wolfgang Bangerth [Tue, 8 Nov 2016 20:47:32 +0000 (13:47 -0700)]
Merge pull request #3506 from drwells/add-missing-instantiation

Add a missing template instantiation.

7 years agoAdd a missing template instantiation. 3506/head
David Wells [Tue, 8 Nov 2016 19:14:32 +0000 (14:14 -0500)]
Add a missing template instantiation.

7 years agoMerge pull request #3504 from bangerth/remove-dead-code
Timo Heister [Tue, 8 Nov 2016 16:26:09 +0000 (11:26 -0500)]
Merge pull request #3504 from bangerth/remove-dead-code

Remove some dead code.

7 years agoRemove some dead code. 3504/head
Wolfgang Bangerth [Tue, 8 Nov 2016 02:16:10 +0000 (19:16 -0700)]
Remove some dead code.

As the assertion at the top of the patch shows, 'starting_indices' must only have values
between 0 and N (=sparsity.n_rows()). Consequently, the loop that replaces out-of-bounds
values with numbers::invalid_size_type should never trigger. Further, the 'remove_if'
will also never do anything, and the fact that we accidentally not actually do anything
with its return value (as one should for 'remove_if') doesn't matter.

7 years agoMerge pull request #3498 from bangerth/initialize-members-8
Martin Kronbichler [Tue, 8 Nov 2016 09:18:43 +0000 (10:18 +0100)]
Merge pull request #3498 from bangerth/initialize-members-8

Initialize member variables.

7 years agoMerge pull request #3503 from bangerth/fix-memory-test
Martin Kronbichler [Tue, 8 Nov 2016 09:18:29 +0000 (10:18 +0100)]
Merge pull request #3503 from bangerth/fix-memory-test

Adjust memory consumption output.

7 years agoMerge pull request #3502 from kronbichler/master
Martin Kronbichler [Tue, 8 Nov 2016 09:18:10 +0000 (10:18 +0100)]
Merge pull request #3502 from kronbichler/master

Fix Chebyshev preconditioner

7 years agoBetter initial guess for Chebyshev vector 3502/head
Martin Kronbichler [Mon, 7 Nov 2016 23:02:56 +0000 (00:02 +0100)]
Better initial guess for Chebyshev vector

7 years agoAdjust memory consumption output. 3503/head
Wolfgang Bangerth [Mon, 7 Nov 2016 23:00:45 +0000 (16:00 -0700)]
Adjust memory consumption output.

7 years agoAdd missing include file
Martin Kronbichler [Mon, 7 Nov 2016 22:56:15 +0000 (23:56 +0100)]
Add missing include file

7 years agoMerge pull request #3499 from kronbichler/remove_memory_consumption_test
Wolfgang Bangerth [Mon, 7 Nov 2016 22:15:36 +0000 (15:15 -0700)]
Merge pull request #3499 from kronbichler/remove_memory_consumption_test

Remove alternative for memory consumption

7 years agoRemove alternative for memory consumption that does not seem necessary any more 3499/head
Martin Kronbichler [Mon, 7 Nov 2016 22:05:41 +0000 (23:05 +0100)]
Remove alternative for memory consumption that does not seem necessary any more

7 years agoMerge pull request #3493 from bangerth/provide-copy-op
Daniel Arndt [Mon, 7 Nov 2016 22:03:53 +0000 (23:03 +0100)]
Merge pull request #3493 from bangerth/provide-copy-op

Provide a copy operator.

7 years agoMerge pull request #3483 from masterleinad/ignore_subdomain
Daniel Arndt [Mon, 7 Nov 2016 22:02:36 +0000 (23:02 +0100)]
Merge pull request #3483 from masterleinad/ignore_subdomain

Ignore subdomain_id in MatrixFree::resolve_cell

7 years agoInitialize member variables. 3498/head
Wolfgang Bangerth [Mon, 7 Nov 2016 21:30:22 +0000 (14:30 -0700)]
Initialize member variables.

Also rename one to match current coding practices. Add to the
variable's documentation.

7 years agoMerge pull request #3489 from kronbichler/remove_warning_parallel_block_vector
Wolfgang Bangerth [Mon, 7 Nov 2016 21:09:16 +0000 (14:09 -0700)]
Merge pull request #3489 from kronbichler/remove_warning_parallel_block_vector

Correct LinearAlgebra::distributed::BlockVector::memory_consumption()

7 years agoAdd test 3489/head
Martin Kronbichler [Mon, 7 Nov 2016 21:04:38 +0000 (22:04 +0100)]
Add test

7 years agoCorrect LinearAlgebra::distributed::BlockVector::memory_consumption()
Martin Kronbichler [Mon, 7 Nov 2016 11:48:37 +0000 (12:48 +0100)]
Correct LinearAlgebra::distributed::BlockVector::memory_consumption()

7 years agoMerge pull request #3492 from bangerth/initialize-members-6
David Wells [Mon, 7 Nov 2016 20:47:42 +0000 (15:47 -0500)]
Merge pull request #3492 from bangerth/initialize-members-6

Initialize all member variables.

7 years agoMerge pull request #3497 from bangerth/fix-previous-commit
Denis Davydov [Mon, 7 Nov 2016 20:41:57 +0000 (21:41 +0100)]
Merge pull request #3497 from bangerth/fix-previous-commit

Fix indexing in a previous commit.

7 years agoFix indexing in a previous commit. 3497/head
Wolfgang Bangerth [Mon, 7 Nov 2016 20:37:56 +0000 (13:37 -0700)]
Fix indexing in a previous commit.

7 years agoMerge pull request #3496 from bangerth/initialize-members-7
Martin Kronbichler [Mon, 7 Nov 2016 20:33:43 +0000 (21:33 +0100)]
Merge pull request #3496 from bangerth/initialize-members-7

Initialize member variables in class ExceptionBase.

7 years agoInitialize member variables in class ExceptionBase. 3496/head
Wolfgang Bangerth [Mon, 7 Nov 2016 20:28:51 +0000 (13:28 -0700)]
Initialize member variables in class ExceptionBase.

7 years agoMerge pull request #3491 from bangerth/initialize-members-5
David Wells [Mon, 7 Nov 2016 20:12:29 +0000 (15:12 -0500)]
Merge pull request #3491 from bangerth/initialize-members-5

Initialize all member variables.

7 years agoMerge pull request #3494 from bangerth/fix-thread_management
David Wells [Mon, 7 Nov 2016 20:08:44 +0000 (15:08 -0500)]
Merge pull request #3494 from bangerth/fix-thread_management

Provide copy operator and initialize member variables.

7 years agoMerge pull request #3495 from bangerth/fix-readme
David Wells [Mon, 7 Nov 2016 20:07:20 +0000 (15:07 -0500)]
Merge pull request #3495 from bangerth/fix-readme

Add periods in a couple of places in the README.

7 years agoAdd periods in a couple of places in the README. 3495/head
Wolfgang Bangerth [Mon, 7 Nov 2016 18:25:11 +0000 (11:25 -0700)]
Add periods in a couple of places in the README.

7 years agoProvide copy operator and initialize member variables. 3494/head
Wolfgang Bangerth [Mon, 7 Nov 2016 17:33:14 +0000 (10:33 -0700)]
Provide copy operator and initialize member variables.

7 years agoIgnore subdomain_id in MatrixFree::resolve_cell 3483/head
Daniel Arndt [Sun, 6 Nov 2016 23:47:14 +0000 (00:47 +0100)]
Ignore subdomain_id in MatrixFree::resolve_cell

7 years agoProvide a copy operator. 3493/head
Wolfgang Bangerth [Mon, 7 Nov 2016 16:58:35 +0000 (09:58 -0700)]
Provide a copy operator.

Also initialize all member variables.

7 years agoInitialize all member variables. 3492/head
Wolfgang Bangerth [Mon, 7 Nov 2016 16:57:22 +0000 (09:57 -0700)]
Initialize all member variables.

7 years agoInitialize all member variables. 3491/head
Wolfgang Bangerth [Mon, 7 Nov 2016 16:54:42 +0000 (09:54 -0700)]
Initialize all member variables.

7 years agoMerge pull request #3487 from kronbichler/remove_warning_matrix_free
Wolfgang Bangerth [Mon, 7 Nov 2016 16:06:13 +0000 (09:06 -0700)]
Merge pull request #3487 from kronbichler/remove_warning_matrix_free

Fix warning in MatrixFree

7 years agoMerge pull request #3488 from kronbichler/remove_warning_shape_info
Wolfgang Bangerth [Mon, 7 Nov 2016 16:05:56 +0000 (09:05 -0700)]
Merge pull request #3488 from kronbichler/remove_warning_shape_info

Initialize all variables in MatrixFreeFunctions::ShapeInfo

7 years agoMerge pull request #3486 from kronbichler/remove_warning_fe_eval
Wolfgang Bangerth [Mon, 7 Nov 2016 16:00:35 +0000 (09:00 -0700)]
Merge pull request #3486 from kronbichler/remove_warning_fe_eval

Avoid warning about missing copy constructor

7 years agoInitialize all variables in MatrixFreeFunctions::ShapeInfo 3488/head
Martin Kronbichler [Mon, 7 Nov 2016 11:41:25 +0000 (12:41 +0100)]
Initialize all variables in MatrixFreeFunctions::ShapeInfo

7 years agoTest copy constructor 3486/head
Martin Kronbichler [Mon, 7 Nov 2016 11:16:26 +0000 (12:16 +0100)]
Test copy constructor

7 years agoAvoid warning about missing copy constructor
Martin Kronbichler [Mon, 7 Nov 2016 10:52:20 +0000 (11:52 +0100)]
Avoid warning about missing copy constructor

7 years agoFix warning in MatrixFree 3487/head
Martin Kronbichler [Mon, 7 Nov 2016 11:11:06 +0000 (12:11 +0100)]
Fix warning in MatrixFree

7 years agoMerge pull request #3485 from bangerth/remove-duplicate-variable
Denis Davydov [Mon, 7 Nov 2016 06:24:12 +0000 (07:24 +0100)]
Merge pull request #3485 from bangerth/remove-duplicate-variable

Remove the FE_DGPNonparametric::degree variable.

7 years agoRemove the FE_DGPNonparametric::degree variable. 3485/head
Wolfgang Bangerth [Mon, 7 Nov 2016 06:20:51 +0000 (23:20 -0700)]
Remove the FE_DGPNonparametric::degree variable.

It shadows the variable of same name in the base class, and always has the
same value.

7 years agoMerge pull request #3476 from kronbichler/matrix_free_improvements
Denis Davydov [Mon, 7 Nov 2016 05:11:36 +0000 (06:11 +0100)]
Merge pull request #3476 from kronbichler/matrix_free_improvements

Matrix-free operator cleanup

7 years agoInitialize variables 3476/head
Martin Kronbichler [Sun, 6 Nov 2016 19:52:57 +0000 (20:52 +0100)]
Initialize variables

7 years agoMerge pull request #3481 from drwells/pvs-block-vector-iterator
Martin Kronbichler [Sun, 6 Nov 2016 16:07:39 +0000 (17:07 +0100)]
Merge pull request #3481 from drwells/pvs-block-vector-iterator

Clarify the signature of a copy constructor.

7 years agoMerge pull request #3480 from drwells/pvs-block-matrix-array-entry
Martin Kronbichler [Sun, 6 Nov 2016 16:07:14 +0000 (17:07 +0100)]
Merge pull request #3480 from drwells/pvs-block-matrix-array-entry

Add (private) BlockMatrixArray::Entry::operator=.

7 years agoRequire Trilinos for test
Martin Kronbichler [Sun, 6 Nov 2016 16:05:19 +0000 (17:05 +0100)]
Require Trilinos for test

7 years agoMake DiagonalMatrix member of MFOps::Base a shared_ptr
Martin Kronbichler [Sat, 5 Nov 2016 21:24:17 +0000 (22:24 +0100)]
Make DiagonalMatrix member of MFOps::Base a shared_ptr

7 years agoLet MatrixFreeOperators::Base fix the ghost part of a vector
Martin Kronbichler [Mon, 31 Oct 2016 19:48:09 +0000 (20:48 +0100)]
Let MatrixFreeOperators::Base fix the ghost part of a vector

7 years agoAvoid warnings about deprecated class
Martin Kronbichler [Mon, 31 Oct 2016 19:47:22 +0000 (20:47 +0100)]
Avoid warnings about deprecated class

7 years agoAvoid using deprecated functions in initialization
Martin Kronbichler [Mon, 31 Oct 2016 19:46:45 +0000 (20:46 +0100)]
Avoid using deprecated functions in initialization

7 years agoInsert option for using Chebyshev as solver
Martin Kronbichler [Mon, 31 Oct 2016 19:45:58 +0000 (20:45 +0100)]
Insert option for using Chebyshev as solver

7 years agoClarify the signature of a copy constructor. 3481/head
David Wells [Sun, 6 Nov 2016 13:47:17 +0000 (08:47 -0500)]
Clarify the signature of a copy constructor.

PVS studio claims that we do not implement a copy constructor for this
iterator. It is likely that (unnecessarily) including the template
arguments here confused PVS studio, so remove them.

7 years agoAdd (private) BlockMatrixArray::Entry::operator=. 3480/head
David Wells [Sun, 6 Nov 2016 12:46:52 +0000 (07:46 -0500)]
Add (private) BlockMatrixArray::Entry::operator=.

This class implements a (destructive) copy constructor more or less so
that one can use it with std::vector::push_back, so it should disable
operator=.

This fixes a warning caught by PVS studio.

7 years agoMerge pull request #3479 from bangerth/clarify-variable-name
Denis Davydov [Sun, 6 Nov 2016 05:32:57 +0000 (06:32 +0100)]
Merge pull request #3479 from bangerth/clarify-variable-name

Use 'order' instead of 'degree' in FE_RannacherTurek.

7 years agoMerge pull request #3478 from bangerth/initialize-variables-5
Denis Davydov [Sun, 6 Nov 2016 05:31:29 +0000 (06:31 +0100)]
Merge pull request #3478 from bangerth/initialize-variables-5

Initialize members of IndexSet::Range.

7 years agoMerge pull request #3477 from bangerth/add-Exception-copy-constructor
Denis Davydov [Sun, 6 Nov 2016 05:31:04 +0000 (06:31 +0100)]
Merge pull request #3477 from bangerth/add-Exception-copy-constructor

Add a (disabled) copy operator to ExceptionBase.

7 years agoUse 'order' instead of 'degree' in FE_RannacherTurek. 3479/head
Wolfgang Bangerth [Sun, 6 Nov 2016 03:35:26 +0000 (21:35 -0600)]
Use 'order' instead of 'degree' in FE_RannacherTurek.

The existing 'degree' member variable shadows a member of the base class,
but worse it does not have the same semantics: the former pertains to the
order of the element, the latter to the polynomial degree. Fix this.

7 years agoInitialize members of IndexSet::Range. 3478/head
Wolfgang Bangerth [Sun, 6 Nov 2016 02:50:01 +0000 (20:50 -0600)]
Initialize members of IndexSet::Range.

7 years agoMerge pull request #3451 from bangerth/fix-scopes
David Wells [Sun, 6 Nov 2016 02:12:49 +0000 (22:12 -0400)]
Merge pull request #3451 from bangerth/fix-scopes

Fix the scopes of variables.

7 years agoAdd a (disabled) copy operator to ExceptionBase. 3477/head
Wolfgang Bangerth [Sun, 6 Nov 2016 01:57:59 +0000 (19:57 -0600)]
Add a (disabled) copy operator to ExceptionBase.

7 years agoMerge pull request #3475 from drwells/gcc4-fix
David Wells [Sun, 6 Nov 2016 01:03:35 +0000 (21:03 -0400)]
Merge pull request #3475 from drwells/gcc4-fix

Fix compilation with some matrix free tests.

7 years agoFix the scopes of variables. 3451/head
Wolfgang Bangerth [Fri, 4 Nov 2016 13:16:02 +0000 (07:16 -0600)]
Fix the scopes of variables.

The current version has variables in outer scopes that are assigned the addresses
of local variables in inner scopes. These addresses are not actually used in the
outer scope after we leave the inner scope, but it's a bad idea anyway. Move
the declaration of the pointers to the inner scopes where they are actually
used.

7 years agoFix compilation with some matrix free tests. 3475/head
David Wells [Sat, 5 Nov 2016 19:33:30 +0000 (15:33 -0400)]
Fix compilation with some matrix free tests.

This fixes a compilation error with GCC 4.8:

error: no match for ‘operator=’
(operand types are ‘boost::shared_ptr<dealii::Table<2, dealii::VectorizedArray<double> > >’ and ‘long int’)

      scalar_coefficient = NULL;
                         ^

7 years agoMerge pull request #3473 from drwells/pvs-precondition-block
Martin Kronbichler [Sat, 5 Nov 2016 19:14:00 +0000 (20:14 +0100)]
Merge pull request #3473 from drwells/pvs-precondition-block

Pvs precondition block

7 years agoMerge pull request #3474 from kronbichler/master
David Wells [Sat, 5 Nov 2016 17:56:26 +0000 (13:56 -0400)]
Merge pull request #3474 from kronbichler/master

Return vector partitioner by reference

7 years agoUse different names for function arguments. 3473/head
David Wells [Sat, 5 Nov 2016 14:16:45 +0000 (10:16 -0400)]
Use different names for function arguments.

PreconditionBlock already has two members named 'permutation' and
'inverse_permutation' so this makes things a bit clearer.

I applied the same naming scheme to a separate function where previously
the variables were called 'p' and 'i'.

7 years agoMerge pull request #3454 from masterleinad/address_3427
Daniel Arndt [Sat, 5 Nov 2016 17:22:36 +0000 (18:22 +0100)]
Merge pull request #3454 from masterleinad/address_3427

Make casts explicit, initialize all variables

7 years agoReturn vector partitioner by reference 3474/head
Martin Kronbichler [Sat, 5 Nov 2016 16:40:01 +0000 (17:40 +0100)]
Return vector partitioner by reference

7 years agoInitialize a member variable of PreconditionBlock.
David Wells [Sat, 5 Nov 2016 14:15:30 +0000 (10:15 -0400)]
Initialize a member variable of PreconditionBlock.

This is the default value used by the AdditionalData struct.

7 years agoMerge pull request #3472 from bangerth/rename-variables-2
Martin Kronbichler [Sat, 5 Nov 2016 15:35:11 +0000 (16:35 +0100)]
Merge pull request #3472 from bangerth/rename-variables-2

Rename a few local variables to avoid ambiguity with member variables.

7 years agoMerge pull request #3471 from bangerth/initialize-variables
David Wells [Sat, 5 Nov 2016 15:33:27 +0000 (11:33 -0400)]
Merge pull request #3471 from bangerth/initialize-variables

Initialize member variables.

7 years agoRemove unused method arguments.
David Wells [Sat, 5 Nov 2016 14:14:31 +0000 (10:14 -0400)]
Remove unused method arguments.

This is a protected method which is always called with two member
variables with identical names as the function arguments.

This was caught by PVS studio.

7 years agoRename a few local variables to avoid ambiguity with member variables. 3472/head
Wolfgang Bangerth [Sat, 5 Nov 2016 13:49:11 +0000 (07:49 -0600)]
Rename a few local variables to avoid ambiguity with member variables.

The `MGLevelGlobalTransfer` class has member variables `copy_indices_*` but in the
`fill_and_communicate_copy_indices()` member function also allocates local variables
of the same name. Rename these to make the distinction clearer.

While there, also initialize a few member variables in the constructor of a local
class.

7 years agoInitialize member variables. 3471/head
Wolfgang Bangerth [Sat, 5 Nov 2016 13:21:42 +0000 (07:21 -0600)]
Initialize member variables.

7 years agoMerge pull request #3469 from drwells/pvs-dof-info-initialize
Martin Kronbichler [Sat, 5 Nov 2016 12:23:51 +0000 (13:23 +0100)]
Merge pull request #3469 from drwells/pvs-dof-info-initialize

Initialize two DoFInfo fields.

7 years agoMerge pull request #3456 from drwells/pvs-sparsity-repeated-expression
Wolfgang Bangerth [Sat, 5 Nov 2016 03:56:41 +0000 (21:56 -0600)]
Merge pull request #3456 from drwells/pvs-sparsity-repeated-expression

Remove some repeated subexpressions.

7 years agoMerge pull request #3468 from drwells/pvs-integration-info-initialize
Wolfgang Bangerth [Sat, 5 Nov 2016 03:55:35 +0000 (21:55 -0600)]
Merge pull request #3468 from drwells/pvs-integration-info-initialize

Initialize an IntegrationInfo field.

7 years agoInitialize two DoFInfo fields. 3469/head
David Wells [Sat, 5 Nov 2016 02:46:45 +0000 (22:46 -0400)]
Initialize two DoFInfo fields.

These are the same values used in the reinit function.

7 years agoInitialize an IntegrationInfo field. 3468/head
David Wells [Sat, 5 Nov 2016 02:24:39 +0000 (22:24 -0400)]
Initialize an IntegrationInfo field.

This number is correctly filled by IntegrationInfo::initialize, but this
way it starts out with a bogus value (instead of an undefined one).

7 years agoMerge pull request #3462 from bangerth/rename-variables-2
David Wells [Sat, 5 Nov 2016 02:11:06 +0000 (22:11 -0400)]
Merge pull request #3462 from bangerth/rename-variables-2

Rename some variables.

7 years agoMerge pull request #3463 from bangerth/rename-variables-3
David Wells [Sat, 5 Nov 2016 01:40:58 +0000 (21:40 -0400)]
Merge pull request #3463 from bangerth/rename-variables-3

Rename some variables.

7 years agoMerge pull request #3464 from bangerth/rename-functions-and-variables
David Wells [Sat, 5 Nov 2016 00:43:58 +0000 (20:43 -0400)]
Merge pull request #3464 from bangerth/rename-functions-and-variables

Rename local variables with names equal to members of the base class.

7 years agoMerge pull request #3465 from bangerth/clarify-code
David Wells [Fri, 4 Nov 2016 23:58:32 +0000 (19:58 -0400)]
Merge pull request #3465 from bangerth/clarify-code

Clarify the intent of a piece of code.

7 years agoMerge pull request #3466 from bangerth/initialize-variable-5
David Wells [Fri, 4 Nov 2016 23:21:07 +0000 (19:21 -0400)]
Merge pull request #3466 from bangerth/initialize-variable-5

Initialize a member variable of LogStream.

7 years agoRemove a repeated subexpression. 3456/head
David Wells [Fri, 4 Nov 2016 22:46:14 +0000 (18:46 -0400)]
Remove a repeated subexpression.

This was caught by PVS studio.

7 years agoPrefer SparsityPattern::empty() to ad hoc checks.
David Wells [Fri, 4 Nov 2016 22:44:49 +0000 (18:44 -0400)]
Prefer SparsityPattern::empty() to ad hoc checks.

7 years agoMerge pull request #3467 from bangerth/initialize-variable-6
Martin Kronbichler [Fri, 4 Nov 2016 22:25:06 +0000 (23:25 +0100)]
Merge pull request #3467 from bangerth/initialize-variable-6

Initialize member variables.

7 years agoMerge pull request #3459 from bangerth/rename-arguments
David Wells [Fri, 4 Nov 2016 22:24:03 +0000 (18:24 -0400)]
Merge pull request #3459 from bangerth/rename-arguments

Rename function arguments.

7 years agoMerge pull request #3458 from bangerth/rename-variables
David Wells [Fri, 4 Nov 2016 22:13:41 +0000 (18:13 -0400)]
Merge pull request #3458 from bangerth/rename-variables

Rename some variables.

7 years agoInitialize member variables. 3467/head
Wolfgang Bangerth [Fri, 4 Nov 2016 20:38:24 +0000 (14:38 -0600)]
Initialize member variables.

7 years agoInitialize a member variable of LogStream. 3466/head
Wolfgang Bangerth [Fri, 4 Nov 2016 20:35:12 +0000 (14:35 -0600)]
Initialize a member variable of LogStream.

The variable really was never initialized, even though some
output depended on it. I suspect that it just happened to always
be initialized to 'false'. Make this explicit.

7 years agoClarify the intent of a piece of code. 3465/head
Wolfgang Bangerth [Fri, 4 Nov 2016 20:31:09 +0000 (14:31 -0600)]
Clarify the intent of a piece of code.

The code uses integer division, followed by a double precision multiplication.
It is admittedly not immediately obvious what it is supposed to do. Clarify
that we really mean the integer division.

7 years agoRename local variables with names equal to members of the base class. 3464/head
Wolfgang Bangerth [Fri, 4 Nov 2016 20:22:25 +0000 (14:22 -0600)]
Rename local variables with names equal to members of the base class.

This is certainly confusing.

While there, notice that the functions that *compute* quadrature points
and weights are called 'set_*', but are 'const'. That makes no sense.
In fact, they just compute and return these values, so call them
'get_*' instead.

7 years agoRename some variables. 3463/head
Wolfgang Bangerth [Fri, 4 Nov 2016 20:16:13 +0000 (14:16 -0600)]
Rename some variables.

There are variables of the same name in the base class. Avoid the
confusion of having similarly named variables in the local scope.

7 years agoRename some variables. 3462/head
Wolfgang Bangerth [Fri, 4 Nov 2016 20:14:13 +0000 (14:14 -0600)]
Rename some variables.

There are variables of the same name in the base class. Avoid the
confusion of having similarly named variables in the local scope.

7 years agoMerge pull request #3450 from bangerth/fix-warning
Matthias Maier [Fri, 4 Nov 2016 18:44:42 +0000 (13:44 -0500)]
Merge pull request #3450 from bangerth/fix-warning

No need for double parentheses.

7 years agoMerge pull request #3446 from bangerth/fix-DataOutRotation-build_one_patch
Matthias Maier [Fri, 4 Nov 2016 18:44:28 +0000 (13:44 -0500)]
Merge pull request #3446 from bangerth/fix-DataOutRotation-build_one_patch

Rename a function argument.

7 years agoMerge pull request #3453 from bangerth/initialize-variables-4
Matthias Maier [Fri, 4 Nov 2016 18:43:24 +0000 (13:43 -0500)]
Merge pull request #3453 from bangerth/initialize-variables-4

Initialize member variables.

7 years agoMerge pull request #3338 from kalj/check-for-compute-capability
Matthias Maier [Fri, 4 Nov 2016 18:41:03 +0000 (13:41 -0500)]
Merge pull request #3338 from kalj/check-for-compute-capability

Check for compute capability


In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.