]> https://gitweb.dealii.org/ - dealii.git/log
dealii.git
17 months agoremove redundant else branch 15673/head
Matthias Maier [Fri, 7 Jul 2023 00:10:16 +0000 (19:10 -0500)]
remove redundant else branch

17 months agomatrix_free/fe_evaluation.h: avoid a warning with g++-13
Matthias Maier [Thu, 6 Jul 2023 22:16:06 +0000 (17:16 -0500)]
matrix_free/fe_evaluation.h: avoid a warning with g++-13

g++-13 is a bit too eager to warn about an array bounds violation here
after its optimizer pass introduced a `__builtin_memset()`:
```
In file included from include/deal.II/matrix_free/operators.h:30,
                 from include/deal.II/numerics/vector_tools_project.templates.h:36,
                 from source/numerics/vector_tools_project_qpmf.cc:17:
                 In member function ‘void dealii::FEEvaluationBase<...>:
                 inlined from ‘void dealii::FEEvaluationBase<...>:
include/deal.II/matrix_free/fe_evaluation.h:3937:20: warning: ‘void* __builtin_memset(void*, int, long unsigned int)’ offset [20, 1020] is out of the bounds [0, 16] of object ‘dof_indices’ with type ‘std::array<unsigned int, 4>’ [-Warray-bounds=]
 3937 |     dof_indices[v] = numbers::invalid_unsigned_int;
      |     ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
which is a bit silly as the statement reads:
```
// implied Assert(n_filled_lanes <= n_lanes, ExcInternalError());
for (unsigned int v = n_filled_lanes; v < n_lanes; ++v)
  dof_indices[v] = numbers::invalid_unsigned_int;
```
So instead let's simply initialize all elements of `dof_indices` to
`numbers::invalid_unsigned_int` via `std::fill` instead. I doubt that
this has much performance influence in practice as it gets replaced by a
`__builtin_memset()` right away.

17 months agoMerge pull request #15670 from tamiko/udpate_tester_names
Matthias Maier [Thu, 6 Jul 2023 19:34:39 +0000 (19:34 +0000)]
Merge pull request #15670 from tamiko/udpate_tester_names

Tests: update official tester names

17 months agoTests: update official tester names 15670/head
Matthias Maier [Thu, 6 Jul 2023 17:14:23 +0000 (12:14 -0500)]
Tests: update official tester names

17 months agoMerge pull request #15084 from luca-heltai/map_boundary_to_bulk_dof_iterators
Matthias Maier [Thu, 6 Jul 2023 14:36:57 +0000 (14:36 +0000)]
Merge pull request #15084 from luca-heltai/map_boundary_to_bulk_dof_iterators

Map boundary to bulk dof iterators.

17 months agoMerge pull request #15622 from bangerth/vsv-cuda
Daniel Arndt [Thu, 6 Jul 2023 03:11:26 +0000 (23:11 -0400)]
Merge pull request #15622 from bangerth/vsv-cuda

Get rid of VectorSpaceVector in the Cuda Vector class.

17 months agoMerge pull request #15664 from drwells/fix-epetra-concept
Wolfgang Bangerth [Thu, 6 Jul 2023 01:51:33 +0000 (19:51 -0600)]
Merge pull request #15664 from drwells/fix-epetra-concept

Add a missing typedef to the epetra vector wrapper.

17 months agoAdd a missing typedef to the epetra vector wrapper. 15664/head
David Wells [Thu, 6 Jul 2023 00:13:33 +0000 (20:13 -0400)]
Add a missing typedef to the epetra vector wrapper.

We need this to satisfy the vector space vector concept.

17 months agoAddress review comments. 15084/head
Luca Heltai [Wed, 5 Jul 2023 20:17:14 +0000 (22:17 +0200)]
Address review comments.

17 months agoMerge pull request #15660 from masterleinad/fix_comparison_g++-13_c++20
David Wells [Wed, 5 Jul 2023 20:01:39 +0000 (16:01 -0400)]
Merge pull request #15660 from masterleinad/fix_comparison_g++-13_c++20

Fix some comparisons operator for g++-13 with C++20

17 months agoGet rid of VectorSpaceVector in the Cuda Vector class. 15622/head
Wolfgang Bangerth [Mon, 3 Jul 2023 16:56:02 +0000 (10:56 -0600)]
Get rid of VectorSpaceVector in the Cuda Vector class.

17 months agoFix some comparisons operator for g++-13 with C++20 15660/head
Daniel Arndt [Wed, 5 Jul 2023 15:33:41 +0000 (11:33 -0400)]
Fix some comparisons operator for g++-13 with C++20

17 months agoMerge pull request #15657 from kronbichler/fix_step-46
Daniel Arndt [Wed, 5 Jul 2023 15:01:09 +0000 (11:01 -0400)]
Merge pull request #15657 from kronbichler/fix_step-46

17 months agoMerge pull request #15658 from mschreter/fix_header_read_vector
Daniel Arndt [Wed, 5 Jul 2023 14:21:42 +0000 (10:21 -0400)]
Merge pull request #15658 from mschreter/fix_header_read_vector

17 months agoadd missing ReadVector header 15658/head
Magdalena Schreter [Wed, 5 Jul 2023 10:08:21 +0000 (12:08 +0200)]
add missing ReadVector header

17 months agoMerge pull request #15623 from bangerth/vsv-trilinos-epetra
Martin Kronbichler [Wed, 5 Jul 2023 07:43:15 +0000 (09:43 +0200)]
Merge pull request #15623 from bangerth/vsv-trilinos-epetra

Get rid of VectorSpaceVector in the LinearAlgebra::EpetraWrappers::Vector class.

17 months agoFix step-46 tutorial program 15657/head
Martin Kronbichler [Wed, 5 Jul 2023 07:39:38 +0000 (09:39 +0200)]
Fix step-46 tutorial program

17 months agoMerge pull request #15633 from bangerth/vsv-la-block-vector
Martin Kronbichler [Wed, 5 Jul 2023 07:34:42 +0000 (09:34 +0200)]
Merge pull request #15633 from bangerth/vsv-la-block-vector

Get rid of VectorSpaceVector in the LinearAlgebra::distributed::BlockVector class.

17 months agoMerge pull request #15656 from tamiko/fix_tests_2
Matthias Maier [Wed, 5 Jul 2023 04:51:54 +0000 (04:51 +0000)]
Merge pull request #15656 from tamiko/fix_tests_2

Tests: grid/mesh_3d.h: add forgotten GridTests::reorder* call

17 months agoMerge pull request #15626 from drwells/remove-la-vector
David Wells [Wed, 5 Jul 2023 03:53:49 +0000 (23:53 -0400)]
Merge pull request #15626 from drwells/remove-la-vector

Remove LA::Vector.

17 months agoTests: grid/mesh_3d.h: add forgotten GridTests::reorder* call 15656/head
Matthias Maier [Wed, 5 Jul 2023 02:25:26 +0000 (21:25 -0500)]
Tests: grid/mesh_3d.h: add forgotten GridTests::reorder* call

17 months agoMerge pull request #15654 from tamiko/fix_tests
Matthias Maier [Wed, 5 Jul 2023 02:28:31 +0000 (02:28 +0000)]
Merge pull request #15654 from tamiko/fix_tests

Tests: add forgotten namespace, fix typo in includes

17 months agoChange argument to reference to avoid unnecessary copies. 15623/head
Wolfgang Bangerth [Wed, 5 Jul 2023 00:16:31 +0000 (18:16 -0600)]
Change argument to reference to avoid unnecessary copies.

17 months agoChange argument to reference to avoid unnecessary copies. 15633/head
Wolfgang Bangerth [Wed, 5 Jul 2023 00:13:26 +0000 (18:13 -0600)]
Change argument to reference to avoid unnecessary copies.

17 months agoTests: add forgotten namespace, fix typo in includes 15654/head
Matthias Maier [Tue, 4 Jul 2023 22:42:00 +0000 (17:42 -0500)]
Tests: add forgotten namespace, fix typo in includes

17 months agoMerge pull request #15651 from tamiko/be_more_craceful
Matthias Maier [Tue, 4 Jul 2023 22:23:48 +0000 (22:23 +0000)]
Merge pull request #15651 from tamiko/be_more_craceful

Tests: if no numdiff executable is found fall back to running tests instead of dropping them

17 months agoMerge pull request #15644 from tamiko/enable_example_tests
Matthias Maier [Tue, 4 Jul 2023 21:51:56 +0000 (21:51 +0000)]
Merge pull request #15644 from tamiko/enable_example_tests

Quick tests: also run examples/ tests

17 months agoTests: set expected stage to »PASSED« when not comparing output and expect=DIFF 15651/head
Matthias Maier [Tue, 4 Jul 2023 20:45:48 +0000 (15:45 -0500)]
Tests: set expected stage to »PASSED« when not comparing output and expect=DIFF

17 months agoTests: if no numdiff executable is found fall back to running tests instead of dropping
Matthias Maier [Tue, 4 Jul 2023 20:34:08 +0000 (15:34 -0500)]
Tests: if no numdiff executable is found fall back to running tests instead of dropping

17 months agoQuick tests: if configured also run examples/ tests 15644/head
Matthias Maier [Tue, 4 Jul 2023 15:15:45 +0000 (10:15 -0500)]
Quick tests: if configured also run examples/ tests

17 months agoQuick tests: now that we have interactive output run debug and release variants
Matthias Maier [Tue, 4 Jul 2023 15:08:59 +0000 (10:08 -0500)]
Quick tests: now that we have interactive output run debug and release variants

17 months agoQuick tests: update error message
Matthias Maier [Tue, 4 Jul 2023 14:35:09 +0000 (09:35 -0500)]
Quick tests: update error message

17 months agoQuick tests: make quick test output more responsive
Matthias Maier [Tue, 4 Jul 2023 14:25:49 +0000 (09:25 -0500)]
Quick tests: make quick test output more responsive

17 months agoQuick tests: also populate the test target when configuring tests directly
Matthias Maier [Tue, 4 Jul 2023 14:06:12 +0000 (09:06 -0500)]
Quick tests: also populate the test target when configuring tests directly

17 months agoRemove LA::Vector. 15626/head
David Wells [Mon, 3 Jul 2023 15:13:50 +0000 (11:13 -0400)]
Remove LA::Vector.

We agreed to convert VectorSpaceVector a concept which makes this approach no
longer relevant.

17 months agoMerge pull request #11066 from bangerth/fesys
Matthias Maier [Tue, 4 Jul 2023 19:04:32 +0000 (19:04 +0000)]
Merge pull request #11066 from bangerth/fesys

Use operator^ to create FESystem objects in the tutorials.

17 months agoMerge pull request #15445 from tamiko/fix_use_after_scope
Matthias Maier [Tue, 4 Jul 2023 19:02:18 +0000 (19:02 +0000)]
Merge pull request #15445 from tamiko/fix_use_after_scope

TriaIterator: return a proper Accessor temporary

17 months agoMerge pull request #15635 from bergbauer/n_lanes
Matthias Maier [Tue, 4 Jul 2023 19:00:46 +0000 (19:00 +0000)]
Merge pull request #15635 from bergbauer/n_lanes

FEEvaluation: Use n_lanes class variable

17 months agoMerge pull request #15636 from tamiko/silence_a_warning
Matthias Maier [Tue, 4 Jul 2023 19:00:20 +0000 (19:00 +0000)]
Merge pull request #15636 from tamiko/silence_a_warning

base/exceptions.h: avoid warnings in Trilinos / Kokkos headers

17 months agoMerge pull request #15637 from bangerth/vsv-concept
Matthias Maier [Tue, 4 Jul 2023 19:00:07 +0000 (19:00 +0000)]
Merge pull request #15637 from bangerth/vsv-concept

Create a vector space vector concept.

17 months agoMerge pull request #15639 from bangerth/affine-constraints-9
Matthias Maier [Tue, 4 Jul 2023 18:59:44 +0000 (18:59 +0000)]
Merge pull request #15639 from bangerth/affine-constraints-9

Remove a funny exit path in AffineConstraints::close().

17 months agoMerge pull request #15640 from bangerth/brace
Matthias Maier [Tue, 4 Jul 2023 18:58:47 +0000 (18:58 +0000)]
Merge pull request #15640 from bangerth/brace

Use balanced braces for doxygen formulas.

17 months agoMerge pull request #15642 from tamiko/fix_test_33
Matthias Maier [Tue, 4 Jul 2023 18:58:01 +0000 (18:58 +0000)]
Merge pull request #15642 from tamiko/fix_test_33

Test fe/fe_enriched_step-36: make a test less expensive

17 months agoMerge pull request #15645 from lethe-cfd/step68_point_eval
Matthias Maier [Tue, 4 Jul 2023 18:57:34 +0000 (18:57 +0000)]
Merge pull request #15645 from lethe-cfd/step68_point_eval

Change step-68 + timing_step-68 to use FEPointEvaluator

17 months agoMerge pull request #15401 from masterleinad/cppcheck_9_5
Matthias Maier [Tue, 4 Jul 2023 18:44:33 +0000 (18:44 +0000)]
Merge pull request #15401 from masterleinad/cppcheck_9_5

[Post-9.5] Address some cppcheck findings

17 months agoMerge pull request #12080 from bangerth/check-for-directory
Matthias Maier [Tue, 4 Jul 2023 17:44:18 +0000 (17:44 +0000)]
Merge pull request #12080 from bangerth/check-for-directory

[C++17] Check whether the output directory exists.

17 months agoMerge pull request #15608 from peterrum/tria_orientation_
Matthias Maier [Tue, 4 Jul 2023 16:59:59 +0000 (16:59 +0000)]
Merge pull request #15608 from peterrum/tria_orientation_

Introduce tria_orientation.h

17 months agoMerge pull request #15615 from pcafrica/generalize_triangulation_save
Matthias Maier [Tue, 4 Jul 2023 16:59:43 +0000 (16:59 +0000)]
Merge pull request #15615 from pcafrica/generalize_triangulation_save

Move the save and load function to serial tria

17 months agoMerge pull request #15620 from bangerth/micro-opt
Matthias Maier [Tue, 4 Jul 2023 16:59:26 +0000 (16:59 +0000)]
Merge pull request #15620 from bangerth/micro-opt

Micro-optimize a loop.

17 months agoIndent 15645/head
Bruno Blais [Tue, 4 Jul 2023 16:49:27 +0000 (12:49 -0400)]
Indent

17 months agoMerge pull request #15629 from masterleinad/fix_remaining_deprecations
Matthias Maier [Tue, 4 Jul 2023 16:48:43 +0000 (16:48 +0000)]
Merge pull request #15629 from masterleinad/fix_remaining_deprecations

Remove remaining deprecations

17 months agoMerge pull request #15631 from bangerth/vsv-trilinos-tpetra
Matthias Maier [Tue, 4 Jul 2023 16:48:24 +0000 (16:48 +0000)]
Merge pull request #15631 from bangerth/vsv-trilinos-tpetra

Get rid of VectorSpaceVector in the LinearAlgebra::TpetraWrappers::Vector class.

17 months agoModify performance test to use FEPointEvaluator
Bruno Blais [Tue, 4 Jul 2023 16:43:34 +0000 (12:43 -0400)]
Modify performance test to use FEPointEvaluator

17 months agoUpdate step-68 to use FEPointEvaluation
Bruno Blais [Tue, 4 Jul 2023 16:41:19 +0000 (12:41 -0400)]
Update step-68 to use FEPointEvaluation

17 months agoMerge pull request #15621 from tamiko/fix_cmake_caching_03
Matthias Maier [Tue, 4 Jul 2023 13:09:22 +0000 (13:09 +0000)]
Merge pull request #15621 from tamiko/fix_cmake_caching_03

CMake: record git information in a separate configuration file

17 months agoMerge pull request #15561 from bangerth/affine-constraints-6
Matthias Maier [Tue, 4 Jul 2023 13:05:53 +0000 (13:05 +0000)]
Merge pull request #15561 from bangerth/affine-constraints-6

Parallelize some operations in AffineConstraints::close().

17 months agoMerge pull request #15560 from tjhei/test-steps
Matthias Maier [Tue, 4 Jul 2023 13:05:14 +0000 (13:05 +0000)]
Merge pull request #15560 from tjhei/test-steps

Test example steps directly

17 months agoUse n_lanes class variable 15635/head
Maximilian Bergbauer [Mon, 3 Jul 2023 20:53:39 +0000 (22:53 +0200)]
Use n_lanes class variable

17 months agoFix tidy.
Luca Heltai [Thu, 13 Apr 2023 13:25:04 +0000 (16:25 +0300)]
Fix tidy.

17 months agoMap boundary to bulk dof iterators.
Luca Heltai [Wed, 12 Apr 2023 08:15:38 +0000 (11:15 +0300)]
Map boundary to bulk dof iterators.

17 months agoUse operator^ to create FESystem objects in the tutorials. 11066/head
Wolfgang Bangerth [Tue, 20 Oct 2020 19:47:44 +0000 (13:47 -0600)]
Use operator^ to create FESystem objects in the tutorials.

17 months agoCheck whether the output directory exists. 12080/head
Wolfgang Bangerth [Thu, 22 Apr 2021 14:06:58 +0000 (08:06 -0600)]
Check whether the output directory exists.

17 months agoTest fe/fe_enriched_step-36: make a test less expensive 15642/head
Matthias Maier [Tue, 4 Jul 2023 03:57:08 +0000 (22:57 -0500)]
Test fe/fe_enriched_step-36: make a test less expensive

The debug variant of fe/fe_enriched_step-36 takes about 6 minute to
execute with clang and -fsanitize=address. Let's make it a bit less
expensive.

17 months agoMerge pull request #15527 from bergbauer/fix_ecl
Matthias Maier [Tue, 4 Jul 2023 03:19:54 +0000 (03:19 +0000)]
Merge pull request #15527 from bergbauer/fix_ecl

FEFaceEvaluation: Fix ECL for continuous elements

17 months agoUse balanced braces for doxygen formulas. 15640/head
Wolfgang Bangerth [Tue, 4 Jul 2023 02:47:23 +0000 (20:47 -0600)]
Use balanced braces for doxygen formulas.

17 months agoMerge pull request #15632 from bangerth/virtual
Matthias Maier [Tue, 4 Jul 2023 02:27:03 +0000 (02:27 +0000)]
Merge pull request #15632 from bangerth/virtual

Mark a 'virtual' function as such.

17 months agoRemove a funny exit path in AffineConstraints::close(). 15639/head
Wolfgang Bangerth [Tue, 4 Jul 2023 02:26:39 +0000 (20:26 -0600)]
Remove a funny exit path in AffineConstraints::close().

17 months agoFix documentation 15615/head
Pasquale Africa [Mon, 3 Jul 2023 21:45:04 +0000 (21:45 +0000)]
Fix documentation

17 months agoGet rid of VectorSpaceVector in the LinearAlgebra::distributed::BlockVector class.
Wolfgang Bangerth [Mon, 3 Jul 2023 21:11:23 +0000 (15:11 -0600)]
Get rid of VectorSpaceVector in the LinearAlgebra::distributed::BlockVector class.

17 months agoMerge pull request #15618 from bangerth/fold
Marc Fehling [Tue, 4 Jul 2023 01:43:39 +0000 (19:43 -0600)]
Merge pull request #15618 from bangerth/fold

Use C++17-style fold expressions.

17 months agoCheck vector-space-vector concepts for all vector classes. 15637/head
Wolfgang Bangerth [Mon, 3 Jul 2023 22:17:39 +0000 (16:17 -0600)]
Check vector-space-vector concepts for all vector classes.

17 months agoMerge pull request #15625 from drwells/update-reordering-module
Wolfgang Bangerth [Tue, 4 Jul 2023 01:24:15 +0000 (19:24 -0600)]
Merge pull request #15625 from drwells/update-reordering-module

Significantly expand the orientation module.

17 months agoMerge pull request #15609 from bangerth/typename
Matthias Maier [Tue, 4 Jul 2023 00:46:21 +0000 (00:46 +0000)]
Merge pull request #15609 from bangerth/typename

Standardize on 'template <typename X>.

17 months agoUse a reference argument for std::shared_ptr.
Wolfgang Bangerth [Mon, 3 Jul 2023 23:48:30 +0000 (17:48 -0600)]
Use a reference argument for std::shared_ptr.

17 months agoTriaIterator: return a proper Accessor temporary 15445/head
Matthias Maier [Thu, 22 Jun 2023 22:35:57 +0000 (17:35 -0500)]
TriaIterator: return a proper Accessor temporary

17 months agoMerge pull request #15614 from bangerth/loop-tria
Matthias Maier [Mon, 3 Jul 2023 23:43:47 +0000 (23:43 +0000)]
Merge pull request #15614 from bangerth/loop-tria

Fix range-based for loops over the cells of triangulations.

17 months agoMerge pull request #15617 from tamiko/fix_cmake_caching_02
Matthias Maier [Mon, 3 Jul 2023 23:38:53 +0000 (23:38 +0000)]
Merge pull request #15617 from tamiko/fix_cmake_caching_02

CMake: avoid updating deal.II{Config,Targets}.cmake when nothing changed

17 months agoUse a simpler scheme to determine whether a DoFHandler uses hp features. 15620/head
Wolfgang Bangerth [Mon, 3 Jul 2023 23:33:49 +0000 (17:33 -0600)]
Use a simpler scheme to determine whether a DoFHandler uses hp features.

17 months agoMov reorder_old_to_new_style to tests/test_grids.h 15629/head
Daniel Arndt [Mon, 3 Jul 2023 23:26:51 +0000 (19:26 -0400)]
Mov reorder_old_to_new_style to tests/test_grids.h

17 months agoMerge pull request #15589 from masterleinad/remove_deprecated_matrix_free_evaluation
Marc Fehling [Mon, 3 Jul 2023 23:13:16 +0000 (17:13 -0600)]
Merge pull request #15589 from masterleinad/remove_deprecated_matrix_free_evaluation

Remove deprecated MatrixFree::FE[Face]::Evaluation functions taking bools

17 months agoMerge pull request #15600 from tamiko/fix_scalapack
Matthias Maier [Mon, 3 Jul 2023 23:03:55 +0000 (23:03 +0000)]
Merge pull request #15600 from tamiko/fix_scalapack

lac/scalapack.cc: fix an out-of-bounds write that leads to a double free

17 months agoMerge pull request #15601 from tamiko/fix_petsc_test
Matthias Maier [Mon, 3 Jul 2023 23:03:32 +0000 (23:03 +0000)]
Merge pull request #15601 from tamiko/fix_petsc_test

Test petsc/petsc_ts_05: avoid stack-use-after-return

17 months agoMerge pull request #15630 from tamiko/dont_run_on_drafts
Matthias Maier [Mon, 3 Jul 2023 22:29:54 +0000 (22:29 +0000)]
Merge pull request #15630 from tamiko/dont_run_on_drafts

github: do not run checks on drafts

17 months agogithub: trigger on ready_for_review event 15630/head
Matthias Maier [Mon, 3 Jul 2023 22:24:40 +0000 (17:24 -0500)]
github: trigger on ready_for_review event

17 months agogithub: do not run checks on drafts
Matthias Maier [Mon, 3 Jul 2023 20:00:30 +0000 (15:00 -0500)]
github: do not run checks on drafts

17 months agoCreate a vector space vector concept.
Wolfgang Bangerth [Mon, 3 Jul 2023 21:59:20 +0000 (15:59 -0600)]
Create a vector space vector concept.

17 months agoChange log entry
Daniel Arndt [Mon, 3 Jul 2023 19:29:34 +0000 (15:29 -0400)]
Change log entry

17 months agoRemove deprecated Triangulation::create_triangulation_compatibility
Daniel Arndt [Sun, 2 Jul 2023 13:14:49 +0000 (09:14 -0400)]
Remove deprecated Triangulation::create_triangulation_compatibility

17 months agoRemove deprecated PETScWrappers::PreconditionerBase alias
Daniel Arndt [Sun, 2 Jul 2023 18:45:18 +0000 (14:45 -0400)]
Remove deprecated PETScWrappers::PreconditionerBase alias

17 months agoRemove deprecated GridTools::cell_measure overload
Daniel Arndt [Sun, 2 Jul 2023 04:21:06 +0000 (00:21 -0400)]
Remove deprecated GridTools::cell_measure overload

17 months agoFix comment for GridTools::consistently_order_cells
Daniel Arndt [Sun, 2 Jul 2023 03:04:19 +0000 (23:04 -0400)]
Fix comment for GridTools::consistently_order_cells

17 months agoRemove MappingQCache initialize
Daniel Arndt [Sat, 1 Jul 2023 16:23:06 +0000 (12:23 -0400)]
Remove MappingQCache initialize

17 months agoRemove deprecated LinearAlgebra::CommunicationPatternBase
Daniel Arndt [Sat, 1 Jul 2023 15:44:32 +0000 (11:44 -0400)]
Remove deprecated LinearAlgebra::CommunicationPatternBase

17 months agoRemove deprecated TriaAccessor::number_of_children()
Daniel Arndt [Sat, 1 Jul 2023 15:24:28 +0000 (11:24 -0400)]
Remove deprecated TriaAccessor::number_of_children()

17 months agoFix tests 15401/head
Daniel Arndt [Wed, 21 Jun 2023 17:22:41 +0000 (13:22 -0400)]
Fix tests

17 months agoMerge pull request #15616 from drwells/more-17-updates
Matthias Maier [Mon, 3 Jul 2023 21:25:38 +0000 (21:25 +0000)]
Merge pull request #15616 from drwells/more-17-updates

Update the documentation in a few places to refer to C++17.

17 months agoMerge pull request #15613 from tamiko/fix_cmake_caching_01
Matthias Maier [Mon, 3 Jul 2023 21:25:02 +0000 (21:25 +0000)]
Merge pull request #15613 from tamiko/fix_cmake_caching_01

CMake: fix caching of C++ language feature checks

17 months agoMerge pull request #15612 from tamiko/fix_compilation_with_trilinos_12.14
Matthias Maier [Mon, 3 Jul 2023 21:24:41 +0000 (21:24 +0000)]
Merge pull request #15612 from tamiko/fix_compilation_with_trilinos_12.14

lac/trilinos_tpetra...h: Fix compilation on Ubuntu 20.04

17 months agoFix more tests
Daniel Arndt [Mon, 3 Jul 2023 21:24:21 +0000 (17:24 -0400)]
Fix more tests

17 months agobase/exceptions.h: avoid warnings in Trilinos / Kokkos headers 15636/head
Matthias Maier [Mon, 3 Jul 2023 21:13:12 +0000 (16:13 -0500)]
base/exceptions.h: avoid warnings in Trilinos / Kokkos headers

gcc might emit a warning depending on inlining and optimization, even
though we include the header in question with -isystem. Thus, let us
explicitly disable diagnostics while parsing the Kokkos header.
Otherwise, the following warning might get emitted:
```
[1/1] Building CXX object source/base/CMakeFiles/object_base_release.dir/partitioner.cc.o
In file included from /usr/include/trilinos/desul/atomics/Fetch_Op.hpp:30,
                 from /usr/include/trilinos/desul/atomics/Generic.hpp:13,
                 from /usr/include/trilinos/desul/atomics/Atomic_Ref.hpp:14,
                 from /usr/include/trilinos/desul/atomics.hpp:12,
                 from /usr/include/trilinos/Kokkos_Atomics_Desul_Wrapper.hpp:28,
                 from /usr/include/trilinos/Kokkos_Atomic.hpp:50,
                 from /usr/include/trilinos/impl/Kokkos_Atomic_View.hpp:20,
                 from /usr/include/trilinos/impl/Kokkos_ViewMapping.hpp:32,
                 from /usr/include/trilinos/Kokkos_View.hpp:489,
                 from /usr/include/trilinos/Kokkos_Parallel.hpp:31,
                 from /usr/include/trilinos/Kokkos_MemoryPool.hpp:26,
                 from /usr/include/trilinos/Kokkos_TaskScheduler.hpp:34,
                 from /usr/include/trilinos/Kokkos_Serial.hpp:36,
                 from /usr/include/trilinos/decl/Kokkos_Declare_SERIAL.hpp:21,
                 from /usr/include/trilinos/KokkosCore_Config_DeclareBackend.hpp:22,
                 from /usr/include/trilinos/Kokkos_Core.hpp:45,
                 from /home/tamiko/workspace/dealii/include/deal.II/base/exceptions.h:21,
                 from /home/tamiko/workspace/dealii/include/deal.II/base/array_view.h:21,
                 from /home/tamiko/workspace/dealii/include/deal.II/base/mpi.h:21,
                 from /home/tamiko/workspace/dealii/include/deal.II/base/mpi_consensus_algorithms.h:21,
                 from /home/tamiko/workspace/dealii/include/deal.II/base/mpi_compute_index_owner_internal.h:21,
                 from /home/tamiko/workspace/dealii/source/base/partitioner.cc:16:
In function ‘T desul::Impl::host_atomic_fetch_oper(const Oper&, T*, dont_deduce_this_parameter_t<const T>, MemoryOrder, desul::MemoryScopeCaller) [with Oper = sub_operator<int, const int>; T = int; MemoryOrder = desul::MemoryOrderRelaxed]’,
    inlined from ‘T desul::Impl::host_atomic_fetch_sub(T*, T, MemoryOrder, MemoryScope) [with T = int; MemoryOrder = desul::MemoryOrderRelaxed; MemoryScope = desul::MemoryScopeCaller]’ at /usr/include/trilinos/desul/atomics/Fetch_Op_Generic.hpp:40:1,
    inlined from ‘T desul::atomic_fetch_sub(T*, T, MemoryOrder, MemoryScope) [with T = int; MemoryOrder = MemoryOrderRelaxed; MemoryScope = MemoryScopeCaller]’ at /usr/include/trilinos/desul/atomics/Generic.hpp:54:3,
    inlined from ‘T Kokkos::atomic_fetch_sub(T*, desul::Impl::dont_deduce_this_parameter_t<const T>) [with T = int]’ at /usr/include/trilinos/Kokkos_Atomics_Desul_Wrapper.hpp:85:125,
    inlined from ‘void Kokkos::Impl::HostSharedPtr<T>::cleanup() [with T = Kokkos::Impl::SerialInternal]’ at /usr/include/trilinos/impl/Kokkos_HostSharedPtr.hpp:120:5,
    inlined from ‘Kokkos::Impl::HostSharedPtr<T>::~HostSharedPtr() [with T = Kokkos::Impl::SerialInternal]’ at /usr/include/trilinos/impl/Kokkos_HostSharedPtr.hpp:92:45,
    inlined from ‘Kokkos::Serial::~Serial()’ at /usr/include/trilinos/Kokkos_Serial.hpp:87:7,
    inlined from ‘Kokkos::RangePolicy<Kokkos::Serial, Kokkos::IndexType<int> >::~RangePolicy()’ at /usr/include/trilinos/Kokkos_ExecPolicy.hpp:67:7,
    inlined from ‘void Kokkos::parallel_for(const std::string&, const ExecPolicy&, const FunctorType&) [with ExecPolicy = RangePolicy<Serial, IndexType<int> >; FunctorType = Impl::ViewFill<View<int*, LayoutRight, Device<Serial, AnonymousSpace>, MemoryTraits<0> >, LayoutRight, Serial, 1, int>; Enable = void]’ at /usr/include/trilinos/Kokkos_Parallel.hpp:147:1:
/usr/include/trilinos/desul/atomics/Fetch_Op_ScopeCaller.hpp:44:1: warning: pointer used after ‘void operator delete(void*, std::size_t)’ [-Wuse-after-free]
   44 | DESUL_IMPL_ATOMIC_FETCH_OPER(DESUL_IMPL_HOST_FUNCTION, host)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/tamiko/workspace/dealii/include/deal.II/base/numbers.h:28,
                 from /home/tamiko/workspace/dealii/build/include/deal.II/base/config.h:579,
                 from /home/tamiko/workspace/dealii/include/deal.II/base/mpi_compute_index_owner_internal.h:19:
In member function ‘void Kokkos::Impl::HostSharedPtr<T>::cleanup() [with T = Kokkos::Impl::SerialInternal]’,
    inlined from ‘Kokkos::Impl::HostSharedPtr<T>::~HostSharedPtr() [with T = Kokkos::Impl::SerialInternal]’ at /usr/include/trilinos/impl/Kokkos_HostSharedPtr.hpp:92:45,
    inlined from ‘Kokkos::Serial::~Serial()’ at /usr/include/trilinos/Kokkos_Serial.hpp:87:7,
    inlined from ‘Kokkos::RangePolicy<Kokkos::Serial, Kokkos::IndexType<int> >::~RangePolicy()’ at /usr/include/trilinos/Kokkos_ExecPolicy.hpp:67:7,
    inlined from ‘Kokkos::Impl::ParallelFor<Kokkos::Impl::ViewFill<Kokkos::View<int*, Kokkos::LayoutRight, Kokkos::Device<Kokkos::Serial, Kokkos::AnonymousSpace>, Kokkos::MemoryTraits<0> >, Kokkos::LayoutRight, Kokkos::Serial, 1, int>, Kokkos::RangePolicy<Kokkos::Serial, Kokkos::IndexType<int> >, Kokkos::Serial>::~ParallelFor()’ at /usr/include/trilinos/Serial/Kokkos_Serial_Parallel_Range.hpp:26:7,
    inlined from ‘void Kokkos::parallel_for(const std::string&, const ExecPolicy&, const FunctorType&) [with ExecPolicy = RangePolicy<Serial, IndexType<int> >; FunctorType = Impl::ViewFill<View<int*, LayoutRight, Device<Serial, AnonymousSpace>, MemoryTraits<0> >, LayoutRight, Serial, 1, int>; Enable = void]’ at /usr/include/trilinos/Kokkos_Parallel.hpp:147:1:
/usr/include/trilinos/impl/Kokkos_HostSharedPtr.hpp:120:5: note: call to ‘void operator delete(void*, std::size_t)’ here
  120 |     KOKKOS_IF_ON_HOST((
      |     ^~~~~~~~~~~~~~~~~
```


In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.