From 1792e070c67c34c377a4a0410aec22361063b5f6 Mon Sep 17 00:00:00 2001 From: Denis Davydov Date: Fri, 3 Apr 2015 08:29:28 +0200 Subject: [PATCH] added comments and FIXME --- include/deal.II/numerics/vector_tools.templates.h | 12 +++++++++--- source/numerics/data_out_dof_data.cc | 2 ++ 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/include/deal.II/numerics/vector_tools.templates.h b/include/deal.II/numerics/vector_tools.templates.h index c6eab08807..05892ca6f0 100644 --- a/include/deal.II/numerics/vector_tools.templates.h +++ b/include/deal.II/numerics/vector_tools.templates.h @@ -6407,10 +6407,11 @@ namespace VectorTools dealii::hp::FECollection fe_collection (dof.get_fe()); IDScratchData data(mapping, fe_collection, q, update_flags); - //FIXME - // temporary vectors of consistent with InVector type + // FIXME + // temporary vectors of consistent with InVector type. + // Need these because IDScratchData does not have a template type for the InVector std::vector> function_values; - std::vector >> function_grads; + std::vector > > function_grads; // loop over all cells for (typename DH::active_cell_iterator cell = dof.begin_active(); @@ -7059,6 +7060,11 @@ namespace VectorTools p_d_triangulation = dynamic_cast *>(&dof.get_tria())) { + // The type used to store the elements of the global vector may be a + // real or a complex number. Do the global reduction always with real + // and imaginary types so that we don't have to distinguish, and to this + // end just copy everything into a complex number and, later, back into + // the original data type. std::complex mean_double = mean; double my_values[3] = { mean_double.real(), mean_double.imag(), area }; double global_values[3]; diff --git a/source/numerics/data_out_dof_data.cc b/source/numerics/data_out_dof_data.cc index c232c21c50..dfdb6cf8cf 100644 --- a/source/numerics/data_out_dof_data.cc +++ b/source/numerics/data_out_dof_data.cc @@ -611,6 +611,7 @@ namespace internal get_function_hessians (const FEValuesBase &fe_patch_values, std::vector > > &patch_hessians_system) const { + // FIXME std::vector > > tmp(patch_hessians_system.size()); for (unsigned int i = 0; i < tmp.size(); i++) tmp[i].resize(patch_hessians_system[i].size()); @@ -628,6 +629,7 @@ namespace internal get_function_hessians (const FEValuesBase &fe_patch_values, std::vector > &patch_hessians) const { + // FIXME std::vector > tmp(patch_hessians.size()); fe_patch_values.get_function_hessians (*vector, tmp); for (unsigned int i = 0; i < tmp.size(); i++) -- 2.39.5