From 41d4678230e24635583eb892fdf473c5d6847a05 Mon Sep 17 00:00:00 2001 From: Timo Heister Date: Wed, 25 Oct 2017 10:07:22 -0400 Subject: [PATCH] Avoid numdiff check race condition in test Do not remove the test files to avoid a race condition if cmake decides to rerun in a concurrent situation. Otherwise this would trigger the following error: "The detected numdiff executable was not able to pass a simple relative tolerance test." --- cmake/macros/macro_deal_ii_pickup_tests.cmake | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/cmake/macros/macro_deal_ii_pickup_tests.cmake b/cmake/macros/macro_deal_ii_pickup_tests.cmake index 1ce3748519..3284f6dc21 100644 --- a/cmake/macros/macro_deal_ii_pickup_tests.cmake +++ b/cmake/macros/macro_deal_ii_pickup_tests.cmake @@ -164,11 +164,10 @@ MACRO(DEAL_II_PICKUP_TESTS) RESULT_VARIABLE _numdiff_tolerance_test_status ) - # - # Tidy up: - # - FILE(REMOVE ${_first_test_file_name}) - FILE(REMOVE ${_second_test_file_name}) + # Note: We do not remove the test files to avoid a race condition if + # cmake decides to rerun in a concurrent situation: + # FILE(REMOVE ${_first_test_file_name}) + # FILE(REMOVE ${_second_test_file_name}) IF(NOT "${_numdiff_tolerance_test_status}" STREQUAL "0") MESSAGE(FATAL_ERROR -- 2.39.5