From 61f927a207672692bef371f6c5c6a1f10e9f3af7 Mon Sep 17 00:00:00 2001 From: Wolfgang Bangerth Date: Thu, 29 Mar 2001 15:33:15 +0000 Subject: [PATCH] Move contents of TODO file into .h and .cc files. git-svn-id: https://svn.dealii.org/trunk@4335 0785d39b-7218-0410-832d-ea1e28bc413d --- deal.II/lac/Todo | 21 ------------------- deal.II/lac/include/lac/solver_bicgstab.h | 1 + .../lac/include/lac/sparse_ilu.templates.h | 1 + deal.II/lac/include/lac/vector.h | 1 + deal.II/lac/include/lac/vector_memory.h | 1 + 5 files changed, 4 insertions(+), 21 deletions(-) delete mode 100644 deal.II/lac/Todo diff --git a/deal.II/lac/Todo b/deal.II/lac/Todo deleted file mode 100644 index 13179f9f00..0000000000 --- a/deal.II/lac/Todo +++ /dev/null @@ -1,21 +0,0 @@ -================================================================= -====== Things to be done for the lac library ================ -================================================================= - - -Make ILU decomposition faster by following the comment in the - innermost loop (about the better use of the index j). - - -Why not replace Vector::scale by Vector::operator *= ? - - -Use the commented-out version in PreconditionBlock::invert_diagblocks - using the try-catch clauses - - -GrowingVectorMemory is not thread-safe. Use a Mutex to fix this. - - -Implement "use the length of the computed orthogonal residual" in the - BiCGStab method. \ No newline at end of file diff --git a/deal.II/lac/include/lac/solver_bicgstab.h b/deal.II/lac/include/lac/solver_bicgstab.h index fb5b13040e..63a282e657 100644 --- a/deal.II/lac/include/lac/solver_bicgstab.h +++ b/deal.II/lac/include/lac/solver_bicgstab.h @@ -284,6 +284,7 @@ typename Solver::ReturnState SolverBicgstab::iterate(const MATRIX& A, const PRECONDITIONER& precondition) { +//TODO:[GK] Implement "use the length of the computed orthogonal residual" in the BiCGStab method. SolverControl::State state = SolverControl::iterate; alpha = omega = rho = 1.; diff --git a/deal.II/lac/include/lac/sparse_ilu.templates.h b/deal.II/lac/include/lac/sparse_ilu.templates.h index c77bd18ac5..b12ad24d3e 100644 --- a/deal.II/lac/include/lac/sparse_ilu.templates.h +++ b/deal.II/lac/include/lac/sparse_ilu.templates.h @@ -186,6 +186,7 @@ void SparseILU::decompose (const SparseMatrix &matrix, j<&column_numbers[rowstart_indices[row+1]]; ++j) { +//TODO:[WB] make code faster by using the following comment // note: this inner loop could // be made considerable faster // if we consulted the row diff --git a/deal.II/lac/include/lac/vector.h b/deal.II/lac/include/lac/vector.h index 58caee7cc3..723648035f 100644 --- a/deal.II/lac/include/lac/vector.h +++ b/deal.II/lac/include/lac/vector.h @@ -367,6 +367,7 @@ class Vector * Scale each element of the vector by the * given factor. */ +//TODO:[?] Why not have an operator *= instead of/in addition to `scale'? void scale (const Number factor); /** diff --git a/deal.II/lac/include/lac/vector_memory.h b/deal.II/lac/include/lac/vector_memory.h index aa7c21f77d..787ce13ce9 100644 --- a/deal.II/lac/include/lac/vector_memory.h +++ b/deal.II/lac/include/lac/vector_memory.h @@ -109,6 +109,7 @@ class PrimitiveVectorMemory : public VectorMemory * * @author Guido Kanschat, 1999 */ +//TODO:[GK,WB] GrowingVectorMemory is not thread-safe. use a mutex to synchronise template > class GrowingVectorMemory : public VectorMemory { -- 2.39.5