From 786aaf32c828d5d373099e5080ff961f52606f58 Mon Sep 17 00:00:00 2001 From: Luca Heltai Date: Tue, 5 Dec 2017 15:02:33 +0100 Subject: [PATCH] Fixed WB's comments --- include/deal.II/opencascade/utilities.h | 10 +++++++--- source/opencascade/utilities.cc | 5 ++--- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/include/deal.II/opencascade/utilities.h b/include/deal.II/opencascade/utilities.h index e51525d215..8d16be67e2 100644 --- a/include/deal.II/opencascade/utilities.h +++ b/include/deal.II/opencascade/utilities.h @@ -226,14 +226,18 @@ namespace OpenCASCADE /** * Given a Triangulation and an optional Mapping, create a vector of smooth * curves that interpolate the connected parts of the boundary vertices of - * the Triangulation and return them as a vector of TopoDS_Edge. + * the Triangulation and return them as a vector of TopoDS_Edge objects. + * + * This function constructs closed Bspline curve objects passing through all + * vertices of the boundary of the triangulation, with $C^2$ Continuity on + * each vertex except the first, where only $C^1$ continuity is guaranteed. * * The returned curves are ordered with respect to the indices of the faces * that make up the triangulation boundary, i.e., the first curve is the one * extracted starting from the face with the lowest index, and so on. * - * @param[input] triangulation Input triangulation - * @param[input] mapping Optional input mapping + * @param[in] triangulation Input triangulation + * @param[in] mapping Optional input mapping * @return An std::vector of TopoDS_Edge objects representing the smooth * interpolation of the boundary of the `triangulation` * diff --git a/source/opencascade/utilities.cc b/source/opencascade/utilities.cc index 77429dbd42..4f99bdb804 100644 --- a/source/opencascade/utilities.cc +++ b/source/opencascade/utilities.cc @@ -485,8 +485,8 @@ namespace OpenCASCADE { // get global face and vertex indices face_index = cell->face(f)->index(); - unsigned int v0 = cell->face(f)->vertex_index(0); - unsigned int v1 = cell->face(f)->vertex_index(1); + const unsigned int v0 = cell->face(f)->vertex_index(0); + const unsigned int v1 = cell->face(f)->vertex_index(1); face_to_verts[face_index].first = v0; face_to_verts[face_index].second = v1; visited_faces[face_index] = false; @@ -552,7 +552,6 @@ namespace OpenCASCADE while (point_index != start_point_index); interpolation_curves.push_back(interpolation_curve(pointlist, Tensor<1,3>(), true)); - pointlist.clear(); finished = true; for (const auto &f : visited_faces) -- 2.39.5