From 88f257235ab6942600dfe31203c3925c1903095a Mon Sep 17 00:00:00 2001
From: young <young@0785d39b-7218-0410-832d-ea1e28bc413d>
Date: Tue, 22 Oct 2013 22:33:52 +0000
Subject: [PATCH] Notes.

git-svn-id: https://svn.dealii.org/branches/branch_petscscalar_complex@31394 0785d39b-7218-0410-832d-ea1e28bc413d
---
 deal.II/include/deal.II/numerics/vector_tools.templates.h | 2 +-
 deal.II/source/fe/fe_tools_interpolate.cc                 | 7 ++++---
 deal.II/source/grid/grid_refinement.cc                    | 4 ++--
 deal.II/source/numerics/matrix_tools.cc                   | 1 -
 deal.II/source/numerics/point_value_history.cc            | 6 ++++--
 5 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/deal.II/include/deal.II/numerics/vector_tools.templates.h b/deal.II/include/deal.II/numerics/vector_tools.templates.h
index 640e7d6476..fbd443823b 100644
--- a/deal.II/include/deal.II/numerics/vector_tools.templates.h
+++ b/deal.II/include/deal.II/numerics/vector_tools.templates.h
@@ -303,7 +303,7 @@ namespace VectorTools
     for (; h != endh; ++h, ++l)
       {
 	// @whattodo Some of the problems in petsc_vector_base.h are instantiated here.
-	/* h->get_dof_values(data_1, cell_data_1); // <- complaint line 655  */
+	/* h->get_dof_values(data_1, cell_data_1); // <- complaint line 655 */
 	Assert ((false), ExcMessage ("This function is corrupt: @whattodo"));
 
         transfer.vmult(cell_data_2, cell_data_1);
diff --git a/deal.II/source/fe/fe_tools_interpolate.cc b/deal.II/source/fe/fe_tools_interpolate.cc
index 405a8682a2..ce4ea5f3c8 100644
--- a/deal.II/source/fe/fe_tools_interpolate.cc
+++ b/deal.II/source/fe/fe_tools_interpolate.cc
@@ -211,7 +211,7 @@ namespace FETools
     // if we work on parallel distributed
     // vectors, we have to ensure, that we only
     // work on dofs this processor owns.
-    IndexSet  locally_owned_dofs = dof2.locally_owned_dofs();
+    IndexSet locally_owned_dofs = dof2.locally_owned_dofs();
 
     // when a discontinuous element is
     // interpolated to a continuous
@@ -222,14 +222,15 @@ namespace FETools
     for (types::global_dof_index i=0; i<dof2.n_dofs(); ++i)
       if (locally_owned_dofs.is_element(i))
         {
-	  // @whattodo
-          // Assert(touch_count(i)!=0, ExcInternalError());
+	  // @whattodo Workaround: Add a function is_zero like is_finite?
+	  // Assert(touch_count(i)!=0, ExcInternalError());
 	  Assert ((false), ExcMessage ("This function is corrupt: @whattodo"));
           u2(i) /= touch_count(i);
         }
 
     // finish the work on parallel vectors
     u2.compress(VectorOperation::insert);
+
     // Apply hanging node constraints.
     constraints.distribute(u2);
   }
diff --git a/deal.II/source/grid/grid_refinement.cc b/deal.II/source/grid/grid_refinement.cc
index bfa57d6465..ced9477136 100644
--- a/deal.II/source/grid/grid_refinement.cc
+++ b/deal.II/source/grid/grid_refinement.cc
@@ -69,7 +69,7 @@ namespace
       // to get the array of values from PETSc
       // in every iteration), but works
       PetscScalar m = 0;
-      // @whattodo
+      // @whattodo How do we get the maximum element of a complex vector? This only makes sense in real.
       // for (unsigned int i=0; i<criteria.size(); ++i)
       //   m = std::max (m, criteria(i));
       Assert ((false), ExcMessage ("This function is corrupt: @whattodo"));
@@ -84,7 +84,7 @@ namespace
       // to get the array of values from PETSc
       // in every iteration), but works
       PetscScalar m = criteria(0);
-      // @whattodo
+      // @whattodo How do we get the minimum element of a complex vector? This only makes sense in real.
       // for (unsigned int i=1; i<criteria.size(); ++i)
       //   m = std::min (m, criteria(i));
       Assert ((false), ExcMessage ("This function is corrupt: @whattodo"));
diff --git a/deal.II/source/numerics/matrix_tools.cc b/deal.II/source/numerics/matrix_tools.cc
index 5779144510..68efe162d9 100644
--- a/deal.II/source/numerics/matrix_tools.cc
+++ b/deal.II/source/numerics/matrix_tools.cc
@@ -2372,7 +2372,6 @@ namespace MatrixTools
         // find such an entry, take one
 
 	// @whattodo Note: this is a real mess.
-	// Toby: see old notes from Diabelka
         PetscScalar average_nonzero_diagonal_entry;
         // PetscScalar average_nonzero_diagonal_entry = 1;
         // for (types::global_dof_index i=local_range.first; i<local_range.second; ++i)
diff --git a/deal.II/source/numerics/point_value_history.cc b/deal.II/source/numerics/point_value_history.cc
index 53bd353f6d..0df772c303 100644
--- a/deal.II/source/numerics/point_value_history.cc
+++ b/deal.II/source/numerics/point_value_history.cc
@@ -584,6 +584,7 @@ void PointValueHistory<dim>
   // to check vector_name is in the map.
   typename std::map <std::string, std::vector <std::vector <double> > >::iterator data_store_field = data_store.find(vector_name);
   Assert (data_store_field != data_store.end(), ExcMessage("vector_name not in class"));
+
   // Repeat for component_mask
   typename std::map <std::string, ComponentMask>::iterator mask = component_mask.find(vector_name);
   Assert (mask != component_mask.end(), ExcMessage("vector_name not in class"));
@@ -603,10 +604,11 @@ void PointValueHistory<dim>
           if (mask->second[comp])
             {
               unsigned int solution_index = point->solution_indices[comp];
-	      //@whattodo
+	      //@whattodo data_store_field shoud be typename VECTOR::value_type, but that cuase problems elsewhere...
               (void) solution_index; // stop g++ complaining: eventually remove this
               (void) n_stored;       // stop g++ complaining: eventually remove this
-              // data_store_field->second[data_store_index * n_stored + store_index].push_back (solution (solution_index));
+    
+	      // data_store_field->second[data_store_index * n_stored + store_index].push_back (solution (solution_index));
 	      Assert ((false), ExcMessage ("This function is corrupt: @whattodo"));
 
               store_index++;
-- 
2.39.5