From 8a0ad6f9e7c1c215c3ceba22562b0bd6906433bf Mon Sep 17 00:00:00 2001 From: Daniel Garcia-Sanchez Date: Wed, 23 Dec 2020 12:46:57 +0100 Subject: [PATCH] Remove the paragraph about HDF5 and exceptions MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This paragraph is no longer needed. The destructor calls MPI_Abort(). --- include/deal.II/base/hdf5.h | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/include/deal.II/base/hdf5.h b/include/deal.II/base/hdf5.h index 0263e1f408..c24dc47780 100644 --- a/include/deal.II/base/hdf5.h +++ b/include/deal.II/base/hdf5.h @@ -326,38 +326,6 @@ DEAL_II_NAMESPACE_OPEN * thread-safe HDF5 version serializes the API but does not provide any level of * concurrency. To achieve high parallel performance with HDF5, we advice to use * HDF5 with MPI. - * - * # Exceptions and parallel HDF5 - * In certain corner cases, exceptions combined with parallel HDF5 can freeze - * deal.II. If one MPI process throws an exception and not the other ones, then - * deal.II freezes. The reason is that the following happens: - * 1. On the processor that calls the exception we try to close the parallel - * MPI file (H5F_try_close) which ultimately results in a barrier - * (MPI_barrier). This is triggered by the destructor of an HDF5Object. - * 2. On the processor that does not call the exception we call - * H5VL_dataset_write() and end up in MPI_Allreduce(). - * - * This could happen if an error is found in all the processes except one. For - * example, the following code could potentially freeze deal.II: - * @code - * HDF5::File data_file(filename, - * HDF5::File::FileAccessMode::create, - * mpi_communicator); - * { - * auto dataset_a = - * data_file.create_dataset(dataset_name_a, dataset_dimensions_a); - * dataset_a.write_selection(data_a, coordinates_a); - * } - * - * AssertThrow(Utilities::MPI::this_mpi_process(mpi_communicator) == 0, - * ExcInternalError()); - * - * { - * auto dataset_b = - * data_file.create_dataset(dataset_name_b, dataset_dimensions_b); - * dataset_b.write_selection(data_b, coordinates_b); - * } - * @endcode */ // clang-format on namespace HDF5 -- 2.39.5