From a2f0464974456b85bd1d3f88189df15ceb6355d9 Mon Sep 17 00:00:00 2001 From: David Wells Date: Wed, 25 Jan 2023 22:32:44 -0500 Subject: [PATCH] Add some comments describing our orientation implementation. --- include/deal.II/grid/reference_cell.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/include/deal.II/grid/reference_cell.h b/include/deal.II/grid/reference_cell.h index 286f7f2855..c65f7ae2bd 100644 --- a/include/deal.II/grid/reference_cell.h +++ b/include/deal.II/grid/reference_cell.h @@ -1445,7 +1445,10 @@ ReferenceCell::face_reference_cell(const unsigned int face_no) const inline constexpr unsigned char ReferenceCell::default_combined_face_orientation() { - return 1u; + // Our convention is that 'orientation' has a default value of true and + // occupies the least-significant bit while rotate and flip have default + // values of 'false' and occupy the second and third bits. + return 0b001; } @@ -1453,7 +1456,9 @@ ReferenceCell::default_combined_face_orientation() inline constexpr unsigned char ReferenceCell::reversed_combined_line_orientation() { - return 0u; + // For a reversed line 'orientation' is false and neither flip nor rotate are + // defined. + return 0b000; } -- 2.39.5