From a55c8f0dd3dc2df3acee62700554c8aad3ee1d41 Mon Sep 17 00:00:00 2001
From: Peter Munch <peterrmuench@gmail.com>
Date: Wed, 15 Jul 2020 14:53:14 +0200
Subject: [PATCH] hp::FEValues::reinit() pass be reference

---
 include/deal.II/hp/fe_values.h | 12 ++++++------
 source/hp/fe_values.cc         | 30 +++++++++++++++---------------
 source/hp/fe_values.inst.in    | 12 ++++++------
 3 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/include/deal.II/hp/fe_values.h b/include/deal.II/hp/fe_values.h
index 2debb37cb5..afa767edfa 100644
--- a/include/deal.II/hp/fe_values.h
+++ b/include/deal.II/hp/fe_values.h
@@ -351,7 +351,7 @@ namespace hp
      */
     template <bool lda>
     void
-    reinit(const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> cell,
+    reinit(const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> &cell,
            const unsigned int q_index       = numbers::invalid_unsigned_int,
            const unsigned int mapping_index = numbers::invalid_unsigned_int,
            const unsigned int fe_index      = numbers::invalid_unsigned_int);
@@ -470,8 +470,8 @@ namespace hp
      */
     template <bool lda>
     void
-    reinit(const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> cell,
-           const unsigned int                                      face_no,
+    reinit(const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> &cell,
+           const unsigned int                                       face_no,
            const unsigned int q_index       = numbers::invalid_unsigned_int,
            const unsigned int mapping_index = numbers::invalid_unsigned_int,
            const unsigned int fe_index      = numbers::invalid_unsigned_int);
@@ -566,9 +566,9 @@ namespace hp
      */
     template <bool lda>
     void
-    reinit(const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> cell,
-           const unsigned int                                      face_no,
-           const unsigned int                                      subface_no,
+    reinit(const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> &cell,
+           const unsigned int                                       face_no,
+           const unsigned int                                       subface_no,
            const unsigned int q_index       = numbers::invalid_unsigned_int,
            const unsigned int mapping_index = numbers::invalid_unsigned_int,
            const unsigned int fe_index      = numbers::invalid_unsigned_int);
diff --git a/source/hp/fe_values.cc b/source/hp/fe_values.cc
index aa7c60f983..aa71011de2 100644
--- a/source/hp/fe_values.cc
+++ b/source/hp/fe_values.cc
@@ -226,10 +226,10 @@ namespace hp
   template <bool lda>
   void
   FEValues<dim, spacedim>::reinit(
-    const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> cell,
-    const unsigned int                                      q_index,
-    const unsigned int                                      mapping_index,
-    const unsigned int                                      fe_index)
+    const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> &cell,
+    const unsigned int                                       q_index,
+    const unsigned int                                       mapping_index,
+    const unsigned int                                       fe_index)
   {
     // determine which indices we
     // should actually use
@@ -337,11 +337,11 @@ namespace hp
   template <bool lda>
   void
   FEFaceValues<dim, spacedim>::reinit(
-    const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> cell,
-    const unsigned int                                      face_no,
-    const unsigned int                                      q_index,
-    const unsigned int                                      mapping_index,
-    const unsigned int                                      fe_index)
+    const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> &cell,
+    const unsigned int                                       face_no,
+    const unsigned int                                       q_index,
+    const unsigned int                                       mapping_index,
+    const unsigned int                                       fe_index)
   {
     // determine which indices we
     // should actually use
@@ -450,12 +450,12 @@ namespace hp
   template <bool lda>
   void
   FESubfaceValues<dim, spacedim>::reinit(
-    const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> cell,
-    const unsigned int                                      face_no,
-    const unsigned int                                      subface_no,
-    const unsigned int                                      q_index,
-    const unsigned int                                      mapping_index,
-    const unsigned int                                      fe_index)
+    const TriaIterator<DoFCellAccessor<dim, spacedim, lda>> &cell,
+    const unsigned int                                       face_no,
+    const unsigned int                                       subface_no,
+    const unsigned int                                       q_index,
+    const unsigned int                                       mapping_index,
+    const unsigned int                                       fe_index)
   {
     // determine which indices we
     // should actually use
diff --git a/source/hp/fe_values.inst.in b/source/hp/fe_values.inst.in
index 592ab00cbd..8452c99ca5 100644
--- a/source/hp/fe_values.inst.in
+++ b/source/hp/fe_values.inst.in
@@ -91,23 +91,23 @@ for (deal_II_dimension : DIMENSIONS; deal_II_space_dimension : SPACE_DIMENSIONS;
 
       template void
       FEValues<deal_II_dimension, deal_II_space_dimension>::reinit(
-        TriaIterator<
-          DoFCellAccessor<deal_II_dimension, deal_II_space_dimension, lda>>,
+        const TriaIterator<
+          DoFCellAccessor<deal_II_dimension, deal_II_space_dimension, lda>> &,
         unsigned int,
         unsigned int,
         unsigned int);
       template void
       FEFaceValues<deal_II_dimension, deal_II_space_dimension>::reinit(
-        TriaIterator<
-          DoFCellAccessor<deal_II_dimension, deal_II_space_dimension, lda>>,
+        const TriaIterator<
+          DoFCellAccessor<deal_II_dimension, deal_II_space_dimension, lda>> &,
         unsigned int,
         unsigned int,
         unsigned int,
         unsigned int);
       template void
       FESubfaceValues<deal_II_dimension, deal_II_space_dimension>::reinit(
-        TriaIterator<
-          DoFCellAccessor<deal_II_dimension, deal_II_space_dimension, lda>>,
+        const TriaIterator<
+          DoFCellAccessor<deal_II_dimension, deal_II_space_dimension, lda>> &,
         unsigned int,
         unsigned int,
         unsigned int,
-- 
2.39.5