From a95011f1607a77fdabba4d0dea1513229b22772e Mon Sep 17 00:00:00 2001 From: Luca Heltai Date: Thu, 28 Nov 2019 19:47:38 +0100 Subject: [PATCH] Added comments in tests. --- tests/particles/particle_handler_10.cc | 5 +++++ tests/particles/particle_handler_11.cc | 5 +++++ tests/particles/particle_handler_12.cc | 6 ++++++ 3 files changed, 16 insertions(+) diff --git a/tests/particles/particle_handler_10.cc b/tests/particles/particle_handler_10.cc index 0d8503441a..680949ae2f 100644 --- a/tests/particles/particle_handler_10.cc +++ b/tests/particles/particle_handler_10.cc @@ -90,6 +90,11 @@ main(int argc, char *argv[]) deallog.push("2d/2d"); test<2, 2>(); deallog.pop(); + // [TODO]: There is a bug that prevents this from working in dimensions <2,3> + // The construction of the bounding boxes is not robust in that case + // and there is no easy and obvious fix for the moment. Keep this here + // as a reminder that we still need to address that. + // deallog.push("2d/3d"); // test<2, 3>(); // deallog.pop(); diff --git a/tests/particles/particle_handler_11.cc b/tests/particles/particle_handler_11.cc index ce58531842..5f62a4c401 100644 --- a/tests/particles/particle_handler_11.cc +++ b/tests/particles/particle_handler_11.cc @@ -90,6 +90,11 @@ main(int argc, char *argv[]) deallog.push("2d/2d"); test<2, 2>(); deallog.pop(); + // [TODO]: There is a bug that prevents this from working in dimensions <2,3> + // The construction of the bounding boxes is not robust in that case + // and there is no easy and obvious fix for the moment. Keep this here + // as a reminder that we still need to address that. + // deallog.push("2d/3d"); // test<2, 3>(); // deallog.pop(); diff --git a/tests/particles/particle_handler_12.cc b/tests/particles/particle_handler_12.cc index bf180ca614..01edf8a094 100644 --- a/tests/particles/particle_handler_12.cc +++ b/tests/particles/particle_handler_12.cc @@ -91,6 +91,12 @@ main(int argc, char *argv[]) deallog.push("2d/2d"); test<2, 2>(); deallog.pop(); + + // [TODO]: There is a bug that prevents this from working in dimensions <2,3> + // The construction of the bounding boxes is not robust in that case + // and there is no easy and obvious fix for the moment. Keep this here + // as a reminder that we still need to address that. + // deallog.push("2d/3d"); // test<2, 3>(); // deallog.pop(); -- 2.39.5