From ccec0e5e6cb88462c7109f37e236f47c3cb11048 Mon Sep 17 00:00:00 2001 From: wolf Date: Thu, 8 Mar 2001 08:11:58 +0000 Subject: [PATCH] Some annotations. git-svn-id: https://svn.dealii.org/trunk@4168 0785d39b-7218-0410-832d-ea1e28bc413d --- deal.II/deal.II/include/fe/mapping_q.h | 5 ++++- deal.II/deal.II/source/fe/mapping_q.cc | 10 +++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/deal.II/deal.II/include/fe/mapping_q.h b/deal.II/deal.II/include/fe/mapping_q.h index fd0f76c5b1..5c33194d56 100644 --- a/deal.II/deal.II/include/fe/mapping_q.h +++ b/deal.II/deal.II/include/fe/mapping_q.h @@ -434,7 +434,7 @@ class MappingQ : public MappingQ1 * mapping of cells at the * boundary. */ - TensorProductPolynomials* tensor_pols; + TensorProductPolynomials *tensor_pols; /** * Number of the Qp tensor @@ -453,6 +453,7 @@ class MappingQ : public MappingQ1 /** * Needed for inner faces. */ +//TODO: can we make this variable static? StraightBoundary straight_boundary; /** @@ -462,6 +463,7 @@ class MappingQ : public MappingQ1 * Used to test the covariant * transformation. */ +//TODO: why have two ways to compute? if they both work, choose one and remove the other bool alternative_normals_computation; /** @@ -472,6 +474,7 @@ class MappingQ : public MappingQ1 * * The default value is false. */ +//TODO: remove use_mapping_q_on_all_cells as it is set to false in the constructor and never set again bool use_mapping_q_on_all_cells; }; diff --git a/deal.II/deal.II/source/fe/mapping_q.cc b/deal.II/deal.II/source/fe/mapping_q.cc index 04b73b163f..f42fe23efb 100644 --- a/deal.II/deal.II/source/fe/mapping_q.cc +++ b/deal.II/deal.II/source/fe/mapping_q.cc @@ -48,7 +48,9 @@ MappingQ<1>::MappingQ (unsigned int): tensor_pols(0), n_shape_functions(2), renumber(0), +//TODO: why have two ways to compute? if they both work, choose one and remove the other alternative_normals_computation(false), +//TODO: remove use_mapping_q_on_all_cells as it is set to false in the constructor and never set again use_mapping_q_on_all_cells(false) {} @@ -61,8 +63,8 @@ MappingQ<1>::~MappingQ () -template static -number power(number x, unsigned int y) +template +static number power(const number x, const unsigned int y) { number value=1; for (unsigned int i=0; i -MappingQ::MappingQ (unsigned int p): +MappingQ::MappingQ (const unsigned int p): laplace_on_quad_vector(0), laplace_on_hex_vector(0), degree(p), @@ -82,7 +84,9 @@ MappingQ::MappingQ (unsigned int p): tensor_pols(0), n_shape_functions(0), renumber(0), +//TODO: why have two ways to compute? if they both work, choose one and remove the other alternative_normals_computation(false), +//TODO: remove use_mapping_q_on_all_cells as it is set to false in the constructor and never set again use_mapping_q_on_all_cells(false) { // Construct the tensor product -- 2.39.5