From d6748c15727267c8c52afeb74dfc107e080c23ee Mon Sep 17 00:00:00 2001 From: Sam Scheuerman Date: Mon, 12 Aug 2024 15:12:22 -0600 Subject: [PATCH] Replaced void cast with [[maybe_unused]] in init_finalize.cc --- source/base/init_finalize.cc | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/source/base/init_finalize.cc b/source/base/init_finalize.cc index 2e1577412b..7f59d35984 100644 --- a/source/base/init_finalize.cc +++ b/source/base/init_finalize.cc @@ -60,20 +60,19 @@ DEAL_II_NAMESPACE_OPEN InitFinalize::Signals InitFinalize::signals = InitFinalize::Signals(); -InitFinalize::InitFinalize(int &argc, - char **&argv, +InitFinalize::InitFinalize([[maybe_unused]] int &argc, + [[maybe_unused]] char **&argv, const InitializeLibrary &libraries, const unsigned int max_num_threads) : libraries(libraries) { - static bool constructor_has_already_run = false; - (void)constructor_has_already_run; + [[maybe_unused]] static bool constructor_has_already_run = false; Assert(constructor_has_already_run == false, ExcMessage("You can only create a single object of this class " "in a program since it initializes the MPI system.")); - int ierr = 0; + [[maybe_unused]] int ierr = 0; #ifdef DEAL_II_WITH_MPI if (static_cast(libraries & InitializeLibrary::MPI)) { @@ -100,11 +99,6 @@ InitFinalize::InitFinalize(int &argc, // ExcMessage("MPI reports that we are not allowed to use multiple // threads.")); } -#else - // make sure the compiler doesn't warn about these variables - (void)argc; - (void)argv; - (void)ierr; #endif // we are allowed to call MPI_Init ourselves and PETScInitialize will @@ -434,8 +428,8 @@ InitFinalize::finalize() } else { - const int ierr = MPI_Finalize(); - (void)ierr; + [[maybe_unused]] const int ierr = MPI_Finalize(); + AssertNothrow(ierr == MPI_SUCCESS, dealii::ExcMPI(ierr)); } } -- 2.39.5