From d67a019e90954348bc1564f831db02fc10bf35e5 Mon Sep 17 00:00:00 2001
From: Peter Munch <peterrmuench@gmail.com>
Date: Tue, 16 Aug 2022 09:32:42 +0200
Subject: [PATCH] FEEvaluationData: add virtual destructor

---
 .../deal.II/matrix_free/fe_evaluation_data.h  |  5 ++
 .../matrix_free/fe_evaluation_dynamic_cast.cc | 69 +++++++++++++++++++
 .../fe_evaluation_dynamic_cast.output         |  3 +
 3 files changed, 77 insertions(+)
 create mode 100644 tests/matrix_free/fe_evaluation_dynamic_cast.cc
 create mode 100644 tests/matrix_free/fe_evaluation_dynamic_cast.output

diff --git a/include/deal.II/matrix_free/fe_evaluation_data.h b/include/deal.II/matrix_free/fe_evaluation_data.h
index f6854fb0c6..03be313a7a 100644
--- a/include/deal.II/matrix_free/fe_evaluation_data.h
+++ b/include/deal.II/matrix_free/fe_evaluation_data.h
@@ -149,6 +149,11 @@ public:
   FEEvaluationData &
   operator=(const FEEvaluationData &other);
 
+  /**
+   * Destructor.
+   */
+  virtual ~FEEvaluationData() = default;
+
   /**
    * Sets the pointers for values, gradients, hessians to the central
    * scratch_data_array inside the given scratch array, for a given number of
diff --git a/tests/matrix_free/fe_evaluation_dynamic_cast.cc b/tests/matrix_free/fe_evaluation_dynamic_cast.cc
new file mode 100644
index 0000000000..ed60607a57
--- /dev/null
+++ b/tests/matrix_free/fe_evaluation_dynamic_cast.cc
@@ -0,0 +1,69 @@
+// ---------------------------------------------------------------------
+//
+// Copyright (C) 2019 by the deal.II authors
+//
+// This file is part of the deal.II library.
+//
+// The deal.II library is free software; you can use it, redistribute
+// it, and/or modify it under the terms of the GNU Lesser General
+// Public License as published by the Free Software Foundation; either
+// version 2.1 of the License, or (at your option) any later version.
+// The full text of the license can be found in the file LICENSE.md at
+// the top level directory of deal.II.
+//
+// ---------------------------------------------------------------------
+
+
+
+// Test that FEEvaluationData is virtual.
+
+#include <deal.II/dofs/dof_handler.h>
+
+#include <deal.II/fe/fe_q.h>
+
+#include <deal.II/grid/grid_generator.h>
+
+#include <deal.II/lac/affine_constraints.h>
+
+#include <deal.II/matrix_free/fe_evaluation.h>
+#include <deal.II/matrix_free/matrix_free.h>
+
+#include "../tests.h"
+
+int
+main()
+{
+  initlog();
+
+  const unsigned int dim    = 2;
+  using Number              = double;
+  using VectorizedArrayType = VectorizedArray<Number>;
+
+  Triangulation<dim> tria;
+  GridGenerator::hyper_cube(tria);
+  DoFHandler<dim> dof(tria);
+  dof.distribute_dofs(FE_Q<dim>(1));
+
+  MatrixFree<dim, Number, VectorizedArrayType> dummy;
+
+  dummy.reinit(MappingQ1<dim>{},
+               dof,
+               AffineConstraints<double>(),
+               QGauss<1>(2));
+
+  std::unique_ptr<FEEvaluationData<dim, VectorizedArrayType, false>> phi_base =
+    std::make_unique<FEEvaluation<dim, -1, 0, 1, Number, VectorizedArrayType>>(
+      dummy);
+
+  if (dynamic_cast<FEEvaluation<dim, -1, 0, 1, Number, VectorizedArrayType> *>(
+        phi_base.get()))
+    deallog << "OK!" << std::endl;
+  else
+    deallog << "Fail!" << std::endl;
+
+  if (dynamic_cast<FEEvaluation<dim, -1, 0, 2, Number, VectorizedArrayType> *>(
+        phi_base.get()))
+    deallog << "Fail!" << std::endl;
+  else
+    deallog << "OK!" << std::endl;
+}
diff --git a/tests/matrix_free/fe_evaluation_dynamic_cast.output b/tests/matrix_free/fe_evaluation_dynamic_cast.output
new file mode 100644
index 0000000000..043986ad9a
--- /dev/null
+++ b/tests/matrix_free/fe_evaluation_dynamic_cast.output
@@ -0,0 +1,3 @@
+
+DEAL::OK!
+DEAL::OK!
-- 
2.39.5