From e422785401785db94aca5dae6d16ddd4e8a548e7 Mon Sep 17 00:00:00 2001 From: Sascha Hofstetter Date: Sun, 6 Jul 2025 20:14:25 +0200 Subject: [PATCH] Changelog, doc and test cleanup --- doc/news/changes/minor/20250701Hofstetter | 7 ++++--- doc/news/changes/minor/20250706Hofstetter | 6 ++++-- include/deal.II/grid/grid_tools_topology.h | 4 ++-- tests/grid/grid_tools_extract_ordered_boundary_vertices.cc | 4 +--- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git a/doc/news/changes/minor/20250701Hofstetter b/doc/news/changes/minor/20250701Hofstetter index 8441c69120..7bbd4dabac 100644 --- a/doc/news/changes/minor/20250701Hofstetter +++ b/doc/news/changes/minor/20250701Hofstetter @@ -1,6 +1,7 @@ New: Implementation of CGAL functionalities for 2D. -Convert a dealii cell to a CGAL::Polygon_2 -Convert a dealii triangulation to a CGAL::Polygon_2 -Perform boolean operation on two CGAL::Polygon_2 +They allow to convert a dealii cell or a +dealii triangulation to CGAL::Polygon_with_holes_2. +Moreover, boolean operations can be performed +on two CGAL::Polygon_with_holes_2.
(Sascha Hofstetter, 2025/07/01) diff --git a/doc/news/changes/minor/20250706Hofstetter b/doc/news/changes/minor/20250706Hofstetter index ff2f48033d..430777ca08 100644 --- a/doc/news/changes/minor/20250706Hofstetter +++ b/doc/news/changes/minor/20250706Hofstetter @@ -1,6 +1,8 @@ New: GridTools::extract_ordered_boundary_vertices. -The function returns a vector with all closed boundaries. -Each closed boundary is a vector with vertices. +The function returns a vector with all closed +boundaries of a triangulation. Each closed boundary +is represented as a vector with vertex indices and +coordinates (as a pair). The outer boundary is ordered counter clockwise, inner boundaries are ordered clockwise.
diff --git a/include/deal.II/grid/grid_tools_topology.h b/include/deal.II/grid/grid_tools_topology.h index a47534ef11..5732c49e4a 100644 --- a/include/deal.II/grid/grid_tools_topology.h +++ b/include/deal.II/grid/grid_tools_topology.h @@ -193,8 +193,8 @@ namespace GridTools * The vertices are in clockwise ordering for inner boundaries (holes). * * It is generally not guaranteed that the first entry of the vector is the - * outer boundary. However, when cell 0 is located on the outer boundary it is - * the case. + * outer boundary. However, when cell 0 is located on the outer boundary this + * is the case. * * The mapping argument enables the use of e.g. MappingQEulerian. * diff --git a/tests/grid/grid_tools_extract_ordered_boundary_vertices.cc b/tests/grid/grid_tools_extract_ordered_boundary_vertices.cc index 181f39b465..66946e6b3d 100644 --- a/tests/grid/grid_tools_extract_ordered_boundary_vertices.cc +++ b/tests/grid/grid_tools_extract_ordered_boundary_vertices.cc @@ -40,10 +40,8 @@ test() {"channel_with_cylinder", "0.03 : 2 : 2.0 : false"}, {"cheese", "2 , 2"}}; - for (const auto &info_pair : names_and_args) + for (const auto &[name, args] : names_and_args) { - auto name = info_pair.first; - auto args = info_pair.second; deallog << "Name: " << name << std::endl; GridGenerator::generate_from_name_and_arguments(tria_in, name, args); -- 2.39.5