From f59e2189afb642a6439e5ad08b46dae685679e43 Mon Sep 17 00:00:00 2001
From: Daniel Arndt <arndtd@ornl.gov>
Date: Thu, 9 May 2019 08:49:31 -0400
Subject: [PATCH] Match explicitly defined copy constructors with copy
 assignment operators

---
 include/deal.II/base/thread_management.h      | 12 ++++++++++++
 include/deal.II/lac/sparse_matrix.h           | 17 +++++++++++++++++
 include/deal.II/particles/particle_iterator.h |  2 +-
 source/particles/particle_iterator.cc         |  9 ---------
 4 files changed, 30 insertions(+), 10 deletions(-)

diff --git a/include/deal.II/base/thread_management.h b/include/deal.II/base/thread_management.h
index 931e7f30d7..f06cd09b5c 100644
--- a/include/deal.II/base/thread_management.h
+++ b/include/deal.II/base/thread_management.h
@@ -1532,6 +1532,18 @@ namespace Threads
      */
     Task() = default;
 
+
+    /**
+     * Copy assignment operator.
+     */
+    const Task &
+    operator=(const Task<RT> &t)
+    {
+      task_descriptor = t.task_descriptor;
+      return *this;
+    }
+
+
     /**
      * Join the task represented by this object, i.e. wait for it to finish.
      *
diff --git a/include/deal.II/lac/sparse_matrix.h b/include/deal.II/lac/sparse_matrix.h
index ec2731eee3..853700501b 100644
--- a/include/deal.II/lac/sparse_matrix.h
+++ b/include/deal.II/lac/sparse_matrix.h
@@ -378,6 +378,12 @@ namespace SparseMatrixIterators
      */
     Iterator(const SparseMatrixIterators::Iterator<number, false> &i);
 
+    /**
+     * Copy assignment operator.
+     */
+    const Iterator<number, Constness> &
+    operator=(const SparseMatrixIterators::Iterator<number, false> &i);
+
     /**
      * Prefix increment.
      */
@@ -2262,6 +2268,17 @@ namespace SparseMatrixIterators
 
 
 
+  template <typename number, bool Constness>
+  inline const Iterator<number, Constness> &
+  Iterator<number, Constness>::
+  operator=(const SparseMatrixIterators::Iterator<number, false> &i)
+  {
+    accessor = *i;
+    return *this;
+  }
+
+
+
   template <typename number, bool Constness>
   inline Iterator<number, Constness> &
   Iterator<number, Constness>::operator++()
diff --git a/include/deal.II/particles/particle_iterator.h b/include/deal.II/particles/particle_iterator.h
index 5e687fb7a9..b2b340acc5 100644
--- a/include/deal.II/particles/particle_iterator.h
+++ b/include/deal.II/particles/particle_iterator.h
@@ -66,7 +66,7 @@ namespace Particles
      * Assignment operator.
      */
     ParticleIterator &
-    operator=(const ParticleIterator &);
+    operator=(const ParticleIterator &) = default;
 
     /**
      * Dereferencing operator, returns a pointer of the particle pointed to.
diff --git a/source/particles/particle_iterator.cc b/source/particles/particle_iterator.cc
index 9b5345ee6d..2a9956817d 100644
--- a/source/particles/particle_iterator.cc
+++ b/source/particles/particle_iterator.cc
@@ -62,15 +62,6 @@ namespace Particles
   }
 
 
-  template <int dim, int spacedim>
-  ParticleIterator<dim, spacedim> &
-  ParticleIterator<dim, spacedim>::operator=(const ParticleIterator &other)
-  {
-    accessor = other.accessor;
-    return *this;
-  }
-
-
 
   template <int dim, int spacedim>
   bool
-- 
2.39.5