From f7ca6e97522f878b5e9a02e18e78dac8807c1ff1 Mon Sep 17 00:00:00 2001 From: Wolfgang Bangerth Date: Thu, 14 Jan 2021 09:29:47 -0700 Subject: [PATCH] Fix a few places for which we have the right answers after all. --- include/deal.II/fe/fe_interface_values.h | 16 ++++------------ include/deal.II/fe/fe_tools.templates.h | 12 ++++-------- .../deal.II/numerics/vector_tools_constraints.h | 6 +++--- 3 files changed, 11 insertions(+), 23 deletions(-) diff --git a/include/deal.II/fe/fe_interface_values.h b/include/deal.II/fe/fe_interface_values.h index 5887207b75..eb2bb05eb8 100644 --- a/include/deal.II/fe/fe_interface_values.h +++ b/include/deal.II/fe/fe_interface_values.h @@ -526,34 +526,26 @@ FEInterfaceValues::FEInterfaceValues( const UpdateFlags update_flags) : n_quadrature_points(quadrature.size()) , internal_fe_face_values( - // TODO: We should query the default mapping for the kind of cell - // represented by 'fe' and 'q': ReferenceCell::get_default_linear_mapping( - ReferenceCell::get_hypercube(dim)), + fe.reference_cell_type()), fe, quadrature, update_flags) , internal_fe_subface_values( - // TODO: We should query the default mapping for the kind of cell - // represented by 'fe' and 'q': ReferenceCell::get_default_linear_mapping( - ReferenceCell::get_hypercube(dim)), + fe.reference_cell_type()), fe, quadrature, update_flags) , internal_fe_face_values_neighbor( - // TODO: We should query the default mapping for the kind of cell - // represented by 'fe' and 'q': ReferenceCell::get_default_linear_mapping( - ReferenceCell::get_hypercube(dim)), + fe.reference_cell_type()), fe, quadrature, update_flags) , internal_fe_subface_values_neighbor( - // TODO: We should query the default mapping for the kind of cell - // represented by 'fe' and 'q': ReferenceCell::get_default_linear_mapping( - ReferenceCell::get_hypercube(dim)), + fe.reference_cell_type()), fe, quadrature, update_flags) diff --git a/include/deal.II/fe/fe_tools.templates.h b/include/deal.II/fe/fe_tools.templates.h index 137ab656e3..932a0552c0 100644 --- a/include/deal.II/fe/fe_tools.templates.h +++ b/include/deal.II/fe/fe_tools.templates.h @@ -2265,14 +2265,10 @@ namespace FETools tr.begin_active()->set_refine_flag(RefinementCase(ref_case)); tr.execute_coarsening_and_refinement(); - FEValues fine( - // TODO: We should query the default mapping for the kind of cell - // represented by 'fe' and 'q': - ReferenceCell::get_default_linear_mapping( - ReferenceCell::get_hypercube(dim)), - fe, - q_fine, - update_quadrature_points | update_JxW_values | update_values); + FEValues fine(fe, + q_fine, + update_quadrature_points | + update_JxW_values | update_values); typename Triangulation::cell_iterator coarse_cell = tr.begin(0); diff --git a/include/deal.II/numerics/vector_tools_constraints.h b/include/deal.II/numerics/vector_tools_constraints.h index 84c6d56c7e..b952a11fc2 100644 --- a/include/deal.II/numerics/vector_tools_constraints.h +++ b/include/deal.II/numerics/vector_tools_constraints.h @@ -303,7 +303,7 @@ namespace VectorTools const std::set &boundary_ids, AffineConstraints & constraints, const Mapping & mapping = - ReferenceCell::get_default_linear_mapping( + ReferenceCell::get_default_linear_mapping( ReferenceCell::get_hypercube(dim))); /** @@ -332,7 +332,7 @@ namespace VectorTools & function_map, AffineConstraints & constraints, const Mapping &mapping = - ReferenceCell::get_default_linear_mapping( + ReferenceCell::get_default_linear_mapping( ReferenceCell::get_hypercube(dim))); /** @@ -351,7 +351,7 @@ namespace VectorTools const std::set &boundary_ids, AffineConstraints & constraints, const Mapping & mapping = - ReferenceCell::get_default_linear_mapping( + ReferenceCell::get_default_linear_mapping( ReferenceCell::get_hypercube(dim))); //@} -- 2.39.5