From f81c675d0812978472cb849cfb7a4624dd6a9e79 Mon Sep 17 00:00:00 2001
From: Timo Heister <timo.heister@gmail.com>
Date: Mon, 4 May 2020 22:00:03 -0400
Subject: [PATCH] disable performance-no-automatic-move

---
 .clang-tidy | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index 535d39cc73..6bff358c3b 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -2,8 +2,12 @@
 #
 # See ./contrib/utilities/run_clang_tidy.sh for details
 
-# We disable performance-inefficient-string-concatenation because we don't care about "a"+to_string(5)+...
+# Rationale for disabling warnings:
+#
+# - modernize-concat-nested-namespaces: This is c++17 only.
+# - performance-inefficient-string-concatenation: We don't care about "a"+to_string(5)+...
+# - performance-no-automatic-move: All modern compiler perform the return value optimization and we prefer to keep things const.
 
-Checks: "-*,cppcoreguidelines-pro-type-static-cast-downcast,google-readability-casting,modernize-*,-modernize-pass-by-value,-modernize-raw-string-literal,-modernize-use-auto,-modernize-use-override,-modernize-use-default-member-init,-modernize-use-transparent-functors,-modernize-use-trailing-return-type,-modernize-use-nodiscard,-modernize-avoid-c-arrays,-modernize-concat-nested-namespaces,use-emplace,mpi-*,performance-*,-performance-inefficient-string-concatenation"
+Checks: "-*,cppcoreguidelines-pro-type-static-cast-downcast,google-readability-casting,modernize-*,-modernize-pass-by-value,-modernize-raw-string-literal,-modernize-use-auto,-modernize-use-override,-modernize-use-default-member-init,-modernize-use-transparent-functors,-modernize-use-trailing-return-type,-modernize-use-nodiscard,-modernize-avoid-c-arrays,-modernize-concat-nested-namespaces,use-emplace,mpi-*,performance-*,-performance-inefficient-string-concatenation,-performance-no-automatic-move"
 
 WarningsAsErrors: '*'
-- 
2.39.5