From 57b7e7d9ed70c9b64ba3c6d97a9234f329d61721 Mon Sep 17 00:00:00 2001 From: Lukas Korous Date: Thu, 13 Aug 2015 21:13:53 +0200 Subject: [PATCH] Add comments regarding the MSVC fixes. --- include/deal.II/fe/fe_face.h | 4 ++++ include/deal.II/fe/fe_poly.h | 5 ++++- include/deal.II/fe/fe_poly_face.h | 5 ++++- include/deal.II/fe/fe_poly_tensor.h | 5 ++++- 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/include/deal.II/fe/fe_face.h b/include/deal.II/fe/fe_face.h index dd51b9343f..5f2f55f709 100644 --- a/include/deal.II/fe/fe_face.h +++ b/include/deal.II/fe/fe_face.h @@ -227,6 +227,10 @@ public: get_constant_modes () const; protected: + /** + NOTE: The following functions have their definitions inlined into the class declaration + * because we otherwise run into a compiler error with MS Visual Studio. + */ virtual typename FiniteElement<1,spacedim>::InternalDataBase * get_data (const UpdateFlags, diff --git a/include/deal.II/fe/fe_poly.h b/include/deal.II/fe/fe_poly.h index fb12ed105a..4f90876b05 100644 --- a/include/deal.II/fe/fe_poly.h +++ b/include/deal.II/fe/fe_poly.h @@ -163,7 +163,10 @@ public: const unsigned int component) const; protected: - + /** + NOTE: The following function has its definition inlined into the class declaration + * because we otherwise run into a compiler error with MS Visual Studio. + */ virtual typename FiniteElement::InternalDataBase * get_data(const UpdateFlags update_flags, diff --git a/include/deal.II/fe/fe_poly_face.h b/include/deal.II/fe/fe_poly_face.h index 628a2d4fff..3f7865eb03 100644 --- a/include/deal.II/fe/fe_poly_face.h +++ b/include/deal.II/fe/fe_poly_face.h @@ -73,7 +73,10 @@ public: unsigned int get_degree () const; protected: - + /** + NOTE: The following functions have their definitions inlined into the class declaration + * because we otherwise run into a compiler error with MS Visual Studio. + */ virtual typename FiniteElement::InternalDataBase * get_data (const UpdateFlags, diff --git a/include/deal.II/fe/fe_poly_tensor.h b/include/deal.II/fe/fe_poly_tensor.h index 63b2e4b6e5..5c05271fb5 100644 --- a/include/deal.II/fe/fe_poly_tensor.h +++ b/include/deal.II/fe/fe_poly_tensor.h @@ -174,7 +174,10 @@ protected: * cell to the mesh cell. */ MappingType mapping_type; - + /** + NOTE: The following function has its definition inlined into the class declaration + * because we otherwise run into a compiler error with MS Visual Studio. + */ virtual typename FiniteElement::InternalDataBase * get_data(const UpdateFlags update_flags, -- 2.39.5