From e5b03ec9f9233d1d71c26c621a2ddc9466c63639 Mon Sep 17 00:00:00 2001 From: David Wells Date: Mon, 25 Mar 2024 08:27:10 -0400 Subject: [PATCH] QA: clean up some comments and constants. None of these are technically wrong but we need to replace 0u by the explicit reversed line orientation so that 0u can become the default later. --- tests/dofs/dof_tools_21.cc | 7 +++---- tests/dofs/dof_tools_21_b.cc | 10 +++++----- tests/dofs/dof_tools_21_b_x.cc | 18 +++++++++++------- tests/dofs/dof_tools_21_b_x_q3.cc | 18 +++++++++++------- tests/dofs/dof_tools_21_b_y.cc | 12 ++++++------ tests/dofs/dof_tools_21_c.cc | 10 +++++----- tests/dofs/dof_tools_23.cc | 7 +++---- tests/dofs/dof_tools_periodic.h | 2 +- 8 files changed, 45 insertions(+), 39 deletions(-) diff --git a/tests/dofs/dof_tools_21.cc b/tests/dofs/dof_tools_21.cc index fec68a306b..7c8d4b14df 100644 --- a/tests/dofs/dof_tools_21.cc +++ b/tests/dofs/dof_tools_21.cc @@ -32,10 +32,9 @@ // A simple test for // DoFTools:: -// make_periodicity_constraints (const FaceIterator &, -// const FaceIterator &, -// dealii::AffineConstraints &, -// const std::vector &) +// make_periodicity_constraints(const FaceIterator &, +// const FaceIterator &, +// AffineConstraints &) // // We project an already periodic function onto the FE space of // periodic functions and store the resulting L2 difference diff --git a/tests/dofs/dof_tools_21_b.cc b/tests/dofs/dof_tools_21_b.cc index 03d1928332..5692cf3b68 100644 --- a/tests/dofs/dof_tools_21_b.cc +++ b/tests/dofs/dof_tools_21_b.cc @@ -35,10 +35,10 @@ // // Test // DoFTools:: -// make_periodicity_constraints(const FaceIterator &, -// const FaceIterator &, -// dealii::AffineConstraints &, -// const std::vector &, +// make_periodicity_constraints(const FaceIterator &, +// const FaceIterator &, +// AffineConstraints &, +// const ComponentMask &, // unsigned char) // for correct behavior on non standard oriented meshes. // @@ -237,7 +237,7 @@ generate_grid(Triangulation<3> &triangulation, int orientation) /* * Print out all face DoFs and support points as well as the actual - * matching via make_periodicity_constraints + * matching via make_periodicity_constraints() */ template void diff --git a/tests/dofs/dof_tools_21_b_x.cc b/tests/dofs/dof_tools_21_b_x.cc index 228a524c86..06335a5134 100644 --- a/tests/dofs/dof_tools_21_b_x.cc +++ b/tests/dofs/dof_tools_21_b_x.cc @@ -15,11 +15,11 @@ // // Test // DoFTools:: -// make_periodicity_constraints (const FaceIterator &, -// const FaceIterator &, -// dealii::AffineConstraints &, -// const std::vector &, -// bool, bool, bool) +// make_periodicity_constraints(const FaceIterator &, +// const FaceIterator &, +// AffineConstraints &, +// const ComponentMask &, +// unsigned char) // for correct behavior on non standard oriented meshes. // // a redux of why the 21_b test failed starting in r29525. in essence, @@ -157,7 +157,7 @@ generate_grid(Triangulation<2, 3> &triangulation) /* * Print out all face DoFs and support points as well as the actual - * matching via make_periodicity_constraints + * matching via make_periodicity_constraints() */ template void @@ -196,7 +196,11 @@ print_matching(DoFHandler &dof_handler) << std::endl; DoFTools::make_periodicity_constraints( - face_1, face_2, constraint_matrix, ComponentMask(), 0u); + face_1, + face_2, + constraint_matrix, + ComponentMask(), + ReferenceCell::reversed_combined_line_orientation()); constraint_matrix.print(deallog.get_file_stream()); constraint_matrix.close(); deallog << "Matching:" << std::endl; diff --git a/tests/dofs/dof_tools_21_b_x_q3.cc b/tests/dofs/dof_tools_21_b_x_q3.cc index 245a2bcc28..7ced410c81 100644 --- a/tests/dofs/dof_tools_21_b_x_q3.cc +++ b/tests/dofs/dof_tools_21_b_x_q3.cc @@ -15,11 +15,11 @@ // // Test // DoFTools:: -// make_periodicity_constraints (const FaceIterator &, -// const FaceIterator &, -// dealii::AffineConstraints &, -// const std::vector &, -// bool, bool, bool) +// make_periodicity_constraints(const FaceIterator &, +// const FaceIterator &, +// AffineConstraints &, +// const ComponentMask &, +// unsigned char) // for correct behavior on non standard oriented meshes. // // like _21_b_x but use a Q3 element. For this, the face_flip has a @@ -191,7 +191,7 @@ generate_grid(Triangulation<2, 3> &triangulation) /* * Print out all face DoFs and support points as well as the actual - * matching via make_periodicity_constraints + * matching via make_periodicity_constraints() */ template void @@ -230,7 +230,11 @@ print_matching(DoFHandler &dof_handler) << std::endl; DoFTools::make_periodicity_constraints( - face_1, face_2, constraint_matrix, ComponentMask(), 0u); + face_1, + face_2, + constraint_matrix, + ComponentMask(), + ReferenceCell::reversed_combined_line_orientation()); constraint_matrix.print(deallog.get_file_stream()); constraint_matrix.close(); deallog << "Matching:" << std::endl; diff --git a/tests/dofs/dof_tools_21_b_y.cc b/tests/dofs/dof_tools_21_b_y.cc index 1763051683..d01e264cd9 100644 --- a/tests/dofs/dof_tools_21_b_y.cc +++ b/tests/dofs/dof_tools_21_b_y.cc @@ -15,11 +15,11 @@ // // Test // DoFTools:: -// make_periodicity_constraints (const FaceIterator &, -// const FaceIterator &, -// dealii::AffineConstraints &, -// const std::vector &, -// bool, bool, bool) +// make_periodicity_constraints(const FaceIterator &, +// const FaceIterator &, +// AffineConstraints &, +// const ComponentMask &, +// unsigned char) // for correct behavior on non standard oriented meshes. // // like _21_b_x, but with a once refined mesh @@ -157,7 +157,7 @@ generate_grid(Triangulation<2, 3> &triangulation) /* * Print out all face DoFs and support points as well as the actual - * matching via make_periodicity_constraints + * matching via make_periodicity_constraints() */ template void diff --git a/tests/dofs/dof_tools_21_c.cc b/tests/dofs/dof_tools_21_c.cc index 3cee6d118e..244219b23e 100644 --- a/tests/dofs/dof_tools_21_c.cc +++ b/tests/dofs/dof_tools_21_c.cc @@ -35,10 +35,10 @@ // // Test // DoFTools:: -// make_periodicity_constraints(const FaceIterator &, -// const FaceIterator &, -// dealii::AffineConstraints &, -// const std::vector &, +// make_periodicity_constraints(const FaceIterator &, +// const FaceIterator &, +// AffineConstraints &, +// const ComponentMask &, // unsigned char) // // for correct behavior with hanging nodes. This is done by additionally @@ -243,7 +243,7 @@ generate_grid(Triangulation<3> &triangulation, int orientation) /* * Print out all face DoFs and support points as well as the actual - * matching via make_periodicity_constraints + * matching via make_periodicity_constraints() */ template void diff --git a/tests/dofs/dof_tools_23.cc b/tests/dofs/dof_tools_23.cc index bd3bd1d576..db1742fd9d 100644 --- a/tests/dofs/dof_tools_23.cc +++ b/tests/dofs/dof_tools_23.cc @@ -32,10 +32,9 @@ // A simple test for // DoFTools:: -// make_periodicity_constraints (const FaceIterator &, -// const FaceIterator &, -// dealii::AffineConstraints &, -// const std::vector &) +// make_periodicity_constraints(const FaceIterator &, +// const FaceIterator &, +// AffineConstraints> &) // // We project an already periodic function onto the FE space of // periodic functions and store the resulting L2 difference diff --git a/tests/dofs/dof_tools_periodic.h b/tests/dofs/dof_tools_periodic.h index acd91dbd69..1cd22f04c0 100644 --- a/tests/dofs/dof_tools_periodic.h +++ b/tests/dofs/dof_tools_periodic.h @@ -15,7 +15,7 @@ // Code duplication: // This is a copy of dof_tools_common.h with a slightly different mesh -// generation to fit the assumptions made by make_periodicity_constraints +// generation to fit the assumptions made by make_periodicity_constraints() #include -- 2.39.5