From 10ef0120eddccdcc718dab61ba13d19ca375bdfe Mon Sep 17 00:00:00 2001 From: Wolfgang Bangerth Date: Thu, 7 Jul 2016 16:46:34 -0500 Subject: [PATCH] More cleanups. In particular, make a function argument a const reference. Also standardize on '^T' to denote the transpose of a matrix. --- include/deal.II/base/derivative_form.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/deal.II/base/derivative_form.h b/include/deal.II/base/derivative_form.h index 16a8409a08..f110b52154 100644 --- a/include/deal.II/base/derivative_form.h +++ b/include/deal.II/base/derivative_form.h @@ -112,7 +112,7 @@ public: /** * Computes the volume element associated with the jacobian of the * transformation F. That is to say if $DF$ is square, it computes - * $\det(DF)$, in case DF is not square returns $\sqrt(\det(DF^{t} * DF))$. + * $\det(DF)$, in case DF is not square returns $\sqrt{\det(DF^T * DF)}$. */ double determinant () const; @@ -141,9 +141,9 @@ public: private: /** - * Auxiliary function that computes (*this) * T^{t} + * Auxiliary function that computes (*this) * $T^{T}$ */ - DerivativeForm<1, dim, spacedim, Number> times_T_t (Tensor<2,dim,Number> T) const; + DerivativeForm<1, dim, spacedim, Number> times_T_t (const Tensor<2,dim,Number> &T) const; /** @@ -307,7 +307,7 @@ transpose () const template inline DerivativeForm<1, dim, spacedim,Number> -DerivativeForm::times_T_t (Tensor<2,dim,Number> T) const +DerivativeForm::times_T_t (const Tensor<2,dim,Number> &T) const { Assert( order==1, ExcMessage("Only for order == 1.")); DerivativeForm<1,dim, spacedim,Number> dest; @@ -327,13 +327,13 @@ DerivativeForm::determinant () const Assert( order==1, ExcMessage("Only for order == 1.")); if (dim == spacedim) { - Tensor<2,dim,Number> T = (Tensor<2,dim,Number>)( (*this) ); + const Tensor<2,dim,Number> T = static_cast >(*this); return dealii::determinant(T); } else { Assert( spacedim>dim, ExcMessage("Only for spacedim>dim.")); - DerivativeForm<1,spacedim,dim> DF_t = this->transpose(); + const DerivativeForm<1,spacedim,dim> DF_t = this->transpose(); Tensor<2,dim,Number> G; //First fundamental form for (unsigned int i=0; i::memory_consumption () /** * One of the uses of DerivativeForm is to apply it as a transformation. This * is what this function does. If @p T is DerivativeForm<1,dim,1> it computes - * $DF * T$, if @p T is DerivativeForm<1,dim,rank> it computes $T*DF^{t}$. + * $DF * T$, if @p T is DerivativeForm<1,dim,rank> it computes $T*DF^{T}$. * * @relates DerivativeForm * @author Sebastian Pauletti, 2011 @@ -408,7 +408,7 @@ apply_transformation (const DerivativeForm<1,dim,spacedim,Number> &DF, /** - * Similar to previous apply_transformation. It computes $T*DF^{t}$. + * Similar to previous apply_transformation. It computes $T*DF^{T}$. * * @relates DerivativeForm * @author Sebastian Pauletti, 2011 @@ -429,7 +429,7 @@ apply_transformation (const DerivativeForm<1,dim,spacedim,Number> &DF, } /** - * Similar to previous apply_transformation. It computes $DF2*DF1^{t}$ + * Similar to previous apply_transformation. It computes $DF2*DF1^{T}$ * * @relates DerivativeForm * @author Sebastian Pauletti, 2011 -- 2.39.5